From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C3ACC433E0 for ; Fri, 15 May 2020 11:50:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0A3BD20709 for ; Fri, 15 May 2020 11:50:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726278AbgEOLuB (ORCPT ); Fri, 15 May 2020 07:50:01 -0400 Received: from foss.arm.com ([217.140.110.172]:54688 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726084AbgEOLt7 (ORCPT ); Fri, 15 May 2020 07:49:59 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9EFCAD6E; Fri, 15 May 2020 04:49:58 -0700 (PDT) Received: from C02TD0UTHF1T.local (unknown [10.57.24.119]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id AA17C3F305; Fri, 15 May 2020 04:49:56 -0700 (PDT) Date: Fri, 15 May 2020 12:49:53 +0100 From: Mark Rutland To: Sudeep Holla Cc: linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Lorenzo Pieralisi , Steven Price , linux-kernel@vger.kernel.org, Arnd Bergmann , harb@amperecomputing.com Subject: Re: [PATCH v3 5/7] firmware: smccc: Refactor SMCCC specific bits into separate file Message-ID: <20200515114953.GE67718@C02TD0UTHF1T.local> References: <20200506164411.3284-1-sudeep.holla@arm.com> <20200506164411.3284-6-sudeep.holla@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200506164411.3284-6-sudeep.holla@arm.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 06, 2020 at 05:44:09PM +0100, Sudeep Holla wrote: > In order to add newer SMCCC v1.1+ functionality and to avoid cluttering > PSCI firmware driver with SMCCC bits, let us move the SMCCC specific > details under drivers/firmware/smccc/smccc.c > > We can also drop conduit and smccc_version from psci_operations structure > as SMCCC was the sole user and now it maintains those. > > No functionality change in this patch though. > > Signed-off-by: Sudeep Holla > --- > MAINTAINERS | 9 +++++++++ > drivers/firmware/Makefile | 3 ++- > drivers/firmware/psci/psci.c | 19 ++++--------------- > drivers/firmware/smccc/Makefile | 3 +++ > drivers/firmware/smccc/smccc.c | 26 ++++++++++++++++++++++++++ > include/linux/arm-smccc.h | 11 +++++++++++ > include/linux/psci.h | 2 -- > 7 files changed, 55 insertions(+), 18 deletions(-) > create mode 100644 drivers/firmware/smccc/Makefile > create mode 100644 drivers/firmware/smccc/smccc.c > > Hi Mark, Lorenzo, > > I have replicated PSCI entry in MAINTAINERS file and added myself to > for SMCCC entry. If you prefer I can merge it under PSCI. Let me know > your preference along with other review comments. > +SECURE MONITOR CALL(SMC) CALLING CONVENTION (SMCCC) > +M: Mark Rutland > +M: Lorenzo Pieralisi > +M: Sudeep Holla > +L: linux-arm-kernel@lists.infradead.org > +S: Maintained > +F: drivers/firmware/smccc/ > +F: include/linux/arm-smccc.h As per the above, I'm fine with having this separate from the PSCI entry, and I'm fine with sharing this maintainership. > diff --git a/include/linux/arm-smccc.h b/include/linux/arm-smccc.h > +/** > + * arm_smccc_version_init() - Sets SMCCC version and conduit > + * @version: SMCCC version v1.1 or above > + * @conduit: SMCCC_CONDUIT_SMC or SMCCC_CONDUIT_HVC > + * > + * When SMCCCv1.1 or above is not present, defaults to ARM_SMCCC_VERSION_1_0 > + * and SMCCC_CONDUIT_NONE respectively. > + */ > +void __init arm_smccc_version_init(u32 version, enum arm_smccc_conduit conduit); Given we only expect the PSCI code to call this, could we avoid putting this in a header and just define it within psci.c? Either way: Acked-by: Mark Rutland Thanks, Mark. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DCC1C433E1 for ; Fri, 15 May 2020 11:50:04 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0267220709 for ; Fri, 15 May 2020 11:50:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="MQpFKfNh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0267220709 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xf/0Bax1q5k1plXIAFTCYonOKmKE5Tm5h94vxqm+paA=; b=MQpFKfNhuAgD1R ELVOVp4OdlTnDKFpd69zKcQyGa146nvDHfy8O2oyTmNH6mG86KHnAPs1d24H/2LlikjuV7ZM9TH84 7cvBb9t+soZ3C/5cLL4uiKsy6nyUF1Hud/fUHbWsL5sWxJT9efPAQMJGZNXEVx1JFqONGCfRd8S5y oTsmzbyBt3p4WcLg3cdhcvYQd3dqU9CjNwKOFmpJbo1bwFG0AIwxxj72Od5x+zxvmDPuSc/S8nYMO qOsPYr004PtxlD1xlgPPnh7iiOc5MBglSn+XXOCKwYXVvsl4ioMc02mi/kb6npQjIJYKJokS+oKPY dIA4EC6K4mHU7Oytu1Ew==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jZYqp-0006cQ-GN; Fri, 15 May 2020 11:50:03 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jZYql-0006Z7-9i for linux-arm-kernel@lists.infradead.org; Fri, 15 May 2020 11:50:00 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9EFCAD6E; Fri, 15 May 2020 04:49:58 -0700 (PDT) Received: from C02TD0UTHF1T.local (unknown [10.57.24.119]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id AA17C3F305; Fri, 15 May 2020 04:49:56 -0700 (PDT) Date: Fri, 15 May 2020 12:49:53 +0100 From: Mark Rutland To: Sudeep Holla Subject: Re: [PATCH v3 5/7] firmware: smccc: Refactor SMCCC specific bits into separate file Message-ID: <20200515114953.GE67718@C02TD0UTHF1T.local> References: <20200506164411.3284-1-sudeep.holla@arm.com> <20200506164411.3284-6-sudeep.holla@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200506164411.3284-6-sudeep.holla@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200515_044959_380334_739ECA96 X-CRM114-Status: GOOD ( 18.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lorenzo Pieralisi , Arnd Bergmann , Catalin Marinas , linux-kernel@vger.kernel.org, Steven Price , harb@amperecomputing.com, Will Deacon , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, May 06, 2020 at 05:44:09PM +0100, Sudeep Holla wrote: > In order to add newer SMCCC v1.1+ functionality and to avoid cluttering > PSCI firmware driver with SMCCC bits, let us move the SMCCC specific > details under drivers/firmware/smccc/smccc.c > > We can also drop conduit and smccc_version from psci_operations structure > as SMCCC was the sole user and now it maintains those. > > No functionality change in this patch though. > > Signed-off-by: Sudeep Holla > --- > MAINTAINERS | 9 +++++++++ > drivers/firmware/Makefile | 3 ++- > drivers/firmware/psci/psci.c | 19 ++++--------------- > drivers/firmware/smccc/Makefile | 3 +++ > drivers/firmware/smccc/smccc.c | 26 ++++++++++++++++++++++++++ > include/linux/arm-smccc.h | 11 +++++++++++ > include/linux/psci.h | 2 -- > 7 files changed, 55 insertions(+), 18 deletions(-) > create mode 100644 drivers/firmware/smccc/Makefile > create mode 100644 drivers/firmware/smccc/smccc.c > > Hi Mark, Lorenzo, > > I have replicated PSCI entry in MAINTAINERS file and added myself to > for SMCCC entry. If you prefer I can merge it under PSCI. Let me know > your preference along with other review comments. > +SECURE MONITOR CALL(SMC) CALLING CONVENTION (SMCCC) > +M: Mark Rutland > +M: Lorenzo Pieralisi > +M: Sudeep Holla > +L: linux-arm-kernel@lists.infradead.org > +S: Maintained > +F: drivers/firmware/smccc/ > +F: include/linux/arm-smccc.h As per the above, I'm fine with having this separate from the PSCI entry, and I'm fine with sharing this maintainership. > diff --git a/include/linux/arm-smccc.h b/include/linux/arm-smccc.h > +/** > + * arm_smccc_version_init() - Sets SMCCC version and conduit > + * @version: SMCCC version v1.1 or above > + * @conduit: SMCCC_CONDUIT_SMC or SMCCC_CONDUIT_HVC > + * > + * When SMCCCv1.1 or above is not present, defaults to ARM_SMCCC_VERSION_1_0 > + * and SMCCC_CONDUIT_NONE respectively. > + */ > +void __init arm_smccc_version_init(u32 version, enum arm_smccc_conduit conduit); Given we only expect the PSCI code to call this, could we avoid putting this in a header and just define it within psci.c? Either way: Acked-by: Mark Rutland Thanks, Mark. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel