All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] pty04: Avoid receiving packets from all interfaces
Date: Fri, 15 May 2020 13:56:01 +0200	[thread overview]
Message-ID: <20200515115601.GA6412@dell5510> (raw)
In-Reply-To: <20200515103910.8703-1-rpalethorpe@suse.com>

Hi,

> Raw sockets receive all packets from all interfaces as soon as they are
> created. They don't need to be bound to one or more interfaces like I thought.

> This creates the socket with a NULL packet type which appears to be unused in
> the Linux kernel and receives no packets. The protocol is then changed to
> ETH_P_ALL when binding to the netdevice we are interested in.

> I assume it is impossible for a packet to have zero for its packet type. Most
> likely using ETH_P_LOOP would have been OK too, but I suppose that is really
> used by some hardware.

> This also fixes various other problems that have been observed with this
> test. Such as memory allocation failures.
So we have lost a potential CVE reproducer :).

Thanks for the fix.

Kind regards,
Petr

      parent reply	other threads:[~2020-05-15 11:56 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-15 10:39 [LTP] [PATCH] pty04: Avoid receiving packets from all interfaces Richard Palethorpe
2020-05-15 11:48 ` Cyril Hrubis
2020-05-15 12:18   ` Jan Stancek
2020-05-15 12:37     ` Jan Stancek
2020-05-15 13:27       ` Richard Palethorpe
2020-05-15 13:00     ` Petr Vorel
2020-05-15 13:55       ` Richard Palethorpe
2020-05-15 11:56 ` Petr Vorel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200515115601.GA6412@dell5510 \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.