From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A43CC433DF for ; Fri, 15 May 2020 12:38:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1D4562074D for ; Fri, 15 May 2020 12:38:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726302AbgEOMi1 (ORCPT ); Fri, 15 May 2020 08:38:27 -0400 Received: from mga07.intel.com ([134.134.136.100]:3357 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726144AbgEOMi1 (ORCPT ); Fri, 15 May 2020 08:38:27 -0400 IronPort-SDR: vmOVCjeoYqyfrZoIZVeVOihqSQ793G60qjiJ/U0NJkRU38JxaIsfhz2VFf5JJ3qziU7RmfIzBu OhkVoQ2emEqg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 May 2020 05:38:26 -0700 IronPort-SDR: AOM6JheAe7dIdYRzcBx6pLczsGNik9Ktz+q65bTBzKNtWzIDkpRPxkH5ij8g0VhpKWCkej5+wM vd8cUu4QS8dA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,395,1583222400"; d="scan'208";a="253785230" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga008.fm.intel.com with ESMTP; 15 May 2020 05:38:22 -0700 Received: from andy by smile with local (Exim 4.93) (envelope-from ) id 1jZZbc-006rEO-7B; Fri, 15 May 2020 15:38:24 +0300 Date: Fri, 15 May 2020 15:38:24 +0300 From: Andy Shevchenko To: Serge Semin Cc: Mark Brown , Serge Semin , Georgy Vlasov , Ramil Zaripov , Alexey Malahov , Thomas Bogendoerfer , Paul Burton , Ralf Baechle , Allison Randal , Gareth Williams , Arnd Bergmann , Rob Herring , linux-mips@vger.kernel.org, devicetree@vger.kernel.org, Wan Ahmad Zainie , "wuxu.wu" , Jarkko Nikula , Clement Leger , linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 07/19] spi: dw: Discard unused void priv pointer Message-ID: <20200515123824.GB185537@smile.fi.intel.com> References: <20200508132943.9826-1-Sergey.Semin@baikalelectronics.ru> <20200515104758.6934-1-Sergey.Semin@baikalelectronics.ru> <20200515104758.6934-8-Sergey.Semin@baikalelectronics.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200515104758.6934-8-Sergey.Semin@baikalelectronics.ru> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 15, 2020 at 01:47:46PM +0300, Serge Semin wrote: > Seeing the "void *priv" member of the dw_spi data structure is unused > let's remove it. The glue-layers can embed the DW APB SSI controller > descriptor into their private data object. MMIO driver for instance > already utilizes that design pattern. Reviewed-by: Andy Shevchenko > > Signed-off-by: Serge Semin > Cc: Georgy Vlasov > Cc: Ramil Zaripov > Cc: Alexey Malahov > Cc: Thomas Bogendoerfer > Cc: Paul Burton > Cc: Ralf Baechle > Cc: Allison Randal > Cc: Andy Shevchenko > Cc: Gareth Williams > Cc: Arnd Bergmann > Cc: Rob Herring > Cc: linux-mips@vger.kernel.org > Cc: devicetree@vger.kernel.org > > --- > > Changelog v2: > - It's a new patch created as a result of more thorough driver study. > --- > drivers/spi/spi-dw.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/spi/spi-dw.h b/drivers/spi/spi-dw.h > index 60e9e430ce7b..b6ab81e0c747 100644 > --- a/drivers/spi/spi-dw.h > +++ b/drivers/spi/spi-dw.h > @@ -147,8 +147,6 @@ struct dw_spi { > dma_addr_t dma_addr; /* phy address of the Data register */ > const struct dw_spi_dma_ops *dma_ops; > > - /* Bus interface info */ > - void *priv; > #ifdef CONFIG_DEBUG_FS > struct dentry *debugfs; > #endif > -- > 2.25.1 > -- With Best Regards, Andy Shevchenko