From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8682CC433E1 for ; Fri, 15 May 2020 19:53:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5ACF820727 for ; Fri, 15 May 2020 19:53:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="WOdBZxkO" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726661AbgEOTxx (ORCPT ); Fri, 15 May 2020 15:53:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57476 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726226AbgEOTxx (ORCPT ); Fri, 15 May 2020 15:53:53 -0400 Received: from mail-pg1-x543.google.com (mail-pg1-x543.google.com [IPv6:2607:f8b0:4864:20::543]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6E31DC061A0C for ; Fri, 15 May 2020 12:53:52 -0700 (PDT) Received: by mail-pg1-x543.google.com with SMTP id b8so1477180pgi.11 for ; Fri, 15 May 2020 12:53:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=5qtf7blhXztbp1/La11Bf9xlOpWMwbs2y8ergkt/b1Y=; b=WOdBZxkO9ZlChGU9oTzTvFnzf5mUvWnxclG7T4JezJMXnEFbeWIBYnzv0c5jwu2xR9 Ua3N7q+nFby1Wl8Ij1gOb/0WxV2Lt/MvTh2s4lrob2lxAcR9KO41fQ13sdSZlN1Y3XVh OTL4s6x9aG0YSd9i9ndrZNnBrE8K6mg0Mxnms= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=5qtf7blhXztbp1/La11Bf9xlOpWMwbs2y8ergkt/b1Y=; b=ZZSeaerUe91UmH6vK1PEhZZD68yHV+NEvqMVYmI68hCL1ErCO9R6l+K8NX10QnkS+V FjZyC0yo7/9XK2fCu22xq1RFZgr8KAv+0cU8WOUN/riDDjlPuWi4fUP/wTujkNznQo67 /gkLEfA+bQZhuzPhjLoxdcCZChDG0h0mhLmnmDH1CcaYOe3lnMfqihdS+6nuCsSCUpGu reC2i5ufwePG5+8eObbCAk+vM+zz+qDXeVfNsC4i0n5LRCe5DFV6nxbjBNFlGzQIdhKG Rm8LKd605JEsrUS/9fuDur4z5KD/Kg80hr4xxkwOSADUxnEoAOiyLPIAabp9tV0ukLeG gIjw== X-Gm-Message-State: AOAM533zJpCZCkQ+GHQpMYfBOZozKCo7NFK2q+BgNrC1A6wQFmZ6r12H Lw8owvX0fEXJ+nPGyJ4bn8tYYQ== X-Google-Smtp-Source: ABdhPJwUJ8/mvnjZpuvFRvd7Z7fsk0iW3ySHXxxVPnmOTQBwN+vIWkdIBNf95F25TgFzeLZ3qRQIkg== X-Received: by 2002:aa7:9a4c:: with SMTP id x12mr5517509pfj.263.1589572432046; Fri, 15 May 2020 12:53:52 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id h13sm2560838pfk.86.2020.05.15.12.53.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 May 2020 12:53:51 -0700 (PDT) Date: Fri, 15 May 2020 12:53:50 -0700 From: Kees Cook To: Pavel Tatashin Cc: Petr Mladek , Anton Vorontsov , Colin Cross , Tony Luck , Jonathan Corbet , Benson Leung , Rob Herring , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Enric Balletbo i Serra , Sergey Senozhatsky , Steven Rostedt , Linux Doc Mailing List , LKML , devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH v4 5/6] pstore/ram: Introduce max_reason and convert dump_oops Message-ID: <202005151253.AF4AC00@keescook> References: <20200515184434.8470-1-keescook@chromium.org> <20200515184434.8470-6-keescook@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 15, 2020 at 03:40:14PM -0400, Pavel Tatashin wrote: > pdata.dump_oops = dump_oops; > > + /* If "max_reason" is set, its value has priority over "dump_oops". */ > > + if (ramoops_max_reason != -1) > > + pdata.max_reason = ramoops_max_reason; > > (ramoops_max_reason >= 0) might make more sense here, we do not want > negative max_reason even if it was provided by the user. Yeah, that's a good point. I'll tweak that. Thanks! -- Kees Cook From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4433CC433E0 for ; Fri, 15 May 2020 19:55:43 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E1E1920727 for ; Fri, 15 May 2020 19:55:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="WOdBZxkO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E1E1920727 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 49Nzfh4420zDr7J for ; Sat, 16 May 2020 05:55:40 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=chromium.org (client-ip=2607:f8b0:4864:20::442; helo=mail-pf1-x442.google.com; envelope-from=keescook@chromium.org; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=WOdBZxkO; dkim-atps=neutral Received: from mail-pf1-x442.google.com (mail-pf1-x442.google.com [IPv6:2607:f8b0:4864:20::442]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 49Nzch578ZzDr42 for ; Sat, 16 May 2020 05:53:53 +1000 (AEST) Received: by mail-pf1-x442.google.com with SMTP id 145so1468173pfw.13 for ; Fri, 15 May 2020 12:53:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=5qtf7blhXztbp1/La11Bf9xlOpWMwbs2y8ergkt/b1Y=; b=WOdBZxkO9ZlChGU9oTzTvFnzf5mUvWnxclG7T4JezJMXnEFbeWIBYnzv0c5jwu2xR9 Ua3N7q+nFby1Wl8Ij1gOb/0WxV2Lt/MvTh2s4lrob2lxAcR9KO41fQ13sdSZlN1Y3XVh OTL4s6x9aG0YSd9i9ndrZNnBrE8K6mg0Mxnms= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=5qtf7blhXztbp1/La11Bf9xlOpWMwbs2y8ergkt/b1Y=; b=XtzV9uUjWQwAtEeiq4SAYm6Jo27mvHETRP447H4lS536x0jGfzzRNZeyfw0dP+Yyty ShbXuGJ2fg03LQviVsgr+QvK2dTapZkMlG+dU+eCnUD2fKU0TwHUYN2d4+wMwoisodSQ 8rvxhcCPoygwddF/p1jIxGA6Imxflwrs8xhd9I9RJl7drlvSxU2jRCgAxracgsXhX4L1 nh+s8DZIoI+V5MHhzOIgIvk2Cdkg8HvxPLcowf3Ne0psoWwyJhOpOu0bkeD3n0CbxYQ9 s3maJ75f5Eg+NzQiCD4qc2Dj2FPT4DGwA87RP1J8rLURz6hplyJwbBba4jne32l0WiUr p8vA== X-Gm-Message-State: AOAM531M9FWqFFP167xJvyF90tLVmoI/TXmQSV9ZaKaX2/WebpihuQMQ ahs4i1SFcLZbmz00lDorjgH6bw== X-Google-Smtp-Source: ABdhPJwUJ8/mvnjZpuvFRvd7Z7fsk0iW3ySHXxxVPnmOTQBwN+vIWkdIBNf95F25TgFzeLZ3qRQIkg== X-Received: by 2002:aa7:9a4c:: with SMTP id x12mr5517509pfj.263.1589572432046; Fri, 15 May 2020 12:53:52 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id h13sm2560838pfk.86.2020.05.15.12.53.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 May 2020 12:53:51 -0700 (PDT) Date: Fri, 15 May 2020 12:53:50 -0700 From: Kees Cook To: Pavel Tatashin Subject: Re: [PATCH v4 5/6] pstore/ram: Introduce max_reason and convert dump_oops Message-ID: <202005151253.AF4AC00@keescook> References: <20200515184434.8470-1-keescook@chromium.org> <20200515184434.8470-6-keescook@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Petr Mladek , Tony Luck , Jonathan Corbet , Anton Vorontsov , Linux Doc Mailing List , LKML , Steven Rostedt , Sergey Senozhatsky , devicetree@vger.kernel.org, Rob Herring , Paul Mackerras , Colin Cross , Enric Balletbo i Serra , linuxppc-dev@lists.ozlabs.org, Benson Leung Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Fri, May 15, 2020 at 03:40:14PM -0400, Pavel Tatashin wrote: > pdata.dump_oops = dump_oops; > > + /* If "max_reason" is set, its value has priority over "dump_oops". */ > > + if (ramoops_max_reason != -1) > > + pdata.max_reason = ramoops_max_reason; > > (ramoops_max_reason >= 0) might make more sense here, we do not want > negative max_reason even if it was provided by the user. Yeah, that's a good point. I'll tweak that. Thanks! -- Kees Cook