From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7606C433E0 for ; Fri, 15 May 2020 12:58:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C7D202074D for ; Fri, 15 May 2020 12:58:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726241AbgEOM6V (ORCPT ); Fri, 15 May 2020 08:58:21 -0400 Received: from foss.arm.com ([217.140.110.172]:55652 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726162AbgEOM6U (ORCPT ); Fri, 15 May 2020 08:58:20 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id EF37E1042; Fri, 15 May 2020 05:58:19 -0700 (PDT) Received: from bogus (unknown [10.37.12.6]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5DF3B3F305; Fri, 15 May 2020 05:58:10 -0700 (PDT) Date: Fri, 15 May 2020 13:57:58 +0100 From: Sudeep Holla To: Mark Rutland Cc: linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Lorenzo Pieralisi , Sudeep Holla , Steven Price , linux-kernel@vger.kernel.org, Arnd Bergmann , harb@amperecomputing.com Subject: Re: [PATCH v3 6/7] firmware: smccc: Add function to fetch SMCCC version Message-ID: <20200515125758.GC1591@bogus> References: <20200506164411.3284-1-sudeep.holla@arm.com> <20200506164411.3284-7-sudeep.holla@arm.com> <20200515120811.GF67718@C02TD0UTHF1T.local> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200515120811.GF67718@C02TD0UTHF1T.local> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 15, 2020 at 01:08:11PM +0100, Mark Rutland wrote: > On Wed, May 06, 2020 at 05:44:10PM +0100, Sudeep Holla wrote: > > For backward compatibility reasons, PSCI maintains SMCCC version as > > SMCCC didn't provide ARM_SMCCC_VERSION_FUNC_ID until v1.1 > > > > Let us provide accessors to fetch the SMCCC version in PSCI so that > > other SMCCC v1.1+ features can use it. > > Stale commit message? This was factored out of PSCI in the prior commit. > Duh ! Will drop that. > > Reviewed-by: Steven Price > > Signed-off-by: Sudeep Holla > > --- > > drivers/firmware/smccc/smccc.c | 4 ++++ > > include/linux/arm-smccc.h | 9 +++++++++ > > 2 files changed, 13 insertions(+) > > > > diff --git a/drivers/firmware/smccc/smccc.c b/drivers/firmware/smccc/smccc.c > > index 488699aae24f..672974df0dfe 100644 > > --- a/drivers/firmware/smccc/smccc.c > > +++ b/drivers/firmware/smccc/smccc.c > > @@ -24,3 +24,7 @@ enum arm_smccc_conduit arm_smccc_1_1_get_conduit(void) > > return smccc_conduit; > > } > > > > +u32 arm_smccc_version_get(void) > > +{ > > + return smccc_version; > > +} > > Could we please call this arm_smccc_get_version(), to align with the > existing arm_smccc_1_1_get_conduit()? > Right will fix that. (I may suddenly got into SCMI mode where Greg or someone asked me change all the function names to have verb at the end 😁) > > diff --git a/include/linux/arm-smccc.h b/include/linux/arm-smccc.h > > index 11fb20bfa8f7..8dd54dad1ec5 100644 > > --- a/include/linux/arm-smccc.h > > +++ b/include/linux/arm-smccc.h > > @@ -109,6 +109,15 @@ void __init arm_smccc_version_init(u32 version, enum arm_smccc_conduit conduit); > > */ > > enum arm_smccc_conduit arm_smccc_1_1_get_conduit(void); > > > > +/** > > + * arm_smccc_version_get() > > + * > > + * Returns the version to be used for SMCCCv1.1 or later. > > + * > > + * When SMCCCv1.1 or above is not present, assumes and returns SMCCCv1.0. > > + */ > > +u32 arm_smccc_version_get(void); > > Can we please reword the last line to something like: > > | When SMCCCv1.1 or above is not present, returns SMCCCv1.0, but this > | does not imply the presence of firmware or a valid conduit. Callers > | handling SMCCCv1.0 must determine the conduit by other means. > Sure > With all that: > > Acked-by: Mark Rutland > Thanks, -- Regards, Sudeep From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 818FCC433E0 for ; Fri, 15 May 2020 12:58:24 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4FD902074D for ; Fri, 15 May 2020 12:58:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="q9+rLOiE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4FD902074D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lKGF0WVbwmL7cBn2hc0RBcJ31Uaq4Eu3vAKwvT8lCck=; b=q9+rLOiEcGjbLi GMAQfLrt1nGTfR5BQvSm0I8uSmoJ6pZnCK7vCI7e6sVNliTHrImN6f6KWAcUJ+LLhMY/3WzPtAb1z +scPvvqPd6aKLYaVJf9y9cNe/KO5QVCiJNztcgfeyxOmrSVj1LsQXuwcIBQkuwcaCC6uxXOBUWvKH tUY0d9u4z3saKA9bEiRKYWL963GEnZyWA1swJ41btGqVTikah1m1yFp/fXM+ee/J35Lpc6BmLSkdC FC4z6ooevotNVQhR4xm9ZEBsXnHwPVQiOejYd5lUy6XMW1pZrupT4m/u+xixcQKwgs7/gVp4Iq5KG a8yF98HALKWl7p7DCrnA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jZZuy-0006lZ-10; Fri, 15 May 2020 12:58:24 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jZZuu-0006l9-H9 for linux-arm-kernel@lists.infradead.org; Fri, 15 May 2020 12:58:21 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id EF37E1042; Fri, 15 May 2020 05:58:19 -0700 (PDT) Received: from bogus (unknown [10.37.12.6]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5DF3B3F305; Fri, 15 May 2020 05:58:10 -0700 (PDT) Date: Fri, 15 May 2020 13:57:58 +0100 From: Sudeep Holla To: Mark Rutland Subject: Re: [PATCH v3 6/7] firmware: smccc: Add function to fetch SMCCC version Message-ID: <20200515125758.GC1591@bogus> References: <20200506164411.3284-1-sudeep.holla@arm.com> <20200506164411.3284-7-sudeep.holla@arm.com> <20200515120811.GF67718@C02TD0UTHF1T.local> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200515120811.GF67718@C02TD0UTHF1T.local> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200515_055820_611454_A926BA86 X-CRM114-Status: GOOD ( 18.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lorenzo Pieralisi , Arnd Bergmann , Catalin Marinas , linux-kernel@vger.kernel.org, Steven Price , harb@amperecomputing.com, Sudeep Holla , Will Deacon , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gRnJpLCBNYXkgMTUsIDIwMjAgYXQgMDE6MDg6MTFQTSArMDEwMCwgTWFyayBSdXRsYW5kIHdy b3RlOgo+IE9uIFdlZCwgTWF5IDA2LCAyMDIwIGF0IDA1OjQ0OjEwUE0gKzAxMDAsIFN1ZGVlcCBI b2xsYSB3cm90ZToKPiA+IEZvciBiYWNrd2FyZCBjb21wYXRpYmlsaXR5IHJlYXNvbnMsIFBTQ0kg bWFpbnRhaW5zIFNNQ0NDIHZlcnNpb24gYXMKPiA+IFNNQ0NDIGRpZG4ndCBwcm92aWRlIEFSTV9T TUNDQ19WRVJTSU9OX0ZVTkNfSUQgdW50aWwgdjEuMQo+ID4gCj4gPiBMZXQgdXMgcHJvdmlkZSBh Y2Nlc3NvcnMgdG8gZmV0Y2ggdGhlIFNNQ0NDIHZlcnNpb24gaW4gUFNDSSBzbyB0aGF0Cj4gPiBv dGhlciBTTUNDQyB2MS4xKyBmZWF0dXJlcyBjYW4gdXNlIGl0Lgo+IAo+IFN0YWxlIGNvbW1pdCBt ZXNzYWdlPyBUaGlzIHdhcyBmYWN0b3JlZCBvdXQgb2YgUFNDSSBpbiB0aGUgcHJpb3IgY29tbWl0 Lgo+CgpEdWggISBXaWxsIGRyb3AgdGhhdC4KCj4gPiBSZXZpZXdlZC1ieTogU3RldmVuIFByaWNl IDxzdGV2ZW4ucHJpY2VAYXJtLmNvbT4KPiA+IFNpZ25lZC1vZmYtYnk6IFN1ZGVlcCBIb2xsYSA8 c3VkZWVwLmhvbGxhQGFybS5jb20+Cj4gPiAtLS0KPiA+ICBkcml2ZXJzL2Zpcm13YXJlL3NtY2Nj L3NtY2NjLmMgfCA0ICsrKysKPiA+ICBpbmNsdWRlL2xpbnV4L2FybS1zbWNjYy5oICAgICAgfCA5 ICsrKysrKysrKwo+ID4gIDIgZmlsZXMgY2hhbmdlZCwgMTMgaW5zZXJ0aW9ucygrKQo+ID4gCj4g PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9maXJtd2FyZS9zbWNjYy9zbWNjYy5jIGIvZHJpdmVycy9m aXJtd2FyZS9zbWNjYy9zbWNjYy5jCj4gPiBpbmRleCA0ODg2OTlhYWUyNGYuLjY3Mjk3NGRmMGRm ZSAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZmlybXdhcmUvc21jY2Mvc21jY2MuYwo+ID4gKysr IGIvZHJpdmVycy9maXJtd2FyZS9zbWNjYy9zbWNjYy5jCj4gPiBAQCAtMjQsMyArMjQsNyBAQCBl bnVtIGFybV9zbWNjY19jb25kdWl0IGFybV9zbWNjY18xXzFfZ2V0X2NvbmR1aXQodm9pZCkKPiA+ ICAJcmV0dXJuIHNtY2NjX2NvbmR1aXQ7Cj4gPiAgfQo+ID4gIAo+ID4gK3UzMiBhcm1fc21jY2Nf dmVyc2lvbl9nZXQodm9pZCkKPiA+ICt7Cj4gPiArCXJldHVybiBzbWNjY192ZXJzaW9uOwo+ID4g K30KPiAKPiBDb3VsZCB3ZSBwbGVhc2UgY2FsbCB0aGlzIGFybV9zbWNjY19nZXRfdmVyc2lvbigp LCB0byBhbGlnbiB3aXRoIHRoZQo+IGV4aXN0aW5nIGFybV9zbWNjY18xXzFfZ2V0X2NvbmR1aXQo KT8KPgoKUmlnaHQgd2lsbCBmaXggdGhhdC4gKEkgbWF5IHN1ZGRlbmx5IGdvdCBpbnRvIFNDTUkg bW9kZSB3aGVyZSBHcmVnIG9yCnNvbWVvbmUgYXNrZWQgbWUgY2hhbmdlIGFsbCB0aGUgZnVuY3Rp b24gbmFtZXMgdG8gaGF2ZSB2ZXJiIGF0IHRoZSBlbmQg8J+YgSkKCj4gPiBkaWZmIC0tZ2l0IGEv aW5jbHVkZS9saW51eC9hcm0tc21jY2MuaCBiL2luY2x1ZGUvbGludXgvYXJtLXNtY2NjLmgKPiA+ IGluZGV4IDExZmIyMGJmYThmNy4uOGRkNTRkYWQxZWM1IDEwMDY0NAo+ID4gLS0tIGEvaW5jbHVk ZS9saW51eC9hcm0tc21jY2MuaAo+ID4gKysrIGIvaW5jbHVkZS9saW51eC9hcm0tc21jY2MuaAo+ ID4gQEAgLTEwOSw2ICsxMDksMTUgQEAgdm9pZCBfX2luaXQgYXJtX3NtY2NjX3ZlcnNpb25faW5p dCh1MzIgdmVyc2lvbiwgZW51bSBhcm1fc21jY2NfY29uZHVpdCBjb25kdWl0KTsKPiA+ICAgKi8K PiA+ICBlbnVtIGFybV9zbWNjY19jb25kdWl0IGFybV9zbWNjY18xXzFfZ2V0X2NvbmR1aXQodm9p ZCk7Cj4gPiAgCj4gPiArLyoqCj4gPiArICogYXJtX3NtY2NjX3ZlcnNpb25fZ2V0KCkKPiA+ICsg Kgo+ID4gKyAqIFJldHVybnMgdGhlIHZlcnNpb24gdG8gYmUgdXNlZCBmb3IgU01DQ0N2MS4xIG9y IGxhdGVyLgo+ID4gKyAqCj4gPiArICogV2hlbiBTTUNDQ3YxLjEgb3IgYWJvdmUgaXMgbm90IHBy ZXNlbnQsIGFzc3VtZXMgYW5kIHJldHVybnMgU01DQ0N2MS4wLgo+ID4gKyAqLwo+ID4gK3UzMiBh cm1fc21jY2NfdmVyc2lvbl9nZXQodm9pZCk7Cj4gCj4gQ2FuIHdlIHBsZWFzZSByZXdvcmQgdGhl IGxhc3QgbGluZSB0byBzb21ldGhpbmcgbGlrZToKPgo+IHwgV2hlbiBTTUNDQ3YxLjEgb3IgYWJv dmUgaXMgbm90IHByZXNlbnQsIHJldHVybnMgU01DQ0N2MS4wLCBidXQgdGhpcwo+IHwgZG9lcyBu b3QgaW1wbHkgdGhlIHByZXNlbmNlIG9mIGZpcm13YXJlIG9yIGEgdmFsaWQgY29uZHVpdC4gQ2Fs bGVycwo+IHwgaGFuZGxpbmcgU01DQ0N2MS4wIG11c3QgZGV0ZXJtaW5lIHRoZSBjb25kdWl0IGJ5 IG90aGVyIG1lYW5zLgo+CgpTdXJlCgo+IFdpdGggYWxsIHRoYXQ6Cj4gCj4gQWNrZWQtYnk6IE1h cmsgUnV0bGFuZCA8bWFyay5ydXRsYW5kQGFybS5jb20+Cj4gCgpUaGFua3MsCgotLSAKUmVnYXJk cywKU3VkZWVwCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmlu ZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9s aW51eC1hcm0ta2VybmVsCg==