From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2961C433DF for ; Fri, 15 May 2020 15:02:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9F37D207BB for ; Fri, 15 May 2020 15:02:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726703AbgEOPC4 (ORCPT ); Fri, 15 May 2020 11:02:56 -0400 Received: from mga01.intel.com ([192.55.52.88]:37779 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726144AbgEOPCz (ORCPT ); Fri, 15 May 2020 11:02:55 -0400 IronPort-SDR: u+rA+49iOEPwsbt5dbBxeyPlKRnijZBiXeGfVBdKT/40l157xFP6U+clmRKIuvzI5NgskqgZ3A MG7Yq/MwXv0Q== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 May 2020 08:02:55 -0700 IronPort-SDR: pPF5tDZcqhcLLPzgTY2JMxf40nbuiZdzldG4JbZkozpoJFkWqLEGENyw6lvT2Up2dOxF0YS3Wh d8P87UJjILpA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,395,1583222400"; d="scan'208";a="464752447" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga005.fm.intel.com with ESMTP; 15 May 2020 08:02:50 -0700 Received: from andy by smile with local (Exim 4.93) (envelope-from ) id 1jZbrQ-006tS4-AY; Fri, 15 May 2020 18:02:52 +0300 Date: Fri, 15 May 2020 18:02:52 +0300 From: Andy Shevchenko To: Serge Semin Cc: Mark Brown , Serge Semin , Georgy Vlasov , Ramil Zaripov , Alexey Malahov , Thomas Bogendoerfer , Paul Burton , Ralf Baechle , Rob Herring , Arnd Bergmann , Allison Randal , Gareth Williams , linux-mips@vger.kernel.org, devicetree@vger.kernel.org, John Garry , Chuanhong Guo , Gregory CLEMENT , Chris Packham , Masahisa Kojima , Tomer Maimon , Krzysztof Kozlowski , linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 14/19] spi: dw: Remove DW DMA code dependency from DW_DMAC_PCI Message-ID: <20200515150252.GL1634618@smile.fi.intel.com> References: <20200508132943.9826-1-Sergey.Semin@baikalelectronics.ru> <20200515104758.6934-1-Sergey.Semin@baikalelectronics.ru> <20200515104758.6934-15-Sergey.Semin@baikalelectronics.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200515104758.6934-15-Sergey.Semin@baikalelectronics.ru> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 15, 2020 at 01:47:53PM +0300, Serge Semin wrote: > Since there is a generic method available to initialize the DW SPI DMA > interface on any DT and ACPI-based platforms, which in general can be > designed with not only DW DMAC but with any DMA engine on board, we can > freely remove the CONFIG_DW_DMAC_PCI config from dependency list of > CONFIG_SPI_DW_DMA. Especially seeing that we don't use anything DW DMAC > specific in the new driver. Right, and used data structures are always available at compile time. Reviewed-by: Andy Shevchenko > Co-developed-by: Georgy Vlasov > Signed-off-by: Georgy Vlasov > Co-developed-by: Ramil Zaripov > Signed-off-by: Ramil Zaripov > Signed-off-by: Serge Semin > Cc: Alexey Malahov > Cc: Thomas Bogendoerfer > Cc: Paul Burton > Cc: Ralf Baechle > Cc: Rob Herring > Cc: Arnd Bergmann > Cc: Allison Randal > Cc: Andy Shevchenko > Cc: Gareth Williams > Cc: linux-mips@vger.kernel.org > Cc: devicetree@vger.kernel.org > --- > drivers/spi/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig > index 03b061975f70..6a84f3dad35c 100644 > --- a/drivers/spi/Kconfig > +++ b/drivers/spi/Kconfig > @@ -228,7 +228,7 @@ config SPI_DESIGNWARE > > config SPI_DW_DMA > bool "DMA support for DW SPI controller" > - depends on SPI_DESIGNWARE && DW_DMAC_PCI > + depends on SPI_DESIGNWARE > > config SPI_DW_PCI > tristate "PCI interface driver for DW SPI core" > -- > 2.25.1 > -- With Best Regards, Andy Shevchenko