From: Benjamin Marzinski <bmarzins@redhat.com>
To: Christophe Varoqui <christophe.varoqui@opensvc.com>
Cc: device-mapper development <dm-devel@redhat.com>,
Martin Wilck <Martin.Wilck@suse.com>
Subject: Re: [PATCH 0/6] multipath: path validation library prep work
Date: Fri, 15 May 2020 11:17:06 -0500 [thread overview]
Message-ID: <20200515161706.GV5907@octiron.msp.redhat.com> (raw)
In-Reply-To: <1589507962-6895-1-git-send-email-bmarzins@redhat.com>
On Thu, May 14, 2020 at 08:59:16PM -0500, Benjamin Marzinski wrote:
> I've been playing around with the SID code more and I've decided to hold
> off on submitting the library until I have it working with the SID
> multipath module better. Instead, I've pulled out the common code that
> multipath -u/-c and the library can use, and put it into libmultipath.
>
> I've also removed some of the ordering differences between the existing
> code and my new code. Right now, the only difference is that if a path
> is currently multipathed, it will always be claimed as a valid path.
>
> Patches 0001 & 0002 are the same as in my "RFC PATCH v2" set, and patch
> 0005 is the same as my "libmultipath: simplify failed wwid code" patch.
>
> Only patches 0003 and 0004 haven't been posted before.
>
Just a note on applying this. This patch set is meant to be applied on
top of Martin's recent patchsets.
-Ben
> Benjamin Marzinski (5):
> libmultipath: make libmp_dm_init optional
> libmultipath: make sysfs_is_multipathed able to return wwid
> multipath: centralize validation code
> Unit tests for is_path_valid()
> libmultipath: simplify failed wwid code
>
> Martin Wilck (1):
> libmultipath: use atomic linkat() in mark_failed_wwid()
>
> libmultipath/Makefile | 2 +-
> libmultipath/devmapper.c | 66 +++++-
> libmultipath/devmapper.h | 4 +-
> libmultipath/structs.h | 24 +--
> libmultipath/sysfs.c | 24 ++-
> libmultipath/sysfs.h | 2 +-
> libmultipath/valid.c | 118 +++++++++++
> libmultipath/valid.h | 32 +++
> libmultipath/wwids.c | 165 ++++++++-------
> multipath/main.c | 295 ++++++++++++---------------
> tests/Makefile | 4 +-
> tests/valid.c | 424 +++++++++++++++++++++++++++++++++++++++
> 12 files changed, 875 insertions(+), 285 deletions(-)
> create mode 100644 libmultipath/valid.c
> create mode 100644 libmultipath/valid.h
> create mode 100644 tests/valid.c
>
> --
> 2.17.2
>
> --
> dm-devel mailing list
> dm-devel@redhat.com
> https://www.redhat.com/mailman/listinfo/dm-devel
prev parent reply other threads:[~2020-05-15 16:17 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-15 1:59 [PATCH 0/6] multipath: path validation library prep work Benjamin Marzinski
2020-05-15 1:59 ` [PATCH 1/6] libmultipath: make libmp_dm_init optional Benjamin Marzinski
2020-05-15 1:59 ` [PATCH 2/6] libmultipath: make sysfs_is_multipathed able to return wwid Benjamin Marzinski
2020-05-15 20:36 ` Martin Wilck
2020-05-15 1:59 ` [PATCH 3/6] multipath: centralize validation code Benjamin Marzinski
2020-05-15 20:37 ` Martin Wilck
2020-05-18 18:53 ` Benjamin Marzinski
2020-05-18 19:02 ` Martin Wilck
2020-05-15 1:59 ` [PATCH 4/6] Unit tests for is_path_valid() Benjamin Marzinski
2020-05-15 20:37 ` Martin Wilck
2020-05-16 11:51 ` Martin Wilck
2020-05-18 18:57 ` Benjamin Marzinski
2020-05-15 1:59 ` [PATCH 5/6] libmultipath: simplify failed wwid code Benjamin Marzinski
2020-05-15 20:38 ` Martin Wilck
2020-05-15 1:59 ` [PATCH 6/6] libmultipath: use atomic linkat() in mark_failed_wwid() Benjamin Marzinski
2020-05-15 16:17 ` Benjamin Marzinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200515161706.GV5907@octiron.msp.redhat.com \
--to=bmarzins@redhat.com \
--cc=Martin.Wilck@suse.com \
--cc=christophe.varoqui@opensvc.com \
--cc=dm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.