From: Eric Biggers <ebiggers@kernel.org>
To: linux-f2fs-devel@lists.sourceforge.net, Jaegeuk Kim <jaegeuk@kernel.org>
Subject: Re: [f2fs-dev] [PATCH] f2fs: don't return vmalloc() memory from f2fs_kmalloc()
Date: Fri, 15 May 2020 12:13:04 -0700 [thread overview]
Message-ID: <20200515191304.GB1009@sol.localdomain> (raw)
In-Reply-To: <20200505204823.211214-1-ebiggers@kernel.org>
On Tue, May 05, 2020 at 01:48:23PM -0700, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> kmalloc() returns kmalloc'ed memory, and kvmalloc() returns either
> kmalloc'ed or vmalloc'ed memory. But the f2fs wrappers, f2fs_kmalloc()
> and f2fs_kvmalloc(), both return both kinds of memory.
>
> It's redundant to have two functions that do the same thing, and also
> breaking the standard naming convention is causing bugs since people
> assume it's safe to kfree() memory allocated by f2fs_kmalloc(). See
> e.g. the various allocations in fs/f2fs/compress.c.
>
> Fix this by making f2fs_kmalloc() just use kmalloc(). And to avoid
> re-introducing the allocation failures that the vmalloc fallback was
> intended to fix, convert the largest allocations to use f2fs_kvmalloc().
>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
Jaegeuk, are you planning to apply this patch?
- Eric
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2020-05-15 19:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-05 20:48 [f2fs-dev] [PATCH] f2fs: don't return vmalloc() memory from f2fs_kmalloc() Eric Biggers
2020-05-06 7:43 ` Chao Yu
2020-05-06 18:43 ` Eric Biggers
2020-05-07 3:13 ` Chao Yu
2020-05-15 19:13 ` Eric Biggers [this message]
2020-05-18 18:06 ` Jaegeuk Kim
2020-05-18 18:35 ` Eric Biggers
2020-05-18 19:10 ` Jaegeuk Kim
2020-06-04 21:06 ` Eric Biggers
2020-06-05 1:15 ` Jaegeuk Kim
2020-06-05 4:56 ` Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200515191304.GB1009@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.