From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75BEBC433E0 for ; Fri, 15 May 2020 20:44:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3FEB020709 for ; Fri, 15 May 2020 20:44:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589575464; bh=N7sHR+WmOKrHS7sx3jSkXYhCK2mvTbDrj0hGOsattK8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=oKyMaCaGQgdkh+5VQAt4mRY84hmKWB/wEpJlbT31nvtDzIptwtTWUDljTPzXbHl3L ivsChPxgju63G0JAj+2s9Rk1MauGKv8rN/xJNJn+olJJo72bOTPVtubGlE0H+wYUyZ HzVFRPktKl/AuG2jqeNAB6NRjkFhWJKhr9H+9njs= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726245AbgEOUoX (ORCPT ); Fri, 15 May 2020 16:44:23 -0400 Received: from mail-pg1-f195.google.com ([209.85.215.195]:34302 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726183AbgEOUoX (ORCPT ); Fri, 15 May 2020 16:44:23 -0400 Received: by mail-pg1-f195.google.com with SMTP id f6so1556771pgm.1; Fri, 15 May 2020 13:44:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=31jlI11UdSuUne5CytA8aXHN1DKoQTYg2m0ehqqjq1w=; b=Nr+wW/S0YqcnjY3rjCXDlQrzv69mSln+17NZYJDLMkCwVVBL60VVJL9eMr6Fjr6FRe y1vMkFjtrFGZvpZYEa4V3B+VFXvBeYsjOW2yFXWIfCdbaw8qGUfXgEfA8JnEd77NpHkM K1exf67FVJxF5dISa4eBFkR92IPx3QOCu6wdB7WU5RtOb9BL2gYFfQ/2I/ChL48SUQ3u G2LvSldXyL79rsseNGTBQ7rylGTgVizsuMJ2MFwUO3d691/WAldvB4HSwfzwa9T3iPO2 zG6gdZZVIqOLNwHh3qh2ljcXbfk/ikpthkFBFGZEobrRlhhfFTdOM5Qc2nNrK74Ow5no boWw== X-Gm-Message-State: AOAM531L1yg6BCFa3ACHakiMnjYtZArjgDej+/Xw3filWH3cQxXlEKmD DlxfYWMHZ6LKoL7ZCdGelQBK/j14GqeJ1A== X-Google-Smtp-Source: ABdhPJw7XG8gdnNFvqQp/E+s55309E2Xi/QpwKoZegblz+akssDO8WQKCDIfy7AdJqwWny83PlCUZA== X-Received: by 2002:a62:e70b:: with SMTP id s11mr5672379pfh.32.1589575462477; Fri, 15 May 2020 13:44:22 -0700 (PDT) Received: from 42.do-not-panic.com (42.do-not-panic.com. [157.230.128.187]) by smtp.gmail.com with ESMTPSA id f6sm2707575pfd.175.2020.05.15.13.44.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 May 2020 13:44:21 -0700 (PDT) Received: by 42.do-not-panic.com (Postfix, from userid 1000) id B5A6B40246; Fri, 15 May 2020 20:44:20 +0000 (UTC) Date: Fri, 15 May 2020 20:44:20 +0000 From: Luis Chamberlain To: Scott Branden Cc: Greg Kroah-Hartman , David Brown , Alexander Viro , Shuah Khan , bjorn.andersson@linaro.org, Shuah Khan , Arnd Bergmann , "Rafael J . Wysocki" , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-fsdevel@vger.kernel.org, BCM Kernel Feedback , Olof Johansson , Andrew Morton , Dan Carpenter , Colin Ian King , Kees Cook , Takashi Iwai , linux-kselftest@vger.kernel.org, Andy Gross Subject: Re: [PATCH v5 2/7] firmware: add offset to request_firmware_into_buf Message-ID: <20200515204420.GB11244@42.do-not-panic.com> References: <20200508002739.19360-1-scott.branden@broadcom.com> <20200508002739.19360-3-scott.branden@broadcom.com> <20200513003301.GH11244@42.do-not-panic.com> <3919bb12-522d-11fd-302b-91dc0fcff363@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3919bb12-522d-11fd-302b-91dc0fcff363@broadcom.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Wed, May 13, 2020 at 11:35:06AM -0700, Scott Branden wrote: > On 2020-05-12 5:33 p.m., Luis Chamberlain wrote: > > On Thu, May 07, 2020 at 05:27:34PM -0700, Scott Branden wrote: > > flags? But its a single variable enum! > fw_opt is an existing enum which doesn't really act like an enum. > It is a series of BIT defines in an enum that are then OR'd together in the > (existing) code? Indeed, in retrospect that is odd, it should be a u32 then. Please feel free to fix. Luis