From: David Miller <davem@davemloft.net>
To: xulin.sun@windriver.com
Cc: alexandre.belloni@bootlin.com, UNGLinuxDriver@microchip.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
xulinsun@gmail.com
Subject: Re: [PATCH] net: mscc: ocelot: replace readx_poll_timeout with readx_poll_timeout_atomic
Date: Sat, 16 May 2020 13:53:36 -0700 (PDT) [thread overview]
Message-ID: <20200516.135336.2032300090729040507.davem@davemloft.net> (raw)
In-Reply-To: <20200515031813.30283-1-xulin.sun@windriver.com>
From: Xulin Sun <xulin.sun@windriver.com>
Date: Fri, 15 May 2020 11:18:13 +0800
> BUG: sleeping function called from invalid context at drivers/net/ethernet/mscc/ocelot.c:59
> in_atomic(): 1, irqs_disabled(): 0, pid: 3778, name: ifconfig
> INFO: lockdep is turned off.
> Preemption disabled at:
> [<ffff2b163c83b78c>] dev_set_rx_mode+0x24/0x40
> Hardware name: LS1028A RDB Board (DT)
> Call trace:
> dump_backtrace+0x0/0x140
> show_stack+0x24/0x30
> dump_stack+0xc4/0x10c
> ___might_sleep+0x194/0x230
> __might_sleep+0x58/0x90
> ocelot_mact_forget+0x74/0xf8
> ocelot_mc_unsync+0x2c/0x38
> __hw_addr_sync_dev+0x6c/0x130
> ocelot_set_rx_mode+0x8c/0xa0
Vladimir states that this call chain is not possible in mainline.
I'm not applying this.
next prev parent reply other threads:[~2020-05-16 20:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-15 3:18 [PATCH] net: mscc: ocelot: replace readx_poll_timeout with readx_poll_timeout_atomic Xulin Sun
2020-05-15 13:26 ` Andrew Lunn
2020-05-15 16:30 ` Vladimir Oltean
2020-05-16 20:53 ` David Miller [this message]
2020-05-16 22:51 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200516.135336.2032300090729040507.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=xulin.sun@windriver.com \
--cc=xulinsun@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.