From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BD83C433E0 for ; Sat, 16 May 2020 11:53:59 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 22E7920709 for ; Sat, 16 May 2020 11:53:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 22E7920709 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=tuxdriver.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 08F411D9A5; Sat, 16 May 2020 13:53:53 +0200 (CEST) Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58]) by dpdk.org (Postfix) with ESMTP id A4C351D9A0 for ; Sat, 16 May 2020 13:53:50 +0200 (CEST) Received: from 2606-a000-111b-4634-0000-0000-0000-1bf2.inf6.spectrum.com ([2606:a000:111b:4634::1bf2] helo=localhost) by smtp.tuxdriver.com with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1jZvNk-0003Ge-A6; Sat, 16 May 2020 07:53:39 -0400 Date: Sat, 16 May 2020 07:53:31 -0400 From: Neil Horman To: Ray Kinsella Cc: dev@dpdk.org, Ferruh Yigit , Thomas Monjalon , Luca Boccassi , David Marchand , Bruce Richardson , Ian Stokes , Eelco Chaudron , Andrzej Ostruszka , Kevin Traynor , John McNamara , Marko Kovacevic , Cristian Dumitrescu Message-ID: <20200516115331.GA449981@hmswarspite.think-freely.org> References: <20200513121149.2283385-1-ferruh.yigit@intel.com> <20200514161104.1546493-1-ferruh.yigit@intel.com> <1589554922-4549-1-git-send-email-mdr@ashroe.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1589554922-4549-1-git-send-email-mdr@ashroe.eu> Subject: Re: [dpdk-dev] [PATCH v6] abi: provide experimental alias of API for old apps X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, May 15, 2020 at 04:01:53PM +0100, Ray Kinsella wrote: > From: Ferruh Yigit > > On v20.02 some APIs matured and symbols moved from EXPERIMENTAL to > DPDK_20.0.1 block. > > This had the affect of breaking the applications that were using these > APIs on v19.11. Although there is no modification of the APIs and the > action is positive and matures the APIs, the affect can be negative to > applications. > > When a maintainer is promoting an API to become part of the next major > ABI version by removing the experimental tag. The maintainer may > choose to offer an alias to the experimental tag, to prevent these > breakages in future. > > The following changes are made to enabling aliasing: > > Updated to the abi policy and abi versioning documents. > > Created VERSION_SYMBOL_EXPERIMENTAL helper macro. > > Updated the 'check-symbols.sh' buildtool, which was complaining that the > symbol is in EXPERIMENTAL tag in .map file but it is not in the > .experimental section (__rte_experimental tag is missing). > Updated tool in a way it won't complain if the symbol in the > EXPERIMENTAL tag duplicated in some other block in .map file (versioned) > > Signed-off-by: Ferruh Yigit > Signed-off-by: Ray Kinsella > --- > > This patch depends on "doc: fix references to bind_default_symbol". > https://patches.dpdk.org/patch/69850/ > > Cc: Neil Horman > Cc: Thomas Monjalon > Cc: Luca Boccassi > Cc: David Marchand > Cc: Bruce Richardson > Cc: Ian Stokes > Cc: Eelco Chaudron > Cc: Andrzej Ostruszka > Cc: Ray Kinsella > CC: Kevin Traynor > > v2: > * Commit log updated > > v3: > * added suggested comment to VERSION_SYMBOL_EXPERIMENTAL macro > > v4: > * update script name in commit log, remove empty line > > v5: > * incorporate policy and version doc changes > * remove changes to librte_meter > > v6: > * clarified dependency chain includes "doc: fix references to bind_default_symbol". > > buildtools/check-symbols.sh | 3 +- > doc/guides/contributing/abi_policy.rst | 10 ++ > doc/guides/contributing/abi_versioning.rst | 158 ++++++++++++++++++++++- > lib/librte_eal/include/rte_function_versioning.h | 9 ++ > 4 files changed, 178 insertions(+), 2 deletions(-) > Acked-by: Neil Horman