From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B780C433E1 for ; Sat, 16 May 2020 17:21:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DA79C206D4 for ; Sat, 16 May 2020 17:21:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589649698; bh=E7aJfRYTPqnzUYF0jUB/Z7E0AkaqB7I5mvXPP1NvKLU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=qxG5DcQ5zpmNi+vcUTQzoXjjsT46M/DY07u8X/jwqew7LdfWtVGCddSQyKohDw4aw H+u6BYY/N+D0M/5Rws26SwNWY+Y41SkvCD2TQS0kaQUjdkG03iRF2sfJZ77jLdD32e uj3O2JVec3Vu2qRqn6Pk+ot16ZSpD57xZyILPrcM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726528AbgEPRVi (ORCPT ); Sat, 16 May 2020 13:21:38 -0400 Received: from mail.kernel.org ([198.145.29.99]:48550 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726257AbgEPRVi (ORCPT ); Sat, 16 May 2020 13:21:38 -0400 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 872FF2065C; Sat, 16 May 2020 17:21:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589649697; bh=E7aJfRYTPqnzUYF0jUB/Z7E0AkaqB7I5mvXPP1NvKLU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=NIjlWLwcVz+dtLu9dYyJRabC3U+b6Wao6I6WeWZ4h6B19HoMmDOEfPhW/Q8Oka7Z1 H4rKdHytyXZS4p2Eui+gZA1Acost9MUGJcPYelrKABTJN6ZEQUxJMnnujhSJR9ccA7 RO20EpEY2+gqaDMVnDsEn4bx+zLiU4TG9Yfb61aE= Date: Sat, 16 May 2020 18:21:32 +0100 From: Jonathan Cameron To: Alexandru Ardelean Cc: , , , , , , , , , , Subject: Re: [PATCH v2 5/8] iio: stm32-adc: pass iio device as arg for the interrupt handler Message-ID: <20200516182132.0d8ed09b@archlinux> In-Reply-To: <20200514131710.84201-6-alexandru.ardelean@analog.com> References: <20200514131710.84201-1-alexandru.ardelean@analog.com> <20200514131710.84201-6-alexandru.ardelean@analog.com> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 14 May 2020 16:17:07 +0300 Alexandru Ardelean wrote: > This changes the argument for the interrupt handler to be the IIO device > instead of the state-struct. > Since there will be some changes to how iio_priv_to_dev() is implemented, > it could be that the helper becomes a bit slower, as it will be hidden away > in the IIO core. > > The iio_priv() call will still be fast enough, as it will return a void > pointer from the public IIO device structure. So it's better to switch the > order. > > Signed-off-by: Alexandru Ardelean As with previous patch - looks good to me, but I'd like an stm32 Ack / review. thanks, Jonathan > --- > drivers/iio/adc/stm32-adc.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/iio/adc/stm32-adc.c b/drivers/iio/adc/stm32-adc.c > index 80c3f963527b..34885387fbdb 100644 > --- a/drivers/iio/adc/stm32-adc.c > +++ b/drivers/iio/adc/stm32-adc.c > @@ -1227,8 +1227,8 @@ static int stm32_adc_read_raw(struct iio_dev *indio_dev, > > static irqreturn_t stm32_adc_threaded_isr(int irq, void *data) > { > - struct stm32_adc *adc = data; > - struct iio_dev *indio_dev = iio_priv_to_dev(adc); > + struct iio_dev *indio_dev = data; > + struct stm32_adc *adc = iio_priv(indio_dev); > const struct stm32_adc_regspec *regs = adc->cfg->regs; > u32 status = stm32_adc_readl(adc, regs->isr_eoc.reg); > > @@ -1240,8 +1240,8 @@ static irqreturn_t stm32_adc_threaded_isr(int irq, void *data) > > static irqreturn_t stm32_adc_isr(int irq, void *data) > { > - struct stm32_adc *adc = data; > - struct iio_dev *indio_dev = iio_priv_to_dev(adc); > + struct iio_dev *indio_dev = data; > + struct stm32_adc *adc = iio_priv(indio_dev); > const struct stm32_adc_regspec *regs = adc->cfg->regs; > u32 status = stm32_adc_readl(adc, regs->isr_eoc.reg); > > @@ -1882,7 +1882,7 @@ static int stm32_adc_probe(struct platform_device *pdev) > > ret = devm_request_threaded_irq(&pdev->dev, adc->irq, stm32_adc_isr, > stm32_adc_threaded_isr, > - 0, pdev->name, adc); > + 0, pdev->name, indio_dev); > if (ret) { > dev_err(&pdev->dev, "failed to request IRQ\n"); > return ret; From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6778C433DF for ; Sat, 16 May 2020 17:21:42 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 77B86206D4 for ; Sat, 16 May 2020 17:21:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="kG+splXa"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="NIjlWLwc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 77B86206D4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0sv0tO1PZIwA7h5czd0hyGxcxwk11rX+7u5y2Mp484Q=; b=kG+splXaF+a1MU smk2cF99ufkfoDqU1pcnUHj+/GekIXgr9WYLsxIsm2Y1R50SrYkMvTEzvSfIWhI3G9xzkFfYsqhA+ 9B0sdJWH4y3bwrTHjPDKweAnkbFKV10GsGTsJCpVzO07+DdKh3ppEoeoVIs9BVdvdpfigqwvPdQcj WG4E6qVeC75nr8XUjWBmYGPJi5SUbOQYim4jY9Wjp7N2KTIMtS1eK1nvCYj08lWqkQkMAcfC9ObFd JERxXr6A3eFPnMAm8/TdbONNRqRF4wctDjquwJxyWXWRK4Ghca8uP0MW40dRSKJqMNaB2gTl1/5fT 5gQQGT/MN+NqWi4aYL2Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ja0VI-0007Ze-Vs; Sat, 16 May 2020 17:21:40 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ja0VF-0007ZF-Oy for linux-arm-kernel@lists.infradead.org; Sat, 16 May 2020 17:21:39 +0000 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 872FF2065C; Sat, 16 May 2020 17:21:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589649697; bh=E7aJfRYTPqnzUYF0jUB/Z7E0AkaqB7I5mvXPP1NvKLU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=NIjlWLwcVz+dtLu9dYyJRabC3U+b6Wao6I6WeWZ4h6B19HoMmDOEfPhW/Q8Oka7Z1 H4rKdHytyXZS4p2Eui+gZA1Acost9MUGJcPYelrKABTJN6ZEQUxJMnnujhSJR9ccA7 RO20EpEY2+gqaDMVnDsEn4bx+zLiU4TG9Yfb61aE= Date: Sat, 16 May 2020 18:21:32 +0100 From: Jonathan Cameron To: Alexandru Ardelean Subject: Re: [PATCH v2 5/8] iio: stm32-adc: pass iio device as arg for the interrupt handler Message-ID: <20200516182132.0d8ed09b@archlinux> In-Reply-To: <20200514131710.84201-6-alexandru.ardelean@analog.com> References: <20200514131710.84201-1-alexandru.ardelean@analog.com> <20200514131710.84201-6-alexandru.ardelean@analog.com> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200516_102137_823544_5BDE0D67 X-CRM114-Status: GOOD ( 19.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alexandre.belloni@bootlin.com, alexandre.torgue@st.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, ludovic.desroches@microchip.com, ak@it-klinger.de, mcoquelin.stm32@gmail.com, eugen.hristev@microchip.com, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 14 May 2020 16:17:07 +0300 Alexandru Ardelean wrote: > This changes the argument for the interrupt handler to be the IIO device > instead of the state-struct. > Since there will be some changes to how iio_priv_to_dev() is implemented, > it could be that the helper becomes a bit slower, as it will be hidden away > in the IIO core. > > The iio_priv() call will still be fast enough, as it will return a void > pointer from the public IIO device structure. So it's better to switch the > order. > > Signed-off-by: Alexandru Ardelean As with previous patch - looks good to me, but I'd like an stm32 Ack / review. thanks, Jonathan > --- > drivers/iio/adc/stm32-adc.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/iio/adc/stm32-adc.c b/drivers/iio/adc/stm32-adc.c > index 80c3f963527b..34885387fbdb 100644 > --- a/drivers/iio/adc/stm32-adc.c > +++ b/drivers/iio/adc/stm32-adc.c > @@ -1227,8 +1227,8 @@ static int stm32_adc_read_raw(struct iio_dev *indio_dev, > > static irqreturn_t stm32_adc_threaded_isr(int irq, void *data) > { > - struct stm32_adc *adc = data; > - struct iio_dev *indio_dev = iio_priv_to_dev(adc); > + struct iio_dev *indio_dev = data; > + struct stm32_adc *adc = iio_priv(indio_dev); > const struct stm32_adc_regspec *regs = adc->cfg->regs; > u32 status = stm32_adc_readl(adc, regs->isr_eoc.reg); > > @@ -1240,8 +1240,8 @@ static irqreturn_t stm32_adc_threaded_isr(int irq, void *data) > > static irqreturn_t stm32_adc_isr(int irq, void *data) > { > - struct stm32_adc *adc = data; > - struct iio_dev *indio_dev = iio_priv_to_dev(adc); > + struct iio_dev *indio_dev = data; > + struct stm32_adc *adc = iio_priv(indio_dev); > const struct stm32_adc_regspec *regs = adc->cfg->regs; > u32 status = stm32_adc_readl(adc, regs->isr_eoc.reg); > > @@ -1882,7 +1882,7 @@ static int stm32_adc_probe(struct platform_device *pdev) > > ret = devm_request_threaded_irq(&pdev->dev, adc->irq, stm32_adc_isr, > stm32_adc_threaded_isr, > - 0, pdev->name, adc); > + 0, pdev->name, indio_dev); > if (ret) { > dev_err(&pdev->dev, "failed to request IRQ\n"); > return ret; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel