From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 09/12] xfs: refactor xfs_inode_verify_forks
Date: Sun, 17 May 2020 09:58:10 +0200 [thread overview]
Message-ID: <20200517075810.GB30453@lst.de> (raw)
In-Reply-To: <20200516174927.GY6714@magnolia>
On Sat, May 16, 2020 at 10:49:27AM -0700, Darrick J. Wong wrote:
> > +int
> > +xfs_ifork_verify_local_data(
> > struct xfs_inode *ip)
> > {
> > + if (fa) {
> > + xfs_inode_verifier_error(ip, -EFSCORRUPTED, "data fork",
> > + ip->i_df.if_u1.if_data, ip->i_df.if_bytes, fa);
>
> Needs more indent, but I could fix this on merge...
Sure. It seems like that is the only outstanding comment on this series,
so maybe you should just pick it up and I shouldn't bother to resend it?
next prev parent reply other threads:[~2020-05-17 7:58 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-08 6:34 dinode reading cleanups v2 Christoph Hellwig
2020-05-08 6:34 ` [PATCH 01/12] xfs: xfs_bmapi_read doesn't take a fork id as the last argument Christoph Hellwig
2020-05-08 15:08 ` Darrick J. Wong
2020-05-08 6:34 ` [PATCH 02/12] xfs: call xfs_iformat_fork from xfs_inode_from_disk Christoph Hellwig
2020-05-16 0:19 ` Darrick J. Wong
2020-05-08 6:34 ` [PATCH 03/12] xfs: split xfs_iformat_fork Christoph Hellwig
2020-05-08 15:05 ` Brian Foster
2020-05-16 0:22 ` Darrick J. Wong
2020-05-08 6:34 ` [PATCH 04/12] xfs: handle unallocated inodes in xfs_inode_from_disk Christoph Hellwig
2020-05-08 15:05 ` Brian Foster
2020-05-16 17:38 ` Darrick J. Wong
2020-05-08 6:34 ` [PATCH 05/12] xfs: call xfs_dinode_verify from xfs_inode_from_disk Christoph Hellwig
2020-05-16 17:40 ` Darrick J. Wong
2020-05-08 6:34 ` [PATCH 06/12] xfs: don't reset i_delayed_blks in xfs_iread Christoph Hellwig
2020-05-16 17:41 ` Darrick J. Wong
2020-05-08 6:34 ` [PATCH 07/12] xfs: remove xfs_iread Christoph Hellwig
2020-05-16 17:43 ` Darrick J. Wong
2020-05-08 6:34 ` [PATCH 08/12] xfs: remove xfs_ifork_ops Christoph Hellwig
2020-05-08 15:05 ` Brian Foster
2020-05-09 8:17 ` Christoph Hellwig
2020-05-09 11:13 ` Brian Foster
2020-05-16 17:48 ` Darrick J. Wong
2020-05-18 13:35 ` Brian Foster
2020-05-18 16:07 ` Darrick J. Wong
2020-05-08 6:34 ` [PATCH 09/12] xfs: refactor xfs_inode_verify_forks Christoph Hellwig
2020-05-08 15:05 ` Brian Foster
2020-05-16 17:49 ` Darrick J. Wong
2020-05-17 7:58 ` Christoph Hellwig [this message]
2020-05-08 6:34 ` [PATCH 10/12] xfs: improve local fork verification Christoph Hellwig
2020-05-08 15:06 ` Brian Foster
2020-05-16 17:50 ` Darrick J. Wong
2020-05-08 6:34 ` [PATCH 11/12] xfs: remove the special COW fork handling in xfs_bmapi_read Christoph Hellwig
2020-05-16 17:52 ` Darrick J. Wong
2020-05-17 7:56 ` Christoph Hellwig
2020-05-08 6:34 ` [PATCH 12/12] xfs: remove the NULL " Christoph Hellwig
2020-05-08 15:06 ` Brian Foster
2020-05-16 17:52 ` Darrick J. Wong
2020-05-18 6:48 ` dinode reading cleanups v2 Christoph Hellwig
2020-05-18 17:36 ` Darrick J. Wong
2020-05-18 17:45 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2020-05-01 8:14 dinode reading cleanups Christoph Hellwig
2020-05-01 8:14 ` [PATCH 09/12] xfs: refactor xfs_inode_verify_forks Christoph Hellwig
2020-05-01 15:57 ` Brian Foster
2020-05-01 16:40 ` Christoph Hellwig
2020-05-01 17:02 ` Brian Foster
2020-05-01 17:08 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200517075810.GB30453@lst.de \
--to=hch@lst.de \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.