From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: Joshua Kinard <kumba@gentoo.org>
Cc: "Maciej W. Rozycki" <macro@wdc.com>,
linux-mips@vger.kernel.org,
"Maciej W. Rozycki" <macro@linux-mips.org>
Subject: Re: [PATCH v2] MIPS: Split R10000 to allow for R12K+ optimizations
Date: Sun, 17 May 2020 13:01:10 +0200 [thread overview]
Message-ID: <20200517110110.GC5508@alpha.franken.de> (raw)
In-Reply-To: <6db89a43-372b-ed92-af5d-9a95543554c2@gentoo.org>
On Sat, May 16, 2020 at 02:16:52AM -0400, Joshua Kinard wrote:
> Focusing on just one hunk for asm/mach-ip27/war.h, how does this look if I
> keep the conditional inside the block?
>
> diff --git a/arch/mips/include/asm/mach-ip27/war.h b/arch/mips/include/asm/mach-ip27/war.h
> index ef3efce0094a..f041e7357620 100644
> --- a/arch/mips/include/asm/mach-ip27/war.h
> +++ b/arch/mips/include/asm/mach-ip27/war.h
> @@ -17,7 +17,11 @@
> #define MIPS_CACHE_SYNC_WAR 0
> #define TX49XX_ICACHE_INDEX_INV_WAR 0
> #define ICACHE_REFILLS_WORKAROUND_WAR 0
> +#ifdef CONFIG_CPU_R10000
> #define R10000_LLSC_WAR 1
> +#else
> +#define R10000_LLSC_WAR 0
> +#endif
#define R10000_LLSC_WAR IS_ENABLED(CPU_R10000_WORKAROUNDS)
looks nice and clean ;-)
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
next prev parent reply other threads:[~2020-05-17 11:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-14 0:55 [PATCH v2] MIPS: Split R10000 to allow for R12K+ optimizations Joshua Kinard
2020-05-14 1:52 ` Maciej W. Rozycki
2020-05-14 3:34 ` Joshua Kinard
2020-05-14 21:42 ` Maciej W. Rozycki
2020-05-15 3:10 ` Joshua Kinard
2020-05-15 11:20 ` Maciej W. Rozycki
2020-05-16 6:16 ` Joshua Kinard
2020-05-17 11:01 ` Thomas Bogendoerfer [this message]
2020-05-17 10:59 ` Thomas Bogendoerfer
2020-05-17 12:42 ` Thomas Bogendoerfer
2020-05-17 18:42 ` Joshua Kinard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200517110110.GC5508@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=kumba@gentoo.org \
--cc=linux-mips@vger.kernel.org \
--cc=macro@linux-mips.org \
--cc=macro@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.