From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CF93C433E0 for ; Sun, 17 May 2020 19:09:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 764AA20709 for ; Sun, 17 May 2020 19:09:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726274AbgEQTJ3 (ORCPT ); Sun, 17 May 2020 15:09:29 -0400 Received: from smtpout1.mo528.mail-out.ovh.net ([46.105.34.251]:52875 "EHLO smtpout1.mo528.mail-out.ovh.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726269AbgEQTJ3 (ORCPT ); Sun, 17 May 2020 15:09:29 -0400 Received: from pro2.mail.ovh.net (unknown [10.109.156.173]) by mo528.mail-out.ovh.net (Postfix) with ESMTPS id 40D6B5E1A4CF; Sun, 17 May 2020 21:09:27 +0200 (CEST) Received: from localhost (34.99.246.4) by DAG2EX1.emp2.local (172.16.2.11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1847.3; Sun, 17 May 2020 21:09:26 +0200 Date: Sun, 17 May 2020 21:07:28 +0200 From: Tomasz Duszynski To: CC: , Jonathan Cameron , Lars-Peter Clausen , Tomasz Duszynski Subject: Re: [PATCH 10/11] iio:chemical:sps30: Fix timestamp alignment Message-ID: <20200517190728.GB18033@arch> References: <20200517173000.220819-1-jic23@kernel.org> <20200517173000.220819-11-jic23@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline In-Reply-To: <20200517173000.220819-11-jic23@kernel.org> X-Originating-IP: [34.99.246.4] X-ClientProxiedBy: DAG3EX2.emp2.local (172.16.2.22) To DAG2EX1.emp2.local (172.16.2.11) X-Ovh-Tracer-Id: 10081026291751214162 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduhedruddtfedgudefvdcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpeffhffvuffkfhggtggujghisehttdertddttdejnecuhfhrohhmpefvohhmrghsiicuffhushiihihnshhkihcuoehtohhmrghsiidrughushiihihnshhkihesohgtthgrkhhonhdrtghomheqnecuggftrfgrthhtvghrnheptdehveethfffudetjeeftdekueehjeegjedvteffgfevkefffeegffeugeehgfejnecukfhppedtrddtrddtrddtpdefgedrleelrddvgeeirdegnecuvehluhhsthgvrhfuihiivgepudenucfrrghrrghmpehmohguvgepshhmthhpqdhouhhtpdhhvghlohepphhrohdvrdhmrghilhdrohhvhhdrnhgvthdpihhnvghtpedtrddtrddtrddtpdhmrghilhhfrhhomhepthhomhgrshiirdguuhhsiiihnhhskhhisehotghtrghkohhnrdgtohhmpdhrtghpthhtohepthguuhhsiiihnhhssehgmhgrihhlrdgtohhm Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Sun, May 17, 2020 at 06:29:59PM +0100, jic23@kernel.org wrote: > From: Jonathan Cameron > > One of a class of bugs pointed out by Lars in a recent review. > iio_push_to_buffers_with_timestamp assumes the buffer used is aligned > to the size of the timestamp (8 bytes). This is not guaranteed in > this driver which uses an array of smaller elements on the stack. > > Fixes: 232e0f6ddeae ("iio: chemical: add support for Sensirion SPS30 sensor") > Reported-by: Lars-Peter Clausen > Signed-off-by: Jonathan Cameron > Cc: Tomasz Duszynski > --- > drivers/iio/chemical/sps30.c | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/drivers/iio/chemical/sps30.c b/drivers/iio/chemical/sps30.c > index acb9f8ecbb3d..a88c1fb875a0 100644 > --- a/drivers/iio/chemical/sps30.c > +++ b/drivers/iio/chemical/sps30.c > @@ -230,15 +230,18 @@ static irqreturn_t sps30_trigger_handler(int irq, void *p) > struct iio_dev *indio_dev = pf->indio_dev; > struct sps30_state *state = iio_priv(indio_dev); > int ret; > - s32 data[4 + 2]; /* PM1, PM2P5, PM4, PM10, timestamp */ > + struct { > + s32 data[4]; /* PM1, PM2P5, PM4, PM10 */ > + s64 ts; > + } scan; > > mutex_lock(&state->lock); > - ret = sps30_do_meas(state, data, 4); > + ret = sps30_do_meas(state, scan.data, ARRAY_SIZE(scan.data)); > mutex_unlock(&state->lock); > if (ret) > goto err; > > - iio_push_to_buffers_with_timestamp(indio_dev, data, > + iio_push_to_buffers_with_timestamp(indio_dev, &scan, > iio_get_time_ns(indio_dev)); > err: > iio_trigger_notify_done(indio_dev->trig); > -- > 2.26.2 > Thanks for the fix. Acked-by: Tomasz Duszynski