From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98C86C433DF for ; Mon, 18 May 2020 14:51:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 82FAC20674 for ; Mon, 18 May 2020 14:51:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728113AbgEROvT (ORCPT ); Mon, 18 May 2020 10:51:19 -0400 Received: from mail.baikalelectronics.com ([87.245.175.226]:48492 "EHLO mail.baikalelectronics.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726918AbgEROvS (ORCPT ); Mon, 18 May 2020 10:51:18 -0400 Received: from localhost (unknown [127.0.0.1]) by mail.baikalelectronics.ru (Postfix) with ESMTP id 127628030875; Mon, 18 May 2020 14:51:15 +0000 (UTC) X-Virus-Scanned: amavisd-new at baikalelectronics.ru Received: from mail.baikalelectronics.ru ([127.0.0.1]) by localhost (mail.baikalelectronics.ru [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id h93v5wIYCrJM; Mon, 18 May 2020 17:51:14 +0300 (MSK) Date: Mon, 18 May 2020 17:51:13 +0300 From: Serge Semin To: Thomas Gleixner , Jason Cooper , Marc Zyngier CC: Rob Herring , Ralf Baechle , Arnd Bergmann , , , Thomas Gleixner , Daniel Lezcano , , Marc Zyngier , Alexey Malahov , Alexandre Belloni , , Jason Cooper , Thomas Bogendoerfer , Alessandro Zummo , Paul Burton Subject: Re: [PATCH v3 3/7] dt-bindings: interrupt-controller: Convert mti,gic to DT schema Message-ID: <20200518145113.2ndiinqkjculiqmx@mobilestation> References: <20200324174325.14213-1-Sergey.Semin@baikalelectronics.ru> <20200506214107.25956-1-Sergey.Semin@baikalelectronics.ru> <20200506214107.25956-4-Sergey.Semin@baikalelectronics.ru> <20200514190632.GA9943@bogus> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20200514190632.GA9943@bogus> X-ClientProxiedBy: MAIL.baikal.int (192.168.51.25) To mail (192.168.51.25) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thomas, Jason, Marc Could you take a look at this patch and merge it in if you are ok with its content. We've got Rob's Reviewed-by tag here, so it's only waiting for your acceptance. -Sergey On Thu, May 14, 2020 at 02:06:32PM -0500, Rob Herring wrote: > On Thu, 7 May 2020 00:41:03 +0300, Serge Semin wrote: > > Modern device tree bindings are supposed to be created as YAML-files > > in accordance with DT schema. This commit replaces MIPS GIC legacy bare > > text binding with YAML file. As before the binding file states that the > > corresponding dts node is supposed to be compatible with MIPS Global > > Interrupt Controller indicated by the "mti,gic" compatible string and > > to provide a mandatory interrupt-controller and '#interrupt-cells' > > properties. There might be optional registers memory range, > > "mti,reserved-cpu-vectors" and "mti,reserved-ipi-vectors" properties > > specified. > > > > MIPS GIC also includes a free-running global timer, per-CPU count/compare > > timers, and a watchdog. Since currently the GIC Timer is only supported the > > DT schema expects an IRQ and clock-phandler charged timer sub-node with > > "mti,mips-gic-timer" compatible string. > > > > Signed-off-by: Serge Semin > > Cc: Alexey Malahov > > Cc: Thomas Bogendoerfer > > Cc: Paul Burton > > Cc: Ralf Baechle > > Cc: Alessandro Zummo > > Cc: Alexandre Belloni > > Cc: Daniel Lezcano > > Cc: Arnd Bergmann > > Cc: linux-mips@vger.kernel.org > > Cc: linux-rtc@vger.kernel.org > > > > --- > > > > I don't really know who is the corresponding driver maintainer, so I > > added Paul to the maintainers property since he used to be looking for the > > MIPS arch and Thomas looking after it now. Any idea what email should be > > specified there instead? > > > > Changelog v3: > > - Since timer sub-node has no unit-address, the node shouldn't be named > > with one. So alter the MIPS GIC bindings to have a pure "timer" > > sub-node. > > - Discard allOf: [ $ref: /schemas/interrupt-controller.yaml# ]. > > - Since it's a conversion patch use GPL-2.0-only SPDX header. > > --- > > .../interrupt-controller/mips-gic.txt | 67 -------- > > .../interrupt-controller/mti,gic.yaml | 148 ++++++++++++++++++ > > 2 files changed, 148 insertions(+), 67 deletions(-) > > delete mode 100644 Documentation/devicetree/bindings/interrupt-controller/mips-gic.txt > > create mode 100644 Documentation/devicetree/bindings/interrupt-controller/mti,gic.yaml > > > > Reviewed-by: Rob Herring