From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B31BC433DF for ; Mon, 18 May 2020 15:04:55 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 12F8220671 for ; Mon, 18 May 2020 15:04:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="DOn6vag4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 12F8220671 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=C2uS7gCgVIciHmr95BG/czwPNQWBVbRWZOT6MFAXuFk=; b=DOn6vag46WHqK2 8uwd0RuHpd9eO2PJmKtltt960941WPUFp4Ks0Y6mC2hgeqAKeXO5reLXCQzYNumPT5ilb/l1/tdA+ PM4X677p+J0SsAUrlKlOWLRMzu0vMRCKGm11QdTXX+gN4X2iHHIDXztmE5LGcl/FayDVHvY/qkNPb DWoxHVcKyN4G1lMNy9FQp9wmah2sj1uH3+OQholJFbgl/FHlluLpuja5m6Z4f5DTXWXR91vpEhTTF wIZKaWlIGavusA5KLmf6nDsRzMrzBz7UagbB2v6vd4wOFDbtP2Wku0bledJligTP4o6CLL5GChS/1 JrA4H3pD9Ngd8DKSZavw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jahK1-0006Fy-84; Mon, 18 May 2020 15:04:53 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jahJy-0006Fa-NF for linux-nvme@lists.infradead.org; Mon, 18 May 2020 15:04:52 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 816E668B02; Mon, 18 May 2020 17:04:45 +0200 (CEST) Date: Mon, 18 May 2020 17:04:45 +0200 From: Christoph Hellwig To: Chaitanya Kulkarni Subject: Re: [PATCH V3 1/3] nvmet: add helper to revalidate bdev and file ns Message-ID: <20200518150445.GA8871@lst.de> References: <20200518043034.48277-1-chaitanya.kulkarni@wdc.com> <20200518043034.48277-2-chaitanya.kulkarni@wdc.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200518043034.48277-2-chaitanya.kulkarni@wdc.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200518_080450_908168_B6E2443E X-CRM114-Status: UNSURE ( 6.82 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: hch@lst.de, linux-nvme@lists.infradead.org, sagi@grimberg.me Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org > +void nvmet_ns_revalidate(struct nvmet_ns *ns) > +{ > + loff_t old_size = ns->size; > + > + ns->bdev ? nvmet_bdev_ns_revalidate(ns) : nvmet_file_ns_revalidate(ns); Please use a good old if/else instead of this obsfucation. The rest looks good. > + > + if (old_size != ns->size) > + nvmet_ns_changed(ns->subsys, ns->nsid); Also this should probably go into a separate patch with proper documentation and not into one just saying it adds a helper. Otherwise this looks fine. _______________________________________________ linux-nvme mailing list linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme