From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E920FC433DF for ; Mon, 18 May 2020 15:09:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CE87C20671 for ; Mon, 18 May 2020 15:09:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728133AbgERPJH (ORCPT ); Mon, 18 May 2020 11:09:07 -0400 Received: from verein.lst.de ([213.95.11.211]:38896 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726918AbgERPJH (ORCPT ); Mon, 18 May 2020 11:09:07 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 27D5268B02; Mon, 18 May 2020 17:09:04 +0200 (CEST) Date: Mon, 18 May 2020 17:09:03 +0200 From: Christoph Hellwig To: Masami Hiramatsu Cc: Christoph Hellwig , x86@kernel.org, Alexei Starovoitov , Daniel Borkmann , Linus Torvalds , Andrew Morton , linux-parisc@vger.kernel.org, linux-um@lists.infradead.org, netdev@vger.kernel.org, bpf@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 14/18] maccess: allow architectures to provide kernel probing directly Message-ID: <20200518150903.GD8871@lst.de> References: <20200513160038.2482415-1-hch@lst.de> <20200513160038.2482415-15-hch@lst.de> <20200516124259.5b68a4e1d4670efa1397a1e0@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200516124259.5b68a4e1d4670efa1397a1e0@kernel.org> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-parisc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-parisc@vger.kernel.org On Sat, May 16, 2020 at 12:42:59PM +0900, Masami Hiramatsu wrote: > > Provide alternative versions of probe_kernel_read, probe_kernel_write > > and strncpy_from_kernel_unsafe that don't need set_fs magic, but instead > > use arch hooks that are modelled after unsafe_{get,put}_user to access > > kernel memory in an exception safe way. > > This patch seems to introduce new implementation of probe_kernel_read/write() > and strncpy_from_kernel_unsafe(), but also drops copy_from/to_kernel_nofault() > and strncpy_from_kernel_nofault() if HAVE_ARCH_PROBE_KERNEL is defined. > In the result, this cause a link error with BPF and kprobe events. That was just a bug as I didn't commit the changes to switch everything to _nofault and remove _unsafe entirely, sorry. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jahO6-0000yZ-O3 for linux-um@lists.infradead.org; Mon, 18 May 2020 15:09:08 +0000 Date: Mon, 18 May 2020 17:09:03 +0200 From: Christoph Hellwig Subject: Re: [PATCH 14/18] maccess: allow architectures to provide kernel probing directly Message-ID: <20200518150903.GD8871@lst.de> References: <20200513160038.2482415-1-hch@lst.de> <20200513160038.2482415-15-hch@lst.de> <20200516124259.5b68a4e1d4670efa1397a1e0@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200516124259.5b68a4e1d4670efa1397a1e0@kernel.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-um" Errors-To: linux-um-bounces+geert=linux-m68k.org@lists.infradead.org To: Masami Hiramatsu Cc: linux-parisc@vger.kernel.org, Daniel Borkmann , netdev@vger.kernel.org, x86@kernel.org, linux-um@lists.infradead.org, Alexei Starovoitov , linux-kernel@vger.kernel.org, linux-mm@kvack.org, bpf@vger.kernel.org, Andrew Morton , Linus Torvalds , Christoph Hellwig On Sat, May 16, 2020 at 12:42:59PM +0900, Masami Hiramatsu wrote: > > Provide alternative versions of probe_kernel_read, probe_kernel_write > > and strncpy_from_kernel_unsafe that don't need set_fs magic, but instead > > use arch hooks that are modelled after unsafe_{get,put}_user to access > > kernel memory in an exception safe way. > > This patch seems to introduce new implementation of probe_kernel_read/write() > and strncpy_from_kernel_unsafe(), but also drops copy_from/to_kernel_nofault() > and strncpy_from_kernel_nofault() if HAVE_ARCH_PROBE_KERNEL is defined. > In the result, this cause a link error with BPF and kprobe events. That was just a bug as I didn't commit the changes to switch everything to _nofault and remove _unsafe entirely, sorry. _______________________________________________ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um