From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=Wv37=7A=vger.kernel.org=netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,
	SPF_PASS autolearn=no autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 3A2A2C433E0
	for <netdev@archiver.kernel.org>; Mon, 18 May 2020 22:30:09 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id 1392C20835
	for <netdev@archiver.kernel.org>; Mon, 18 May 2020 22:30:09 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=default; t=1589841009;
	bh=U5qT/2aPoZavX7g3zxtHrmSQmOm/kvN8jYrMuRUOQDc=;
	h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From;
	b=0XJSRbLk8U2IqfT9nq4+MBSkmIvISEkrALJEDkmVqiv37ed5NOJhWHocCTFTDy/hS
	 3AAEcWdtiId5nSuBRtOE5/5tyDOP9muMKNknp3PhswkvkT0LlxcURFrjpHv1dlhS6C
	 Mh5bbLknfd44TzOJy5FKnJcpD3FB5w4s5Cg31TwQ=
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1728631AbgERWaI (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Mon, 18 May 2020 18:30:08 -0400
Received: from mail.kernel.org ([198.145.29.99]:37960 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1728068AbgERWaI (ORCPT <rfc822;netdev@vger.kernel.org>);
        Mon, 18 May 2020 18:30:08 -0400
Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.5])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by mail.kernel.org (Postfix) with ESMTPSA id 7FB34207ED;
        Mon, 18 May 2020 22:30:07 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=default; t=1589841007;
        bh=U5qT/2aPoZavX7g3zxtHrmSQmOm/kvN8jYrMuRUOQDc=;
        h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
        b=CN0Uw+T4ZL2qdi+Znnb1BX7EOAhHJ1hYe3X3Oi8F0hhsModWqqrkghctAWA6QmztD
         McGkWUNSksJ8PqfhObGOvdDPuKaXqzmkHogJByntFflJ2lvh+tXK3Vmu3OLAuy4w2H
         YAjrhynvnbH5egQo+/WjW1z+VJG+q/H2sa+f3oKY=
Date:   Mon, 18 May 2020 15:30:05 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     Vadim Fedorenko <vfedorenko@novek.ru>
Cc:     Boris Pismenny <borisp@mellanox.com>,
        Aviad Yehezkel <aviadye@mellanox.com>,
        Daniel Borkmann <daniel@iogearbox.net>, netdev@vger.kernel.org
Subject: Re: [PATCH] net/tls: fix encryption error checking
Message-ID: <20200518153005.577dfe99@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
In-Reply-To: <20200517014451.954F05026DE@novek.ru>
References: <20200517014451.954F05026DE@novek.ru>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: netdev-owner@vger.kernel.org
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

On Sun, 17 May 2020 02:48:39 +0300 Vadim Fedorenko wrote:
> tls_push_record can return -EAGAIN because of tcp layer. In that
> case open_rec is already in the tx_record list and should not be
> freed.
> Also the record size can be more than the size requested to write
> in tls_sw_do_sendpage(). That leads to overflow of copied variable
> and wrong return code.
> 
> Fixes: d10523d0b3d7 ("net/tls: free the record on encryption error")
> Signed-off-by: Vadim Fedorenko <vfedorenko@novek.ru>

Doesn't this return -EAGAIN back to user space? Meaning even tho we
queued the user space will try to send it again?