From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85E44C433E0 for ; Mon, 18 May 2020 18:14:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7323B20671 for ; Mon, 18 May 2020 18:14:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732294AbgERSOm (ORCPT ); Mon, 18 May 2020 14:14:42 -0400 Received: from mga18.intel.com ([134.134.136.126]:24475 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729719AbgERSOk (ORCPT ); Mon, 18 May 2020 14:14:40 -0400 IronPort-SDR: vBQ0B9julmD6isB6NfxKj+yO+jKgoDUjV4PXdHwBVR6c2kYJYUC4sR6rde6+ThEEaF37MRfjfd vaTwz5TUuQqA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 May 2020 11:14:39 -0700 IronPort-SDR: j/46IT6eWsYwOW6sl5zbmbDriMKsrikLjOU+dd+Mo3hYvrfmQry4QGbMj8Pq+j5gpPUs8S5RPK s6GoooRqllGg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,407,1583222400"; d="scan'208";a="253133530" Received: from iweiny-desk2.sc.intel.com ([10.3.52.147]) by fmsmga007.fm.intel.com with ESMTP; 18 May 2020 11:14:39 -0700 Date: Mon, 18 May 2020 11:14:39 -0700 From: Ira Weiny To: Guenter Roeck Cc: Mike Rapoport , Will Deacon , linux-kernel@vger.kernel.org, elver@google.com, tglx@linutronix.de, paulmck@kernel.org, mingo@kernel.org, peterz@infradead.org, "David S. Miller" Subject: Re: [PATCH v5 04/18] sparc32: mm: Reduce allocation size for PMD and PTE tables Message-ID: <20200518181438.GB3028105@iweiny-DESK2.sc.intel.com> References: <20200511204150.27858-1-will@kernel.org> <20200511204150.27858-5-will@kernel.org> <20200517000050.GA87467@roeck-us.net> <20200517000750.GA157503@roeck-us.net> <20200518083715.GA31383@willie-the-truck> <418aa44b-6fb3-c3d8-a920-1a26e5edec62@roeck-us.net> <20200518142310.GC1118872@kernel.org> <20200518160811.GA66689@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200518160811.GA66689@roeck-us.net> User-Agent: Mutt/1.11.1 (2018-12-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 18, 2020 at 09:08:11AM -0700, Guenter Roeck wrote: > On Mon, May 18, 2020 at 05:23:10PM +0300, Mike Rapoport wrote: > > On Mon, May 18, 2020 at 02:48:18AM -0700, Guenter Roeck wrote: > > > On 5/18/20 1:37 AM, Will Deacon wrote: > > > > On Sat, May 16, 2020 at 05:07:50PM -0700, Guenter Roeck wrote: > > > >> On Sat, May 16, 2020 at 05:00:50PM -0700, Guenter Roeck wrote: > > > >>> On Mon, May 11, 2020 at 09:41:36PM +0100, Will Deacon wrote: > > > >>>> Now that the page table allocator can free page table allocations > > > >>>> smaller than PAGE_SIZE, reduce the size of the PMD and PTE allocations > > > >>>> to avoid needlessly wasting memory. > > > >>>> > > > >>>> Cc: "David S. Miller" > > > >>>> Cc: Peter Zijlstra > > > >>>> Signed-off-by: Will Deacon > > > >>> > > > >>> Something in the sparc32 patches in linux-next causes all my sparc32 emulations > > > >>> to crash. bisect points to this patch, but reverting it doesn't help, and neither > > > >>> does reverting the rest of the series. > > > >>> > > > >> Actually, turns out I see the same pattern (lots of scheduling while atomic > > > >> followed by 'killing interrupt handler' in cryptomgr_test) with several > > > >> powerpc boot tests. I am currently bisecting those crashes. I'll report > > > >> the results here as well as soon as I have it. > > > > > > > > FWIW, I retested my sparc32 patches with PREEMPT=y and I don't see any > > > > issues. However, linux-next is a different story, where I don't get very far > > > > at all: > > > > > > > > BUG: Bad page state in process swapper pfn:005b4 > > > > This one seems to be due to commit 24aab577764f ("mm: memmap_init: > > iterate over memblock regions rather that check each PFN") and reverting > > it and partially reverting the next cleanup commits makes those > > dissapear. sparc32 boot still fails on today's linux-next and mmotm for me with > > > > Run /sbin/init as init process > > with arguments: > > /sbin/init > > with environment: > > HOME=/ > > TERM=linux > > Starting init: /sbin/init exists but couldn't execute it (error -14) > > > > Interesting; that is also seen on microblazeel:petalogix-ml605. Bisect there > suggests 'arch/kmap_atomic: consolidate duplicate code' as the culprit, > which is part of Ira's series. > > Today's -next is even worse, unfortunately; now all microblaze boot tests > (both little and big endian) fail, plus everything that failed last > time, plus new compile failures. Another round of bisects ... Sparc had the same problem... commit 6e5c523370c510f5fae3436b193ab5dabe0fef06 (HEAD -> lm-kmap17) Author: Ira Weiny Date: Mon May 18 11:13:16 2020 -0700 arch/sparc: Don't enable pagefault/preempt twice The kunmap_atomic clean up failed to remove the pagefault/preempt enables on this path. Fixes: bee2128a09e6 ("arch/kunmap_atomic: consolidate duplicate code") Signed-off-by: Ira Weiny diff --git a/arch/sparc/mm/highmem.c b/arch/sparc/mm/highmem.c index d237d902f9c3..13fb197bb26c 100644 --- a/arch/sparc/mm/highmem.c +++ b/arch/sparc/mm/highmem.c @@ -86,11 +86,8 @@ void kunmap_atomic_high(void *kvaddr) unsigned long vaddr = (unsigned long) kvaddr & PAGE_MASK; int type; - if (vaddr < FIXADDR_START) { // FIXME - pagefault_enable(); - preempt_enable(); + if (vaddr < FIXADDR_START) // FIXME return; - } type = kmap_atomic_idx();