From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BDA8C433E0 for ; Mon, 18 May 2020 22:35:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DE3EC20829 for ; Mon, 18 May 2020 22:35:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589841313; bh=bim+Wqlbpg3ow1ruxMttpLSJEZx5ODlUGcT0+LbS9x0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=Is3KOkUdbCGcf8ww+O4OMxMczDmZ431OhHlWU1k1aq8+/3KcxSIF9K+BhY1qTPw/L 7wZE9RtbkwClyqLhFcYzM8EVg7Mm3BpVj3GfTJ9Y25rz882VEU96aeh3CmixKJYjDt /RWyyFW2wSs4NobN2aXoHfV9DBx9CIMmiPxm58uA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728229AbgERWfN (ORCPT ); Mon, 18 May 2020 18:35:13 -0400 Received: from mail.kernel.org ([198.145.29.99]:39112 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726959AbgERWfM (ORCPT ); Mon, 18 May 2020 18:35:12 -0400 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9B32B20756; Mon, 18 May 2020 22:35:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589841312; bh=bim+Wqlbpg3ow1ruxMttpLSJEZx5ODlUGcT0+LbS9x0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pW9TdC2c/QFLC760zBJw3wq1A6pU7sv35XuqiL3ktsDSb7AnHVhrD1n1NHujzr+6i 1u+b5j7oBdWo0V5B4DA0cLNUUCBe6PeZ2ZXRTJRreG7KDyN1Ykcipc8Z5LRegzeBsj gCmzd+K/dcftxZhEl/xiq7BXIQGYUBjS+EYGZFrk= Date: Mon, 18 May 2020 23:35:07 +0100 From: Will Deacon To: Anshuman Khandual Cc: Dave Martin , linux-arm-kernel@lists.infradead.org, Mark Rutland , Catalin Marinas , Suzuki K Poulose , linux-kernel@vger.kernel.org, Mark Brown , Ard Biesheuvel Subject: Re: [PATCH V2] arm64/cpuinfo: Move HWCAP name arrays alongside their bit definitions Message-ID: <20200518223506.GA5866@willie-the-truck> References: <1588858150-26823-1-git-send-email-anshuman.khandual@arm.com> <20200513150405.GS21779@arm.com> <0999fa28-3ee7-3f02-4def-a0c6013ec6dd@arm.com> <20200514073613.GB4280@willie-the-truck> <8ddd0ca5-07c9-3a99-2ec6-4a201725ebe8@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <8ddd0ca5-07c9-3a99-2ec6-4a201725ebe8@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 15, 2020 at 08:58:05AM +0530, Anshuman Khandual wrote: > On 05/14/2020 01:06 PM, Will Deacon wrote: > > Why is it a change? We've never reported e.g. "java" on an arm64 kernel, so > > We already have "java" defined in existing compat_hwcap_str[] array even > though it might never get set in compat_elf_hwcap. AFAICS, compat_elf_hwcap > will have the following capabilities set (at the most). > > Via COMPAT_ELF_HWCAP_DEFAULT > > 01. COMPAT_HWCAP_HALF > 02. COMPAT_HWCAP_THUMB > 03. COMPAT_HWCAP_FAST_MULT > 04. COMPAT_HWCAP_EDSP > 05. COMPAT_HWCAP_TLS > 06. COMPAT_HWCAP_IDIV > 07. COMPAT_HWCAP_LPAE > > Via setup_elf_hwcaps(compat_elf_hwcaps) <-- setup_cpu_features() > > 8. COMPAT_HWCAP_NEON > 9. COMPAT_HWCAP_VFPv4 > 10. COMPAT_HWCAP_VFP > 11. COMPAT_HWCAP_VFPv3 > > Via arch_timer_set_evtstrm_feature() > > 12. COMPAT_HWCAP_EVTSTRM > > The code exists for "java" string to be displayed with /proc/cpuinfo but it > may never get triggered as compat_elf_hwcap will never have JAVA capability > unless there is a bug as you had rightly mentioned. Fair enough, but applying this patch causes a *tonne* of warnings from aiaiai: +In file included from arch/arm64/include/asm/cpufeature.h:11, + from arch/arm64/include/asm/ptrace.h:11, + from arch/arm64/include/asm/irqflags.h:10, + from include/linux/irqflags.h:16, + from include/linux/spinlock.h:54, + from include/linux/seqlock.h:36, + from include/linux/time.h:6, + from arch/arm64/include/asm/stat.h:12, + from include/linux/stat.h:6, + from include/linux/module.h:13, + from drivers/media/rc/keymaps/rc-imon-mce.mod.c:1: +arch/arm64/include/asm/hwcap.h:189:26: warning: ‘compat_hwcap2_str’ defined but not used [-Wunused-const-variable=] + 189 | static const char *const compat_hwcap2_str[] = { + | ^~~~~~~~~~~~~~~~~ so I'm dropping this for now. Will From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 669B1C433E0 for ; Mon, 18 May 2020 22:35:17 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3834620756 for ; Mon, 18 May 2020 22:35:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="S0zqKky7"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="pW9TdC2c" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3834620756 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/mSoV1yWNBRLMV5dxsj8Md2TZHzgGbFok3jyBlzm/gU=; b=S0zqKky7CMm+VX zCTMFE/2a/ZFITxBEjgT+WEcX9zyxYESyDhJam3RloQDtVx8CclxD822ZndSXSr+dxydM9Iy/G0g4 o4j0TkgYlXdzrxF9iB1jvvCPGC+B+KYqtVC8pAuBCJK+UJSLLiSa7e2+TH93MbkbQNZ+dZoS6bbe4 OUUn4Y90Ie4rDpeX1FtLguinU+/cbB2hHOra3kzLu/KClM6MHBCkxUcX4k+G6nZ7jovKYc2D38egk WkYScF53IwrPIpA2vCVBVnVQpBJVfFgrbBQYfqmL1hEN37GMqEw8e8bK4zKG4zC2bfzYuWgO0+YR7 QkfWH6w9UsCsDRZ8jrpg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jaoLr-0007n2-7B; Mon, 18 May 2020 22:35:15 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jaoLo-0007mN-JK for linux-arm-kernel@lists.infradead.org; Mon, 18 May 2020 22:35:13 +0000 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9B32B20756; Mon, 18 May 2020 22:35:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589841312; bh=bim+Wqlbpg3ow1ruxMttpLSJEZx5ODlUGcT0+LbS9x0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pW9TdC2c/QFLC760zBJw3wq1A6pU7sv35XuqiL3ktsDSb7AnHVhrD1n1NHujzr+6i 1u+b5j7oBdWo0V5B4DA0cLNUUCBe6PeZ2ZXRTJRreG7KDyN1Ykcipc8Z5LRegzeBsj gCmzd+K/dcftxZhEl/xiq7BXIQGYUBjS+EYGZFrk= Date: Mon, 18 May 2020 23:35:07 +0100 From: Will Deacon To: Anshuman Khandual Subject: Re: [PATCH V2] arm64/cpuinfo: Move HWCAP name arrays alongside their bit definitions Message-ID: <20200518223506.GA5866@willie-the-truck> References: <1588858150-26823-1-git-send-email-anshuman.khandual@arm.com> <20200513150405.GS21779@arm.com> <0999fa28-3ee7-3f02-4def-a0c6013ec6dd@arm.com> <20200514073613.GB4280@willie-the-truck> <8ddd0ca5-07c9-3a99-2ec6-4a201725ebe8@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <8ddd0ca5-07c9-3a99-2ec6-4a201725ebe8@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200518_153512_657268_779A11FB X-CRM114-Status: GOOD ( 12.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Suzuki K Poulose , Catalin Marinas , linux-kernel@vger.kernel.org, Ard Biesheuvel , Mark Brown , Dave Martin , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gRnJpLCBNYXkgMTUsIDIwMjAgYXQgMDg6NTg6MDVBTSArMDUzMCwgQW5zaHVtYW4gS2hhbmR1 YWwgd3JvdGU6Cj4gT24gMDUvMTQvMjAyMCAwMTowNiBQTSwgV2lsbCBEZWFjb24gd3JvdGU6Cj4g PiBXaHkgaXMgaXQgYSBjaGFuZ2U/IFdlJ3ZlIG5ldmVyIHJlcG9ydGVkIGUuZy4gImphdmEiIG9u IGFuIGFybTY0IGtlcm5lbCwgc28KPiAKPiBXZSBhbHJlYWR5IGhhdmUgImphdmEiIGRlZmluZWQg aW4gZXhpc3RpbmcgY29tcGF0X2h3Y2FwX3N0cltdIGFycmF5IGV2ZW4KPiB0aG91Z2ggaXQgbWln aHQgbmV2ZXIgZ2V0IHNldCBpbiBjb21wYXRfZWxmX2h3Y2FwLiBBRkFJQ1MsIGNvbXBhdF9lbGZf aHdjYXAKPiB3aWxsIGhhdmUgdGhlIGZvbGxvd2luZyBjYXBhYmlsaXRpZXMgc2V0IChhdCB0aGUg bW9zdCkuCj4gCj4gVmlhIENPTVBBVF9FTEZfSFdDQVBfREVGQVVMVAo+IAo+IDAxLiAgQ09NUEFU X0hXQ0FQX0hBTEYKPiAwMi4gIENPTVBBVF9IV0NBUF9USFVNQgo+IDAzLiAgQ09NUEFUX0hXQ0FQ X0ZBU1RfTVVMVAo+IDA0LiAgQ09NUEFUX0hXQ0FQX0VEU1AKPiAwNS4gIENPTVBBVF9IV0NBUF9U TFMKPiAwNi4gIENPTVBBVF9IV0NBUF9JRElWCj4gMDcuICBDT01QQVRfSFdDQVBfTFBBRQo+IAo+ IFZpYSBzZXR1cF9lbGZfaHdjYXBzKGNvbXBhdF9lbGZfaHdjYXBzKSA8LS0gc2V0dXBfY3B1X2Zl YXR1cmVzKCkKPiAKPiA4LiAgQ09NUEFUX0hXQ0FQX05FT04KPiA5LiAgQ09NUEFUX0hXQ0FQX1ZG UHY0Cj4gMTAuIENPTVBBVF9IV0NBUF9WRlAKPiAxMS4gQ09NUEFUX0hXQ0FQX1ZGUHYzCj4gCj4g VmlhIGFyY2hfdGltZXJfc2V0X2V2dHN0cm1fZmVhdHVyZSgpCj4gCj4gMTIuIENPTVBBVF9IV0NB UF9FVlRTVFJNCj4gCj4gVGhlIGNvZGUgZXhpc3RzIGZvciAiamF2YSIgc3RyaW5nIHRvIGJlIGRp c3BsYXllZCB3aXRoIC9wcm9jL2NwdWluZm8gYnV0IGl0Cj4gbWF5IG5ldmVyIGdldCB0cmlnZ2Vy ZWQgYXMgY29tcGF0X2VsZl9od2NhcCB3aWxsIG5ldmVyIGhhdmUgSkFWQSBjYXBhYmlsaXR5Cj4g dW5sZXNzIHRoZXJlIGlzIGEgYnVnIGFzIHlvdSBoYWQgcmlnaHRseSBtZW50aW9uZWQuCgpGYWly IGVub3VnaCwgYnV0IGFwcGx5aW5nIHRoaXMgcGF0Y2ggY2F1c2VzIGEgKnRvbm5lKiBvZiB3YXJu aW5ncyBmcm9tCmFpYWlhaToKCitJbiBmaWxlIGluY2x1ZGVkIGZyb20gYXJjaC9hcm02NC9pbmNs dWRlL2FzbS9jcHVmZWF0dXJlLmg6MTEsCisgICAgICAgICAgICAgICAgIGZyb20gYXJjaC9hcm02 NC9pbmNsdWRlL2FzbS9wdHJhY2UuaDoxMSwKKyAgICAgICAgICAgICAgICAgZnJvbSBhcmNoL2Fy bTY0L2luY2x1ZGUvYXNtL2lycWZsYWdzLmg6MTAsCisgICAgICAgICAgICAgICAgIGZyb20gaW5j bHVkZS9saW51eC9pcnFmbGFncy5oOjE2LAorICAgICAgICAgICAgICAgICBmcm9tIGluY2x1ZGUv bGludXgvc3BpbmxvY2suaDo1NCwKKyAgICAgICAgICAgICAgICAgZnJvbSBpbmNsdWRlL2xpbnV4 L3NlcWxvY2suaDozNiwKKyAgICAgICAgICAgICAgICAgZnJvbSBpbmNsdWRlL2xpbnV4L3RpbWUu aDo2LAorICAgICAgICAgICAgICAgICBmcm9tIGFyY2gvYXJtNjQvaW5jbHVkZS9hc20vc3RhdC5o OjEyLAorICAgICAgICAgICAgICAgICBmcm9tIGluY2x1ZGUvbGludXgvc3RhdC5oOjYsCisgICAg ICAgICAgICAgICAgIGZyb20gaW5jbHVkZS9saW51eC9tb2R1bGUuaDoxMywKKyAgICAgICAgICAg ICAgICAgZnJvbSBkcml2ZXJzL21lZGlhL3JjL2tleW1hcHMvcmMtaW1vbi1tY2UubW9kLmM6MToK K2FyY2gvYXJtNjQvaW5jbHVkZS9hc20vaHdjYXAuaDoxODk6MjY6IHdhcm5pbmc6IOKAmGNvbXBh dF9od2NhcDJfc3Ry4oCZIGRlZmluZWQgYnV0IG5vdCB1c2VkIFstV3VudXNlZC1jb25zdC12YXJp YWJsZT1dCisgIDE4OSB8IHN0YXRpYyBjb25zdCBjaGFyICpjb25zdCBjb21wYXRfaHdjYXAyX3N0 cltdID0geworICAgICAgfCAgICAgICAgICAgICAgICAgICAgICAgICAgXn5+fn5+fn5+fn5+fn5+ fn4KCnNvIEknbSBkcm9wcGluZyB0aGlzIGZvciBub3cuCgpXaWxsCgpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcg bGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmlu ZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==