From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0AEDEC433E1 for ; Tue, 19 May 2020 05:17:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DE9CE204EF for ; Tue, 19 May 2020 05:17:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="VG11DQ32" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726862AbgESFR1 (ORCPT ); Tue, 19 May 2020 01:17:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55258 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726272AbgESFR0 (ORCPT ); Tue, 19 May 2020 01:17:26 -0400 Received: from mail-pf1-x441.google.com (mail-pf1-x441.google.com [IPv6:2607:f8b0:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AFFD1C061A0C for ; Mon, 18 May 2020 22:17:25 -0700 (PDT) Received: by mail-pf1-x441.google.com with SMTP id q8so4183687pfu.5 for ; Mon, 18 May 2020 22:17:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=wyZN/R6qpcX7fc4AdyQ10EM48vce1r3i4Gy4ZEWGZyo=; b=VG11DQ32nYPFoMQMwo0hmRhLveHx94x4UB3EV11E279byHVSl+SwEDY3t6lYUdIBqb tSqc0GtMXZszHzQ9mmVMShWmPSH/k97kXZotCai/uoBwW3dEtIvSJM+Op7EQrwWWnCtD Az9VmmRwkQGt+3ZS/vBB+5tKdzAJv497Qz80D8SxlcNJ4fHCdMHpPNBW6OfnlDqHAEQ8 JttQ/5qUcjnoeDK9mN+e4lcqvIZHNTGicdEJeAV47NgwHIBmQKXmO9MaigTmZXPyKeSn xwkwD5YHHMVzTsXnEs74G8HAEDDqUlnKrT295laldHRhhVwBaxYPsF6MgvuM7jJ2cBDT B+/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=wyZN/R6qpcX7fc4AdyQ10EM48vce1r3i4Gy4ZEWGZyo=; b=TRIhG1OoI9DnkY0ufh3Pa9bF99WiARCZmLM7cmvvvXTB0riu755ovHLkrqJ5Ip30nm S2SomKJyJo/4NP5b2COS++Xe/bqEDyGqK2C6aV7jj8dVbOyueWAMzi4NAbvgTeKGV2GB uBkObye6mnNocvYngr264tj9va4ZUQ7kHeguB68N5vqHHJue2UkKFaHEUeuFUw/WtgOH Obi9AS28F0ASGDqn9+o/CnWzT6DxflNyUf7CzX2oDCVzX5LFXBv2AzKVliJNmlUabXMH jazqvb36SJOW0XMoNHTihFur0XTYyUTrMZlOT5E//pwmPAPNoFF+cHMmCogKvf+8B5Sc JDzA== X-Gm-Message-State: AOAM530yQQYQZx7F/Ix5Lsi53HEWuJTjJ6Ato1pblBN+Y6T5nmKM9yxj qvAMXKSDIIP1EU3k5OSDT4GHzg== X-Google-Smtp-Source: ABdhPJxnR3xVyoVXFCEFVT/fGHPOoUzzPxhKZnInZ4LxZVIfny/f/6lMiBq0X4YT2pattoSJDrNXAg== X-Received: by 2002:a63:e70b:: with SMTP id b11mr5062941pgi.88.1589865444874; Mon, 18 May 2020 22:17:24 -0700 (PDT) Received: from builder.lan (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id gv4sm1027617pjb.6.2020.05.18.22.17.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 May 2020 22:17:24 -0700 (PDT) Date: Mon, 18 May 2020 22:16:02 -0700 From: Bjorn Andersson To: Vinod Koul Cc: Mathias Nyman , Greg Kroah-Hartman , linux-arm-msm@vger.kernel.org, Christian Lamparter , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Anders Roxell , Arnd Bergmann Subject: Re: [PATCH] usb: xhci: fix USB_XHCI_PCI depends Message-ID: <20200519051602.GY2165@builder.lan> References: <20200519050622.994908-1-vkoul@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200519050622.994908-1-vkoul@kernel.org> Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Mon 18 May 22:06 PDT 2020, Vinod Koul wrote: > The xhci-pci-renesas module exports symbols for xhci-pci to load the > RAM/ROM on renesas xhci controllers. We had dependency which works > when both the modules are builtin or modules. > > But if xhci-pci is inbuilt and xhci-pci-renesas in module, we get below > linker error: > drivers/usb/host/xhci-pci.o: In function `xhci_pci_remove': > drivers/usb/host/xhci-pci.c:411: undefined reference to `renesas_xhci_pci_exit' > drivers/usb/host/xhci-pci.o: In function `xhci_pci_probe': > drivers/usb/host/xhci-pci.c:345: undefined reference to `renesas_xhci_check_request_fw' > > Fix this by adding USB_XHCI_PCI having depends on USB_XHCI_PCI_RENESAS > || !USB_XHCI_PCI_RENESAS so that both can be either inbuilt or modules. > Reviewed-by: Bjorn Andersson Regards, Bjorn > Reported-by: Anders Roxell > Fixes: a66d21d7dba8 ("usb: xhci: Add support for Renesas controller with memory") > Tested-by: Anders Roxell > Signed-off-by: Vinod Koul > --- > drivers/usb/host/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig > index b5c542d6a1c5..92783d175b3f 100644 > --- a/drivers/usb/host/Kconfig > +++ b/drivers/usb/host/Kconfig > @@ -40,11 +40,11 @@ config USB_XHCI_DBGCAP > config USB_XHCI_PCI > tristate > depends on USB_PCI > + depends on USB_XHCI_PCI_RENESAS || !USB_XHCI_PCI_RENESAS > default y > > config USB_XHCI_PCI_RENESAS > tristate "Support for additional Renesas xHCI controller with firwmare" > - depends on USB_XHCI_PCI > ---help--- > Say 'Y' to enable the support for the Renesas xHCI controller with > firwmare. Make sure you have the firwmare for the device and > -- > 2.25.4 >