From: Sargun Dhillon <sargun@sargun.me>
To: Jann Horn <jannh@google.com>
Cc: Kees Cook <keescook@chromium.org>,
Christian Brauner <christian.brauner@ubuntu.com>,
Tycho Andersen <tycho@tycho.ws>,
Matt Denton <mpdenton@google.com>,
Chris Palmer <palmer@google.com>,
Jeffrey Vander Stoep <jeffv@google.com>,
Linux Containers <containers@lists.linux-foundation.org>,
Linux API <linux-api@vger.kernel.org>,
kernel list <linux-kernel@vger.kernel.org>
Subject: Re: seccomp feature development
Date: Tue, 19 May 2020 07:24:52 +0000 [thread overview]
Message-ID: <20200519072451.GA3128@ircssh-2.c.rugged-nimbus-611.internal> (raw)
In-Reply-To: <CAG48ez1LrQvR2RHD5-ZCEihL4YT1tVgoAJfGYo+M3QukumX=OQ@mail.gmail.com>
On Tue, May 19, 2020 at 12:39:39AM +0200, Jann Horn wrote:
> > For user_notif, I think we need something in and around these options:
> >
> > - make a new API that explicitly follows EA struct design
> > (and while read()/write() might be easier[4], I tend to agree with
> > Jann and we need to stick to ioctl(): as Tycho noted, "read/write is
> > for data". Though I wonder if read() could be used for the notifications,
> > which ARE data, and use ioctl() for the responses?)
>
> Just as a note: If we use read() there, we'll never be able to
> transfer things like FDs through that API.
>
Although there is no good reason for read being able to receive FDs, there is
precedence for recvmsg being able to do this. Either way, I do not think
it's a good idea to recv file descriptors, and instead file descriptors
should be fetched via the pidfd_getfd syscall.
Injection is more complicated, and for now, I believe that "writes" should
be done via ioctl, or in the future, something like sendmsg might work.
next prev parent reply other threads:[~2020-05-19 7:24 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-18 21:04 seccomp feature development Kees Cook
2020-05-18 22:39 ` Jann Horn
2020-05-19 2:48 ` Aleksa Sarai
2020-05-19 10:35 ` Christian Brauner
2020-05-19 16:18 ` Alexei Starovoitov
2020-05-19 21:40 ` Kees Cook
2020-05-20 1:20 ` Aleksa Sarai
2020-05-20 5:17 ` Alexei Starovoitov
2020-05-20 6:18 ` Aleksa Sarai
2020-05-19 7:24 ` Sargun Dhillon [this message]
2020-05-19 8:30 ` Christian Brauner
2020-06-03 19:09 ` Kees Cook
2020-05-18 22:55 ` Andy Lutomirski
2020-05-19 7:09 ` Aleksa Sarai
2020-05-19 11:01 ` Christian Brauner
2020-05-19 13:42 ` Aleksa Sarai
2020-05-19 13:53 ` Aleksa Sarai
2020-05-19 10:26 ` Christian Brauner
2020-05-20 8:23 ` Sargun Dhillon
2020-05-19 14:07 ` Tycho Andersen
2020-05-20 9:05 ` Sargun Dhillon
2020-05-22 20:09 ` Sargun Dhillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200519072451.GA3128@ircssh-2.c.rugged-nimbus-611.internal \
--to=sargun@sargun.me \
--cc=christian.brauner@ubuntu.com \
--cc=containers@lists.linux-foundation.org \
--cc=jannh@google.com \
--cc=jeffv@google.com \
--cc=keescook@chromium.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpdenton@google.com \
--cc=palmer@google.com \
--cc=tycho@tycho.ws \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.