All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chi-Hsien Lin <chi-hsien.lin@cypress.com>
To: linux-wireless@vger.kernel.org
Cc: brcm80211-dev-list@broadcom.com, brcm80211-dev-list@cypress.com,
	Arend van Spriel <arend.vanspriel@broadcom.com>,
	Franky Lin <franky.lin@broadcom.com>,
	Hante Meuleman <hante.meuleman@broadcom.com>,
	Wright Feng <wright.feng@cypress.com>,
	Kalle Valo <kvalo@codeaurora.org>,
	Chi-Hsien Lin <chi-hsien.lin@cypress.com>
Subject: [PATCH 1/4] brcmfmac: fix a sparse incorrect type error in p2p.c
Date: Tue, 19 May 2020 06:09:48 -0500	[thread overview]
Message-ID: <20200519110951.88998-2-chi-hsien.lin@cypress.com> (raw)
In-Reply-To: <20200519110951.88998-1-chi-hsien.lin@cypress.com>

Fix the below sparse error introduced by commit 9c29da3f4e7e
("brcmfmac: Fix P2P Group Formation failure via Go-neg method").

drivers/net/wireless/broadcom/brcm80211//brcmfmac/p2p.c:1741:40: error:
incorrect type in initializer (different base types)
drivers/net/wireless/broadcom/brcm80211//brcmfmac/p2p.c:1741:40:
expected signed int [usertype] requested_dwell
drivers/net/wireless/broadcom/brcm80211//brcmfmac/p2p.c:1741:40:    got
restricted __le32 [usertype] dwell_time
make[3]: *** [drivers/net/wireless/broadcom/brcm80211//brcmfmac/p2p.o]
Error 1

Fixes: 9c29da3f4e7ef ("brcmfmac: Fix P2P Group Formation failure via Go-neg method")
Signed-off-by: Chi-Hsien Lin <chi-hsien.lin@cypress.com>
---
 drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c
index d2795dc17c46..194c1ac19402 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c
@@ -1737,8 +1737,7 @@ bool brcmf_p2p_send_action_frame(struct brcmf_cfg80211_info *cfg,
        uint delta_ms;
        unsigned long dwell_jiffies = 0;
        bool dwell_overflow = false;
-
-       s32 requested_dwell = af_params->dwell_time;
+       s32 requested_dwell = le32_to_cpu(af_params->dwell_time);

        action_frame = &af_params->action_frame;
        action_frame_len = le16_to_cpu(action_frame->len);
--
2.25.0


This message and any attachments may contain confidential information from Cypress or its subsidiaries. If it has been received in error, please advise the sender and immediately delete this message.

  reply	other threads:[~2020-05-19 11:10 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-19 11:09 [PATCH 0/4] brcmfmac: SoftAP creation and dcmd buffer size changes Chi-Hsien Lin
2020-05-19 11:09 ` Chi-Hsien Lin [this message]
2020-05-19 11:09 ` [PATCH 2/4] brcmfmac: support virtual interface creation from firmware Chi-Hsien Lin
2020-05-19 11:09 ` [PATCH 3/4] brcmfmac: set net carrier on via test tool for AP mode Chi-Hsien Lin
2020-05-19 11:18   ` Arend Van Spriel
2020-05-21  9:27     ` Chi-Hsien Lin
2020-05-19 11:09 ` [PATCH 4/4] brcmfmac: increase dcmd maximum buffer size Chi-Hsien Lin
2020-05-19 11:29   ` Arend Van Spriel
2020-05-20 12:54     ` Chi-Hsien Lin
2020-05-19 13:54 ` [PATCH 0/4] brcmfmac: SoftAP creation and dcmd buffer size changes Kalle Valo
2020-05-19 17:00   ` Arend Van Spriel
2020-05-22 10:22     ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200519110951.88998-2-chi-hsien.lin@cypress.com \
    --to=chi-hsien.lin@cypress.com \
    --cc=arend.vanspriel@broadcom.com \
    --cc=brcm80211-dev-list@broadcom.com \
    --cc=brcm80211-dev-list@cypress.com \
    --cc=franky.lin@broadcom.com \
    --cc=hante.meuleman@broadcom.com \
    --cc=kvalo@codeaurora.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=wright.feng@cypress.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.