From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A527BC433DF for ; Tue, 19 May 2020 11:41:12 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 081DA20709 for ; Tue, 19 May 2020 11:41:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="JU8/aP7V"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="sIvS1Ov3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 081DA20709 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 259C0173C; Tue, 19 May 2020 13:40:20 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 259C0173C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1589888470; bh=bcWYvf7LQVHMDZmwFZQVAC9Pt0iGf6m3QVJzN4Qa7WE=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=JU8/aP7VdTw7hAT/d+YrP0KtU/yOkqvQfRWKeqcM+WBJ6OdciTv6rGGH8oKJ6AjQW 6YnCIcyEi2Tv7pkriDMpRWKWHJzonny8kojWd7OD/FBHiH80CTFvYNQM2qJ3MTFWOB 8h64jTwIUSWsZPlP8jFZr1fj8mquQKJb2qzFdYto= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id B27FFF80161; Tue, 19 May 2020 13:40:19 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id A0F75F801A3; Tue, 19 May 2020 13:40:18 +0200 (CEST) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 3EEC4F80132 for ; Tue, 19 May 2020 13:40:16 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 3EEC4F80132 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="sIvS1Ov3" Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 21D8920709; Tue, 19 May 2020 11:40:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589888414; bh=bcWYvf7LQVHMDZmwFZQVAC9Pt0iGf6m3QVJzN4Qa7WE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=sIvS1Ov3ZImuiz7Qk/XWcnHrXzE7vvTvDr9WPVawDCOygTxiItuIjoSz3TJvHsu4Y 60+7NIquXL9kIkXo6e5i/ieq+rhCFo/0zi/3KbPGh5ne365UWnJ/his4doRQj2gYRL YjxmvMNyiOTFYLSVPDk6aqencJs1U8jOupWba1vk= Date: Tue, 19 May 2020 12:40:12 +0100 From: Mark Brown To: "Mukunda, Vijendar" Subject: Re: [PATCH v3 08/14] ASoC: amd: add ACP PDM DMA driver dai ops Message-ID: <20200519114012.GH4611@sirena.org.uk> References: <20200518171704.24999-1-Vijendar.Mukunda@amd.com> <20200518171704.24999-9-Vijendar.Mukunda@amd.com> <20200519111907.GD4611@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="r5lq+205vWdkqwtk" Content-Disposition: inline In-Reply-To: X-Cookie: Do not write below this line. User-Agent: Mutt/1.10.1 (2018-07-13) Cc: "tiwai@suse.de" , "Deucher, Alexander" , "alsa-devel@alsa-project.org" X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" --r5lq+205vWdkqwtk Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, May 19, 2020 at 11:37:39AM +0000, Mukunda, Vijendar wrote: > > > + case TWO_CH: > > > + default: > > > + ch_mask =3D 0x00; > > > + break; > > > + } > > The TWO_CH define isn't adding anything, and I'd expect there to be > > invalid channel configurations this is rejecting - at the minute this > > just boils down to an assignment. > Currently we have added two channel support.=20 > As of today, as we restricted no of channels to 2 , there is no point=20 > to check invalid configuration. > It kept for future expansion to support more than two channels. You should still return an error here, if nothing else it ensures that this gets updated when support for other configurations is added. > > > + config_pdm_stream_params(ch_mask, rtd->acp_base); > > Does this function have any other callers - is there a need for it to be > > a separate function? > Current ask is only to support 48Khz, 2 Channel streams. > This is kept for future reference. > This API works as place holder to expand the logic to support multiple > sample rates and no of channels. > Even we can discard this API , do in it calling API itself. Even when you support more configurations these will be configured from hw_params(). --r5lq+205vWdkqwtk Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl7DxZsACgkQJNaLcl1U h9A6Mwf/e3EQZgv+uygFeYcsiPMckaAfbeAe60K0oo+1pBVIcJakyyW8fIPuuSfo CF4dk/tZg8khTyTj0Z0tLH7qQTUHKiHsoqNlJwNvdCUKKqioTJennqC3SiDHfCRx c7OtebI+TR7151K0Mf8FQqK3N+xLLVXyGp7WI/fV3F5a91MDmCit/HfAdCxVU/St bRL+me2VnTQKBM59/9+/0DtdYRr1/I1YtH8GhvcochLjh0qtqoiQK3cjoQJIFjYz 56eHlf656Ybm3lSQpNLkOuqwc4+mGHaMr8IiJ3buPDgOyaMM0ueNfNNX6R8+0Xbw fvqfcdDqPVeJ684mJe0tCBUJP/kA6w== =shJO -----END PGP SIGNATURE----- --r5lq+205vWdkqwtk--