From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1AA31C433DF for ; Tue, 19 May 2020 13:26:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EB855204EA for ; Tue, 19 May 2020 13:26:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gerhold.net header.i=@gerhold.net header.b="C/LEmzzT" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728927AbgESN0C (ORCPT ); Tue, 19 May 2020 09:26:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46734 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726880AbgESN0C (ORCPT ); Tue, 19 May 2020 09:26:02 -0400 Received: from mo6-p02-ob.smtp.rzone.de (mo6-p02-ob.smtp.rzone.de [IPv6:2a01:238:20a:202:5302::8]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6032FC08C5C0; Tue, 19 May 2020 06:26:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1589894759; s=strato-dkim-0002; d=gerhold.net; h=In-Reply-To:References:Message-ID:Subject:Cc:To:From:Date: X-RZG-CLASS-ID:X-RZG-AUTH:From:Subject:Sender; bh=3rxAhv18/WejXE93bIdCZJH8H6kxcCvtozk9gOCeUBs=; b=C/LEmzzTMaQ2tlU84rM5xerIxcJThwnprU0v6tStrvo2/tvjo/YBwIuiN1o02C0Hki IoDplxK5mGwZ+S/dkg2/zbo+qLt4eVRWVA1oqmESxTqhXuowm3nEjcxyojh5JItWoR4a RqrwTNzcyyfr3HMhFqxqRbGqRSplnJ3ip5GBrytbC9SPh/pDOy6O1VIoYGX6LB9z6EQh bEFgCfO+dHIOqba/+JfSDFUhrJrJmKQLf+5SpZ8pSLx5N2Ss1O16e04BiuKc3dWbTY3S NQPpwmIpB/5YIXNNoQY6Fc8LUbuJEyA057bTPEk4rYlB7eguf+gsYwEUs725fn0Z8w9/ YcVQ== X-RZG-AUTH: ":P3gBZUipdd93FF5ZZvYFPugejmSTVR2nRPhVOQ/OcYgojyw4j34+u26zEodhPgRDZ8j9IczFaoo=" X-RZG-CLASS-ID: mo00 Received: from gerhold.net by smtp.strato.de (RZmta 46.6.2 DYNA|AUTH) with ESMTPSA id 60b02dw4JDNul1I (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Tue, 19 May 2020 15:23:56 +0200 (CEST) Date: Tue, 19 May 2020 15:23:54 +0200 From: Stephan Gerhold To: Jonathan Albrieux Cc: linux-kernel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, Andy Shevchenko , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Greg Kroah-Hartman , Hartmut Knaack , Jilayne Lovejoy , Jonathan Cameron , Kate Stewart , Lars-Peter Clausen , Linus Walleij , "open list:IIO SUBSYSTEM AND DRIVERS" , Peter Meerwald-Stadler , Steve Winslow , Thomas Gleixner , Jonathan Cameron , Rob Herring Subject: Re: [PATCH v3 2/4] dt-bindings: iio: magnetometer: ak8975: add gpio reset support Message-ID: <20200519132354.GB4623@gerhold.net> References: <20200519124402.26076-1-jonathan.albrieux@gmail.com> <20200519124402.26076-3-jonathan.albrieux@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200519124402.26076-3-jonathan.albrieux@gmail.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 19, 2020 at 02:43:52PM +0200, Jonathan Albrieux wrote: > Add reset-gpio support. > > Without reset's deassertion during ak8975_power_on(), driver's probe fails > on ak8975_who_i_am() while checking for device identity for AK09911 chip. > > AK09911 has an active low reset gpio to handle register's reset. > AK09911 datasheed says that, if not used, reset pin should be connected datasheed -> datasheet > to VID. This patch emulates this situation. > > Signed-off-by: Jonathan Albrieux > --- > .../devicetree/bindings/iio/magnetometer/ak8975.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/iio/magnetometer/ak8975.yaml b/Documentation/devicetree/bindings/iio/magnetometer/ak8975.yaml > index 86e3efa693a8..a82c0ff5d098 100644 > --- a/Documentation/devicetree/bindings/iio/magnetometer/ak8975.yaml > +++ b/Documentation/devicetree/bindings/iio/magnetometer/ak8975.yaml > @@ -37,6 +37,9 @@ properties: > mount-matrix: > description: an optional 3x3 mounting rotation matrix > > + reset-gpio: > + description: an optional pin needed for AK09911 to set the reset state Maybe add a comment that this should be "usually active low". > + > required: > - compatible > - reg > @@ -53,6 +56,7 @@ examples: > reg = <0x0c>; > gpios = <&gpj0 7 0>; > vdd-supply = <&ldo_3v3_gnss>; > + reset-gpio = <&msmgpio 111 1>; Same here, reset-gpio = <&msmgpio 111 GPIO_ACTIVE_LOW>, would be more clear. > mount-matrix = "-0.984807753012208", /* x0 */ > "0", /* y0 */ > "-0.173648177666930", /* z0 */ > -- > 2.17.1