From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4384FC433E0 for ; Tue, 19 May 2020 17:19:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 16A5920709 for ; Tue, 19 May 2020 17:19:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729363AbgESRT1 (ORCPT ); Tue, 19 May 2020 13:19:27 -0400 Received: from correo.us.es ([193.147.175.20]:46870 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729320AbgESRT0 (ORCPT ); Tue, 19 May 2020 13:19:26 -0400 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id 8129E5E5393 for ; Tue, 19 May 2020 19:19:25 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 73853DA705 for ; Tue, 19 May 2020 19:19:25 +0200 (CEST) Received: by antivirus1-rhel7.int (Postfix, from userid 99) id 671A1DA718; Tue, 19 May 2020 19:19:25 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 754B7DA703; Tue, 19 May 2020 19:19:23 +0200 (CEST) Received: from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int (F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); Tue, 19 May 2020 19:19:23 +0200 (CEST) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int) Received: from us.es (unknown [90.77.255.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: 1984lsi) by entrada.int (Postfix) with ESMTPSA id 5695942EF9E2; Tue, 19 May 2020 19:19:23 +0200 (CEST) Date: Tue, 19 May 2020 19:19:23 +0200 X-SMTPAUTHUS: auth mail.us.es From: Pablo Neira Ayuso To: Edward Cree Cc: davem@davemloft.net, netdev@vger.kernel.org, netfilter-devel@vger.kernel.org, jiri@resnulli.us, kuba@kernel.org Subject: Re: [PATCH net-next v2] net: flow_offload: simplify hw stats check handling Message-ID: <20200519171923.GA16785@salvia> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Virus-Scanned: ClamAV using ClamSMTP Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, May 19, 2020 at 06:02:02PM +0100, Edward Cree wrote: > Make FLOW_ACTION_HW_STATS_DONT_CARE be all bits, rather than none, so that > drivers and __flow_action_hw_stats_check can use simple bitwise checks. > > Only the kernel's internal API semantics change; the TC uAPI is unaffected. This is breaking netfilter again.