From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC43AC433DF for ; Tue, 19 May 2020 19:42:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8B65E207FB for ; Tue, 19 May 2020 19:42:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Azzo19mx" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726348AbgESTmT (ORCPT ); Tue, 19 May 2020 15:42:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49328 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726059AbgESTmT (ORCPT ); Tue, 19 May 2020 15:42:19 -0400 Received: from mail-pl1-x642.google.com (mail-pl1-x642.google.com [IPv6:2607:f8b0:4864:20::642]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0C72EC08C5C0; Tue, 19 May 2020 12:42:18 -0700 (PDT) Received: by mail-pl1-x642.google.com with SMTP id t7so322568plr.0; Tue, 19 May 2020 12:42:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=1PbPu9MDpsX7CWlzIANvDidpxlS/QMPqApRlwiiHNw8=; b=Azzo19mxTglIY2DWsdeqvJCJvbRFWfMvCqe910K+bLoZcz9A0rEclUKyMtzUQpeHzC onlWdkJh3IcWILK4c2hRtOtl7mRzAbiyLlEcJdxmOebPU1v944BfCUyeskdH4MaSANGB mG1De8kuL8xqrOY6I9z2/irGnDdt+dXuW+nblD5+Bi7nB5W52s0/6ICGfZDepT9Noian auesxCt7/j2cCzmSLOIHL82Wa50HphpyDMpe82o3c9PeVBitNH+3VinlNYT9yXfWiYMK CoPZr98AYh6qGXAhrwf3fwANeJXKXy93GRy48lcmGQT0TIdmPLv0mxuhYKT+dVSO6mfx T51Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=1PbPu9MDpsX7CWlzIANvDidpxlS/QMPqApRlwiiHNw8=; b=muQgYRs8PWFmw+0Q6zo9YE+N4fpk8xc2fojL7wA7X1hgYOeeIAvhVdb/eT8P9Xyci+ mAib5D42bW08+zF3cWsU5GvG/9kkf0BiU3ouZQQuv5GS5/TZmncYnEAorXo0LMmNxw1+ GG7kmDGE9fEABTWzI6Ljo38Z6yO2JFmGNn6scls6fjCEH35Md/UI7Vv1Bx5YId7or8bc Rj7x+cHMooknGwvjX78/eAaIPlWzg9RBhvIIBf+BxIHfDMNKlidplTsWg5o+gHqxA5n7 YsfvIcw8yYAJzn/EH3JWW411lPQfeWxK9CS8gpMEZMIV8Wm11cfOG/q46At9t5Sbq5nU OLqA== X-Gm-Message-State: AOAM531JoJhSFEwRJv9NnJz741pbTd/XZMK6SmJlVeDjt0YlN/iFxY3L p9GlTG79r8itb6mg0+LQvPU= X-Google-Smtp-Source: ABdhPJyHaPx1l/c1P1VXN2zRGyOacWb0vDLgVVmiFhoO/p9Se1Yt0uzr0GEQ80rPSqJdr43xSsWcZA== X-Received: by 2002:a17:90a:4811:: with SMTP id a17mr1198137pjh.130.1589917337613; Tue, 19 May 2020 12:42:17 -0700 (PDT) Received: from localhost ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id x5sm234038pfq.196.2020.05.19.12.42.16 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 19 May 2020 12:42:16 -0700 (PDT) Date: Tue, 19 May 2020 12:42:15 -0700 From: Guenter Roeck To: Ira Weiny Cc: linux-kernel@vger.kernel.org, Andrew Morton , Thomas Bogendoerfer , "James E.J. Bottomley" , Helge Deller , Benjamin Herrenschmidt , Paul Mackerras , "David S. Miller" , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Chris Zankel , Max Filippov , Dan Williams , linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org, linux-xtensa@linux-xtensa.org, dri-devel@lists.freedesktop.org, Christian Koenig , Al Viro , Christoph Hellwig Subject: Re: [PATCH] arch/{mips,sparc,microblaze,powerpc}: Don't enable pagefault/preempt twice Message-ID: <20200519194215.GA71941@roeck-us.net> References: <20200507150004.1423069-8-ira.weiny@intel.com> <20200518184843.3029640-1-ira.weiny@intel.com> <20200519165422.GA5838@roeck-us.net> <20200519184031.GB3356843@iweiny-DESK2.sc.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200519184031.GB3356843@iweiny-DESK2.sc.intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-parisc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-parisc@vger.kernel.org On Tue, May 19, 2020 at 11:40:32AM -0700, Ira Weiny wrote: > On Tue, May 19, 2020 at 09:54:22AM -0700, Guenter Roeck wrote: > > On Mon, May 18, 2020 at 11:48:43AM -0700, ira.weiny@intel.com wrote: > > > From: Ira Weiny > > > > > > The kunmap_atomic clean up failed to remove one set of pagefault/preempt > > > enables when vaddr is not in the fixmap. > > > > > > Fixes: bee2128a09e6 ("arch/kunmap_atomic: consolidate duplicate code") > > > Signed-off-by: Ira Weiny > > > > microblazeel works with this patch, > > Awesome... Andrew in my rush yesterday I should have put a reported by on the > patch for Guenter as well. > > Sorry about that Guenter, No worries. > Ira > > > as do the nosmp sparc32 boot tests, > > but sparc32 boot tests with SMP enabled still fail with lots of messages > > such as: > > > > BUG: Bad page state in process swapper/0 pfn:006a1 > > page:f0933420 refcount:0 mapcount:1 mapping:(ptrval) index:0x1 > > flags: 0x0() > > raw: 00000000 00000100 00000122 00000000 00000001 00000000 00000000 00000000 > > page dumped because: nonzero mapcount > > Modules linked in: > > CPU: 0 PID: 1 Comm: swapper/0 Tainted: G B 5.7.0-rc6-next-20200518-00002-gb178d2d56f29 #1 > > [f00e7ab8 : > > bad_page+0xa8/0x108 ] > > [f00e8b54 : > > free_pcppages_bulk+0x154/0x52c ] > > [f00ea024 : > > free_unref_page+0x54/0x6c ] > > [f00ed864 : > > free_reserved_area+0x58/0xec ] > > [f0527104 : > > kernel_init+0x14/0x110 ] > > [f000b77c : > > ret_from_kernel_thread+0xc/0x38 ] > > [00000000 : > > 0x0 ] > > > > Code path leading to that message is different but always the same > > from free_unref_page(). > > > > Still testing ppc images. > > ppc image tests are passing with this patch. Guenter From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Date: Tue, 19 May 2020 19:42:15 +0000 Subject: Re: [PATCH] arch/{mips,sparc,microblaze,powerpc}: Don't enable pagefault/preempt twice Message-Id: <20200519194215.GA71941@roeck-us.net> List-Id: References: <20200507150004.1423069-8-ira.weiny@intel.com> <20200518184843.3029640-1-ira.weiny@intel.com> <20200519165422.GA5838@roeck-us.net> <20200519184031.GB3356843@iweiny-DESK2.sc.intel.com> In-Reply-To: <20200519184031.GB3356843@iweiny-DESK2.sc.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Ira Weiny Cc: Peter Zijlstra , Dave Hansen , dri-devel@lists.freedesktop.org, linux-mips@vger.kernel.org, "James E.J. Bottomley" , Max Filippov , Paul Mackerras , "H. Peter Anvin" , sparclinux@vger.kernel.org, Dan Williams , Helge Deller , x86@kernel.org, linux-csky@vger.kernel.org, Christoph Hellwig , Ingo Molnar , linux-snps-arc@lists.infradead.org, linux-xtensa@linux-xtensa.org, Borislav Petkov , Al Viro , Andy Lutomirski , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, Chris Zankel , Thomas Bogendoerfer , linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org, Christian Koenig , Andrew Morton , linuxppc-dev@lists.ozlabs.org, "David S. Miller" On Tue, May 19, 2020 at 11:40:32AM -0700, Ira Weiny wrote: > On Tue, May 19, 2020 at 09:54:22AM -0700, Guenter Roeck wrote: > > On Mon, May 18, 2020 at 11:48:43AM -0700, ira.weiny@intel.com wrote: > > > From: Ira Weiny > > > > > > The kunmap_atomic clean up failed to remove one set of pagefault/preempt > > > enables when vaddr is not in the fixmap. > > > > > > Fixes: bee2128a09e6 ("arch/kunmap_atomic: consolidate duplicate code") > > > Signed-off-by: Ira Weiny > > > > microblazeel works with this patch, > > Awesome... Andrew in my rush yesterday I should have put a reported by on the > patch for Guenter as well. > > Sorry about that Guenter, No worries. > Ira > > > as do the nosmp sparc32 boot tests, > > but sparc32 boot tests with SMP enabled still fail with lots of messages > > such as: > > > > BUG: Bad page state in process swapper/0 pfn:006a1 > > page:f0933420 refcount:0 mapcount:1 mapping:(ptrval) index:0x1 > > flags: 0x0() > > raw: 00000000 00000100 00000122 00000000 00000001 00000000 00000000 00000000 > > page dumped because: nonzero mapcount > > Modules linked in: > > CPU: 0 PID: 1 Comm: swapper/0 Tainted: G B 5.7.0-rc6-next-20200518-00002-gb178d2d56f29 #1 > > [f00e7ab8 : > > bad_page+0xa8/0x108 ] > > [f00e8b54 : > > free_pcppages_bulk+0x154/0x52c ] > > [f00ea024 : > > free_unref_page+0x54/0x6c ] > > [f00ed864 : > > free_reserved_area+0x58/0xec ] > > [f0527104 : > > kernel_init+0x14/0x110 ] > > [f000b77c : > > ret_from_kernel_thread+0xc/0x38 ] > > [00000000 : > > 0x0 ] > > > > Code path leading to that message is different but always the same > > from free_unref_page(). > > > > Still testing ppc images. > > ppc image tests are passing with this patch. Guenter From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2953CC433E0 for ; Tue, 19 May 2020 19:45:59 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C54D1206C3 for ; Tue, 19 May 2020 19:45:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Azzo19mx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C54D1206C3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 49RRFb0mjrzDqLX for ; Wed, 20 May 2020 05:45:55 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::1042; helo=mail-pj1-x1042.google.com; envelope-from=groeck7@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=Azzo19mx; dkim-atps=neutral Received: from mail-pj1-x1042.google.com (mail-pj1-x1042.google.com [IPv6:2607:f8b0:4864:20::1042]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 49RR9V10vtzDqlY for ; Wed, 20 May 2020 05:42:21 +1000 (AEST) Received: by mail-pj1-x1042.google.com with SMTP id a5so132133pjh.2 for ; Tue, 19 May 2020 12:42:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=1PbPu9MDpsX7CWlzIANvDidpxlS/QMPqApRlwiiHNw8=; b=Azzo19mxTglIY2DWsdeqvJCJvbRFWfMvCqe910K+bLoZcz9A0rEclUKyMtzUQpeHzC onlWdkJh3IcWILK4c2hRtOtl7mRzAbiyLlEcJdxmOebPU1v944BfCUyeskdH4MaSANGB mG1De8kuL8xqrOY6I9z2/irGnDdt+dXuW+nblD5+Bi7nB5W52s0/6ICGfZDepT9Noian auesxCt7/j2cCzmSLOIHL82Wa50HphpyDMpe82o3c9PeVBitNH+3VinlNYT9yXfWiYMK CoPZr98AYh6qGXAhrwf3fwANeJXKXy93GRy48lcmGQT0TIdmPLv0mxuhYKT+dVSO6mfx T51Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=1PbPu9MDpsX7CWlzIANvDidpxlS/QMPqApRlwiiHNw8=; b=JFfCXHuX5Bsv0zV+yWLBvHO4S0HwEVPR/gFFrKW2zvF//pkBTlc6X7akGGAKqQaDtv 0NvyQC7MadsVLnvNAgIojaHDq16G8BqXEaJUN0LZcXLz4fo2yHTzy+sXK+EnOa52ugr4 cU4bbqh2Io1iHKKFnvy5f6oMpQadNxeaOP55fZqltDziFts4+G78hk61yE6s5CX7EGix 5bfrpkxJWNOe1qkzqxXPzBjGyaGbkX42Sa4Zhi7d6bu30lbic1j21MmBKh+ilvGgNtSA z8Sh2HzanNkKrM75o5LtNw4FrQP2HXGlaqh5w+Yj5ux4a9+bC5z9q/nGllbzAZWyHhly bqBA== X-Gm-Message-State: AOAM531L4dWRME5+ZyLp7pSaRyDJYpBkrT+WAuiwoCLp+PS6JyjJyCKB BHpyMNFJ95chTsIeM3xbJ3A= X-Google-Smtp-Source: ABdhPJyHaPx1l/c1P1VXN2zRGyOacWb0vDLgVVmiFhoO/p9Se1Yt0uzr0GEQ80rPSqJdr43xSsWcZA== X-Received: by 2002:a17:90a:4811:: with SMTP id a17mr1198137pjh.130.1589917337613; Tue, 19 May 2020 12:42:17 -0700 (PDT) Received: from localhost ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id x5sm234038pfq.196.2020.05.19.12.42.16 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 19 May 2020 12:42:16 -0700 (PDT) Date: Tue, 19 May 2020 12:42:15 -0700 From: Guenter Roeck To: Ira Weiny Subject: Re: [PATCH] arch/{mips,sparc,microblaze,powerpc}: Don't enable pagefault/preempt twice Message-ID: <20200519194215.GA71941@roeck-us.net> References: <20200507150004.1423069-8-ira.weiny@intel.com> <20200518184843.3029640-1-ira.weiny@intel.com> <20200519165422.GA5838@roeck-us.net> <20200519184031.GB3356843@iweiny-DESK2.sc.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200519184031.GB3356843@iweiny-DESK2.sc.intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Zijlstra , Dave Hansen , dri-devel@lists.freedesktop.org, linux-mips@vger.kernel.org, "James E.J. Bottomley" , Max Filippov , Paul Mackerras , "H. Peter Anvin" , sparclinux@vger.kernel.org, Dan Williams , Helge Deller , x86@kernel.org, linux-csky@vger.kernel.org, Christoph Hellwig , Ingo Molnar , linux-snps-arc@lists.infradead.org, linux-xtensa@linux-xtensa.org, Borislav Petkov , Al Viro , Andy Lutomirski , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, Chris Zankel , Thomas Bogendoerfer , linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org, Christian Koenig , Andrew Morton , linuxppc-dev@lists.ozlabs.org, "David S. Miller" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Tue, May 19, 2020 at 11:40:32AM -0700, Ira Weiny wrote: > On Tue, May 19, 2020 at 09:54:22AM -0700, Guenter Roeck wrote: > > On Mon, May 18, 2020 at 11:48:43AM -0700, ira.weiny@intel.com wrote: > > > From: Ira Weiny > > > > > > The kunmap_atomic clean up failed to remove one set of pagefault/preempt > > > enables when vaddr is not in the fixmap. > > > > > > Fixes: bee2128a09e6 ("arch/kunmap_atomic: consolidate duplicate code") > > > Signed-off-by: Ira Weiny > > > > microblazeel works with this patch, > > Awesome... Andrew in my rush yesterday I should have put a reported by on the > patch for Guenter as well. > > Sorry about that Guenter, No worries. > Ira > > > as do the nosmp sparc32 boot tests, > > but sparc32 boot tests with SMP enabled still fail with lots of messages > > such as: > > > > BUG: Bad page state in process swapper/0 pfn:006a1 > > page:f0933420 refcount:0 mapcount:1 mapping:(ptrval) index:0x1 > > flags: 0x0() > > raw: 00000000 00000100 00000122 00000000 00000001 00000000 00000000 00000000 > > page dumped because: nonzero mapcount > > Modules linked in: > > CPU: 0 PID: 1 Comm: swapper/0 Tainted: G B 5.7.0-rc6-next-20200518-00002-gb178d2d56f29 #1 > > [f00e7ab8 : > > bad_page+0xa8/0x108 ] > > [f00e8b54 : > > free_pcppages_bulk+0x154/0x52c ] > > [f00ea024 : > > free_unref_page+0x54/0x6c ] > > [f00ed864 : > > free_reserved_area+0x58/0xec ] > > [f0527104 : > > kernel_init+0x14/0x110 ] > > [f000b77c : > > ret_from_kernel_thread+0xc/0x38 ] > > [00000000 : > > 0x0 ] > > > > Code path leading to that message is different but always the same > > from free_unref_page(). > > > > Still testing ppc images. > > ppc image tests are passing with this patch. Guenter From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FE33C433E0 for ; Tue, 19 May 2020 19:42:24 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DD29F20826 for ; Tue, 19 May 2020 19:42:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="k99tDpTL"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Azzo19mx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DD29F20826 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-snps-arc-bounces+linux-snps-arc=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2nJR8a4KIlL3LJH0ldCrN9YJYuwvsCm2A4rKfWufvu0=; b=k99tDpTL2f/WNq H3h4zQnDWlUr+NEwXwudIOclZaEiJsKZaf6VA+yDDKML8o6dVt8V6H607ORg5CN9bmmggD29R1HU3 U0hRBzNjfcJFlENoh4PCHhlEsrErWV7ZdqajZBWZ/M16NI+HjjV1VdDnAGJia/OX4owlMgFnQEquT xa+zBhpL8J5HW4G5YOuK2r8XLCSmzPKZbiPlsXvpySfASVA1hTgqlySeN5qyiO2Pp8hoi2J+6Cvdu MFdzSZQtr16QvFSfPSGZK8dY1uDnFOi2zvGhldc04DF/IYJHnlQnsqW+bm9XP9LZ4Djlt4JbGgKsb kUYGfxqmS3mpe5LF1esg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jb885-0000q5-R7; Tue, 19 May 2020 19:42:21 +0000 Received: from mail-pj1-x1043.google.com ([2607:f8b0:4864:20::1043]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jb882-0000pj-5h; Tue, 19 May 2020 19:42:20 +0000 Received: by mail-pj1-x1043.google.com with SMTP id ci21so130444pjb.3; Tue, 19 May 2020 12:42:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=1PbPu9MDpsX7CWlzIANvDidpxlS/QMPqApRlwiiHNw8=; b=Azzo19mxTglIY2DWsdeqvJCJvbRFWfMvCqe910K+bLoZcz9A0rEclUKyMtzUQpeHzC onlWdkJh3IcWILK4c2hRtOtl7mRzAbiyLlEcJdxmOebPU1v944BfCUyeskdH4MaSANGB mG1De8kuL8xqrOY6I9z2/irGnDdt+dXuW+nblD5+Bi7nB5W52s0/6ICGfZDepT9Noian auesxCt7/j2cCzmSLOIHL82Wa50HphpyDMpe82o3c9PeVBitNH+3VinlNYT9yXfWiYMK CoPZr98AYh6qGXAhrwf3fwANeJXKXy93GRy48lcmGQT0TIdmPLv0mxuhYKT+dVSO6mfx T51Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=1PbPu9MDpsX7CWlzIANvDidpxlS/QMPqApRlwiiHNw8=; b=PMDECkFtsAr2R698PtT9WC9/xcJbQBT5gvO/RxY+PtOYFp/TIGssL7/43ZmSZGBgJA Au+OSy5Hjd9wz8kw4YcGQayh42ZQ9fUYSdWqnqHhabh3OeDh+qGw/oVVRXPz9BbjZGE4 PZ4a/tGJB1AeR4ppOpEvCG4OiTnO834XFH16CyZl2ehmbXlD/zz/HtsTdao+mUIwac/3 p21/f61xYO9ERCU4sZ+JhT6IVbHnViv5HQRTVxR87rpBqn5TBqWreHawVkHXieIEDEMB vdo+GmJgDKSwRdwZcDByC3KfFp11Tt4wuYnqQWmSgG9ZBdUF6dL6QX+4FjwGpY/Kac+w zaTA== X-Gm-Message-State: AOAM532N9ZnLnS0U8zQMwlbKBR1JWKSxQw7FsSBh/YUbsbg1qAkcB0t/ 6Pl8gkdznUR7RMm9jOf7J8E= X-Google-Smtp-Source: ABdhPJyHaPx1l/c1P1VXN2zRGyOacWb0vDLgVVmiFhoO/p9Se1Yt0uzr0GEQ80rPSqJdr43xSsWcZA== X-Received: by 2002:a17:90a:4811:: with SMTP id a17mr1198137pjh.130.1589917337613; Tue, 19 May 2020 12:42:17 -0700 (PDT) Received: from localhost ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id x5sm234038pfq.196.2020.05.19.12.42.16 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 19 May 2020 12:42:16 -0700 (PDT) Date: Tue, 19 May 2020 12:42:15 -0700 From: Guenter Roeck To: Ira Weiny Subject: Re: [PATCH] arch/{mips,sparc,microblaze,powerpc}: Don't enable pagefault/preempt twice Message-ID: <20200519194215.GA71941@roeck-us.net> References: <20200507150004.1423069-8-ira.weiny@intel.com> <20200518184843.3029640-1-ira.weiny@intel.com> <20200519165422.GA5838@roeck-us.net> <20200519184031.GB3356843@iweiny-DESK2.sc.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200519184031.GB3356843@iweiny-DESK2.sc.intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200519_124218_261089_B0C64B34 X-CRM114-Status: GOOD ( 17.91 ) X-BeenThere: linux-snps-arc@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on Synopsys ARC Processors List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Zijlstra , Benjamin Herrenschmidt , Dave Hansen , dri-devel@lists.freedesktop.org, linux-mips@vger.kernel.org, "James E.J. Bottomley" , Max Filippov , Paul Mackerras , "H. Peter Anvin" , sparclinux@vger.kernel.org, Dan Williams , Helge Deller , x86@kernel.org, linux-csky@vger.kernel.org, Christoph Hellwig , Ingo Molnar , linux-snps-arc@lists.infradead.org, linux-xtensa@linux-xtensa.org, Borislav Petkov , Al Viro , Andy Lutomirski , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, Chris Zankel , Thomas Bogendoerfer , linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org, Christian Koenig , Andrew Morton , linuxppc-dev@lists.ozlabs.org, "David S. Miller" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-snps-arc" Errors-To: linux-snps-arc-bounces+linux-snps-arc=archiver.kernel.org@lists.infradead.org On Tue, May 19, 2020 at 11:40:32AM -0700, Ira Weiny wrote: > On Tue, May 19, 2020 at 09:54:22AM -0700, Guenter Roeck wrote: > > On Mon, May 18, 2020 at 11:48:43AM -0700, ira.weiny@intel.com wrote: > > > From: Ira Weiny > > > > > > The kunmap_atomic clean up failed to remove one set of pagefault/preempt > > > enables when vaddr is not in the fixmap. > > > > > > Fixes: bee2128a09e6 ("arch/kunmap_atomic: consolidate duplicate code") > > > Signed-off-by: Ira Weiny > > > > microblazeel works with this patch, > > Awesome... Andrew in my rush yesterday I should have put a reported by on the > patch for Guenter as well. > > Sorry about that Guenter, No worries. > Ira > > > as do the nosmp sparc32 boot tests, > > but sparc32 boot tests with SMP enabled still fail with lots of messages > > such as: > > > > BUG: Bad page state in process swapper/0 pfn:006a1 > > page:f0933420 refcount:0 mapcount:1 mapping:(ptrval) index:0x1 > > flags: 0x0() > > raw: 00000000 00000100 00000122 00000000 00000001 00000000 00000000 00000000 > > page dumped because: nonzero mapcount > > Modules linked in: > > CPU: 0 PID: 1 Comm: swapper/0 Tainted: G B 5.7.0-rc6-next-20200518-00002-gb178d2d56f29 #1 > > [f00e7ab8 : > > bad_page+0xa8/0x108 ] > > [f00e8b54 : > > free_pcppages_bulk+0x154/0x52c ] > > [f00ea024 : > > free_unref_page+0x54/0x6c ] > > [f00ed864 : > > free_reserved_area+0x58/0xec ] > > [f0527104 : > > kernel_init+0x14/0x110 ] > > [f000b77c : > > ret_from_kernel_thread+0xc/0x38 ] > > [00000000 : > > 0x0 ] > > > > Code path leading to that message is different but always the same > > from free_unref_page(). > > > > Still testing ppc images. > > ppc image tests are passing with this patch. Guenter _______________________________________________ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5AF3C433E1 for ; Tue, 19 May 2020 19:42:22 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BBB9B207D4 for ; Tue, 19 May 2020 19:42:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="dKFe76OD"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Azzo19mx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BBB9B207D4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VKl59GXO9Y1MBZvKybzmVtQraGWhhYaQOXOzokkYGxc=; b=dKFe76ODghsitj bs1m92ZOOC5sV3Sz6XuJl3t8zvrefZcx7EoGbnhvJQW4gunchusEAGGfwG+wz68wEpn1it7Zfg5ic bOcgbB459MkGA25xd3AKksY5AmdMJ5t6IKLlYDWmxaDdEo9l/eKqz12XDjic80VA59agSFYq7r62o /4mmUY+ZRFPWRy/OIa0KLv0BwcRcjrMuRDzWIvRLvFiORipH0/Tp3/bC2Gd6Qn1e8Gvtwg/RSTQVF HYEY4u/4zBqm9qODHwzrJWWfjwrOreLtfH06fn7ZqN/d/N39QFN0FFpALF9hNor7Q5Z+ZVRaAgNYO wfihiVpqnJ+k7MSqIS0A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jb886-0000qG-8h; Tue, 19 May 2020 19:42:22 +0000 Received: from mail-pj1-x1043.google.com ([2607:f8b0:4864:20::1043]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jb882-0000pj-5h; Tue, 19 May 2020 19:42:20 +0000 Received: by mail-pj1-x1043.google.com with SMTP id ci21so130444pjb.3; Tue, 19 May 2020 12:42:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=1PbPu9MDpsX7CWlzIANvDidpxlS/QMPqApRlwiiHNw8=; b=Azzo19mxTglIY2DWsdeqvJCJvbRFWfMvCqe910K+bLoZcz9A0rEclUKyMtzUQpeHzC onlWdkJh3IcWILK4c2hRtOtl7mRzAbiyLlEcJdxmOebPU1v944BfCUyeskdH4MaSANGB mG1De8kuL8xqrOY6I9z2/irGnDdt+dXuW+nblD5+Bi7nB5W52s0/6ICGfZDepT9Noian auesxCt7/j2cCzmSLOIHL82Wa50HphpyDMpe82o3c9PeVBitNH+3VinlNYT9yXfWiYMK CoPZr98AYh6qGXAhrwf3fwANeJXKXy93GRy48lcmGQT0TIdmPLv0mxuhYKT+dVSO6mfx T51Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=1PbPu9MDpsX7CWlzIANvDidpxlS/QMPqApRlwiiHNw8=; b=PMDECkFtsAr2R698PtT9WC9/xcJbQBT5gvO/RxY+PtOYFp/TIGssL7/43ZmSZGBgJA Au+OSy5Hjd9wz8kw4YcGQayh42ZQ9fUYSdWqnqHhabh3OeDh+qGw/oVVRXPz9BbjZGE4 PZ4a/tGJB1AeR4ppOpEvCG4OiTnO834XFH16CyZl2ehmbXlD/zz/HtsTdao+mUIwac/3 p21/f61xYO9ERCU4sZ+JhT6IVbHnViv5HQRTVxR87rpBqn5TBqWreHawVkHXieIEDEMB vdo+GmJgDKSwRdwZcDByC3KfFp11Tt4wuYnqQWmSgG9ZBdUF6dL6QX+4FjwGpY/Kac+w zaTA== X-Gm-Message-State: AOAM532N9ZnLnS0U8zQMwlbKBR1JWKSxQw7FsSBh/YUbsbg1qAkcB0t/ 6Pl8gkdznUR7RMm9jOf7J8E= X-Google-Smtp-Source: ABdhPJyHaPx1l/c1P1VXN2zRGyOacWb0vDLgVVmiFhoO/p9Se1Yt0uzr0GEQ80rPSqJdr43xSsWcZA== X-Received: by 2002:a17:90a:4811:: with SMTP id a17mr1198137pjh.130.1589917337613; Tue, 19 May 2020 12:42:17 -0700 (PDT) Received: from localhost ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id x5sm234038pfq.196.2020.05.19.12.42.16 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 19 May 2020 12:42:16 -0700 (PDT) Date: Tue, 19 May 2020 12:42:15 -0700 From: Guenter Roeck To: Ira Weiny Subject: Re: [PATCH] arch/{mips,sparc,microblaze,powerpc}: Don't enable pagefault/preempt twice Message-ID: <20200519194215.GA71941@roeck-us.net> References: <20200507150004.1423069-8-ira.weiny@intel.com> <20200518184843.3029640-1-ira.weiny@intel.com> <20200519165422.GA5838@roeck-us.net> <20200519184031.GB3356843@iweiny-DESK2.sc.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200519184031.GB3356843@iweiny-DESK2.sc.intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200519_124218_261089_B0C64B34 X-CRM114-Status: GOOD ( 17.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Zijlstra , Benjamin Herrenschmidt , Dave Hansen , dri-devel@lists.freedesktop.org, linux-mips@vger.kernel.org, "James E.J. Bottomley" , Max Filippov , Paul Mackerras , "H. Peter Anvin" , sparclinux@vger.kernel.org, Dan Williams , Helge Deller , x86@kernel.org, linux-csky@vger.kernel.org, Christoph Hellwig , Ingo Molnar , linux-snps-arc@lists.infradead.org, linux-xtensa@linux-xtensa.org, Borislav Petkov , Al Viro , Andy Lutomirski , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, Chris Zankel , Thomas Bogendoerfer , linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org, Christian Koenig , Andrew Morton , linuxppc-dev@lists.ozlabs.org, "David S. Miller" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, May 19, 2020 at 11:40:32AM -0700, Ira Weiny wrote: > On Tue, May 19, 2020 at 09:54:22AM -0700, Guenter Roeck wrote: > > On Mon, May 18, 2020 at 11:48:43AM -0700, ira.weiny@intel.com wrote: > > > From: Ira Weiny > > > > > > The kunmap_atomic clean up failed to remove one set of pagefault/preempt > > > enables when vaddr is not in the fixmap. > > > > > > Fixes: bee2128a09e6 ("arch/kunmap_atomic: consolidate duplicate code") > > > Signed-off-by: Ira Weiny > > > > microblazeel works with this patch, > > Awesome... Andrew in my rush yesterday I should have put a reported by on the > patch for Guenter as well. > > Sorry about that Guenter, No worries. > Ira > > > as do the nosmp sparc32 boot tests, > > but sparc32 boot tests with SMP enabled still fail with lots of messages > > such as: > > > > BUG: Bad page state in process swapper/0 pfn:006a1 > > page:f0933420 refcount:0 mapcount:1 mapping:(ptrval) index:0x1 > > flags: 0x0() > > raw: 00000000 00000100 00000122 00000000 00000001 00000000 00000000 00000000 > > page dumped because: nonzero mapcount > > Modules linked in: > > CPU: 0 PID: 1 Comm: swapper/0 Tainted: G B 5.7.0-rc6-next-20200518-00002-gb178d2d56f29 #1 > > [f00e7ab8 : > > bad_page+0xa8/0x108 ] > > [f00e8b54 : > > free_pcppages_bulk+0x154/0x52c ] > > [f00ea024 : > > free_unref_page+0x54/0x6c ] > > [f00ed864 : > > free_reserved_area+0x58/0xec ] > > [f0527104 : > > kernel_init+0x14/0x110 ] > > [f000b77c : > > ret_from_kernel_thread+0xc/0x38 ] > > [00000000 : > > 0x0 ] > > > > Code path leading to that message is different but always the same > > from free_unref_page(). > > > > Still testing ppc images. > > ppc image tests are passing with this patch. Guenter _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 463F0C433DF for ; Wed, 20 May 2020 07:35:05 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1C92620671 for ; Wed, 20 May 2020 07:35:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Azzo19mx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1C92620671 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8AB3D6E5B0; Wed, 20 May 2020 07:34:37 +0000 (UTC) Received: from mail-pj1-x1041.google.com (mail-pj1-x1041.google.com [IPv6:2607:f8b0:4864:20::1041]) by gabe.freedesktop.org (Postfix) with ESMTPS id EFA926E0D5 for ; Tue, 19 May 2020 19:42:17 +0000 (UTC) Received: by mail-pj1-x1041.google.com with SMTP id a5so132134pjh.2 for ; Tue, 19 May 2020 12:42:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=1PbPu9MDpsX7CWlzIANvDidpxlS/QMPqApRlwiiHNw8=; b=Azzo19mxTglIY2DWsdeqvJCJvbRFWfMvCqe910K+bLoZcz9A0rEclUKyMtzUQpeHzC onlWdkJh3IcWILK4c2hRtOtl7mRzAbiyLlEcJdxmOebPU1v944BfCUyeskdH4MaSANGB mG1De8kuL8xqrOY6I9z2/irGnDdt+dXuW+nblD5+Bi7nB5W52s0/6ICGfZDepT9Noian auesxCt7/j2cCzmSLOIHL82Wa50HphpyDMpe82o3c9PeVBitNH+3VinlNYT9yXfWiYMK CoPZr98AYh6qGXAhrwf3fwANeJXKXy93GRy48lcmGQT0TIdmPLv0mxuhYKT+dVSO6mfx T51Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=1PbPu9MDpsX7CWlzIANvDidpxlS/QMPqApRlwiiHNw8=; b=FLrdUifqVIBxjM9sLBy/OGKAekWs2GwCJp2iQVPdGO9eYJ6WPgokVz7cz8YnXxQPws D7q/jH7TOUcalpr//lxlhuLzWQsyA7K7VdplOqYmrU7RCk+ePCaKbCDiEJAfwloEhmrD jMBn+qMN+VqNpW1Nab1BOFH3JcS1hsbKn5/GpVw9TQZM9b0HDPZb6tTK5hy1SUGLj8HA M8H8jijdWxbdFYPGBnxPScD74tYqcHpQSO3IqOeYXIIxCj7fHa1KcLIwX17Fsu0+AcVs whrnjbJeYwr268Ehxn5RL7imAy7rpTulLlvwsxsFZzThVAnCTWA3+XvoI6kykVRCTtA2 vvlw== X-Gm-Message-State: AOAM531ErcolqVhrV6sFGqOWWlOkS/5y4/C6HreddcEjvoJRMegvSn+x ysFe1n5nleJW7D4yVMQZHWw= X-Google-Smtp-Source: ABdhPJyHaPx1l/c1P1VXN2zRGyOacWb0vDLgVVmiFhoO/p9Se1Yt0uzr0GEQ80rPSqJdr43xSsWcZA== X-Received: by 2002:a17:90a:4811:: with SMTP id a17mr1198137pjh.130.1589917337613; Tue, 19 May 2020 12:42:17 -0700 (PDT) Received: from localhost ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id x5sm234038pfq.196.2020.05.19.12.42.16 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 19 May 2020 12:42:16 -0700 (PDT) Date: Tue, 19 May 2020 12:42:15 -0700 From: Guenter Roeck To: Ira Weiny Subject: Re: [PATCH] arch/{mips,sparc,microblaze,powerpc}: Don't enable pagefault/preempt twice Message-ID: <20200519194215.GA71941@roeck-us.net> References: <20200507150004.1423069-8-ira.weiny@intel.com> <20200518184843.3029640-1-ira.weiny@intel.com> <20200519165422.GA5838@roeck-us.net> <20200519184031.GB3356843@iweiny-DESK2.sc.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200519184031.GB3356843@iweiny-DESK2.sc.intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Mailman-Approved-At: Wed, 20 May 2020 07:34:33 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Zijlstra , Dave Hansen , dri-devel@lists.freedesktop.org, linux-mips@vger.kernel.org, "James E.J. Bottomley" , Max Filippov , Paul Mackerras , "H. Peter Anvin" , sparclinux@vger.kernel.org, Dan Williams , Helge Deller , x86@kernel.org, linux-csky@vger.kernel.org, Christoph Hellwig , Ingo Molnar , linux-snps-arc@lists.infradead.org, linux-xtensa@linux-xtensa.org, Borislav Petkov , Al Viro , Andy Lutomirski , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, Chris Zankel , Thomas Bogendoerfer , linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org, Christian Koenig , Andrew Morton , linuxppc-dev@lists.ozlabs.org, "David S. Miller" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, May 19, 2020 at 11:40:32AM -0700, Ira Weiny wrote: > On Tue, May 19, 2020 at 09:54:22AM -0700, Guenter Roeck wrote: > > On Mon, May 18, 2020 at 11:48:43AM -0700, ira.weiny@intel.com wrote: > > > From: Ira Weiny > > > > > > The kunmap_atomic clean up failed to remove one set of pagefault/preempt > > > enables when vaddr is not in the fixmap. > > > > > > Fixes: bee2128a09e6 ("arch/kunmap_atomic: consolidate duplicate code") > > > Signed-off-by: Ira Weiny > > > > microblazeel works with this patch, > > Awesome... Andrew in my rush yesterday I should have put a reported by on the > patch for Guenter as well. > > Sorry about that Guenter, No worries. > Ira > > > as do the nosmp sparc32 boot tests, > > but sparc32 boot tests with SMP enabled still fail with lots of messages > > such as: > > > > BUG: Bad page state in process swapper/0 pfn:006a1 > > page:f0933420 refcount:0 mapcount:1 mapping:(ptrval) index:0x1 > > flags: 0x0() > > raw: 00000000 00000100 00000122 00000000 00000001 00000000 00000000 00000000 > > page dumped because: nonzero mapcount > > Modules linked in: > > CPU: 0 PID: 1 Comm: swapper/0 Tainted: G B 5.7.0-rc6-next-20200518-00002-gb178d2d56f29 #1 > > [f00e7ab8 : > > bad_page+0xa8/0x108 ] > > [f00e8b54 : > > free_pcppages_bulk+0x154/0x52c ] > > [f00ea024 : > > free_unref_page+0x54/0x6c ] > > [f00ed864 : > > free_reserved_area+0x58/0xec ] > > [f0527104 : > > kernel_init+0x14/0x110 ] > > [f000b77c : > > ret_from_kernel_thread+0xc/0x38 ] > > [00000000 : > > 0x0 ] > > > > Code path leading to that message is different but always the same > > from free_unref_page(). > > > > Still testing ppc images. > > ppc image tests are passing with this patch. Guenter _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel