From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7849CC433DF for ; Tue, 19 May 2020 23:44:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 42DDF20809 for ; Tue, 19 May 2020 23:44:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="SiB+4L7e" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726379AbgESXob (ORCPT ); Tue, 19 May 2020 19:44:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59336 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725998AbgESXob (ORCPT ); Tue, 19 May 2020 19:44:31 -0400 Received: from mail-qt1-x843.google.com (mail-qt1-x843.google.com [IPv6:2607:f8b0:4864:20::843]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F30D7C061A0E for ; Tue, 19 May 2020 16:44:30 -0700 (PDT) Received: by mail-qt1-x843.google.com with SMTP id m44so1177129qtm.8 for ; Tue, 19 May 2020 16:44:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=l6/TUMn0kemAWniMbQ+TW8Vwyo/kgFVa5klt/X0syHY=; b=SiB+4L7eyhIeL/NEPqO5t0hFi3YFHgzZten4DfuxDbMUkAqsYEtG+IoHRJ6PrbScGp LXKW8SHHL0stIdBiPBu5A9IUO+ROqbIJEhU4xedjaJUkF0P5xT5H3nnDdEHlYhv3K5b/ fhaHDPq586vXNlsTeazu5POebcYmgqGxJVBugD4+sBvkvoqUpe9ugfNMFqf6MaxFQvF5 Jw6bfoierY4Q6H//UC7HrGMtOTkfGxFn43dqNP1UKKtk6XyD54bVU8e6d31H0SwxUnBY Hc6sCtUh7rE9UwmtU6CKynTWQFX4rJ8R6tmpJrE8sf96UONm69NPLfOVc4gHBBQEccBX 08bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=l6/TUMn0kemAWniMbQ+TW8Vwyo/kgFVa5klt/X0syHY=; b=HuMxtMg+vbyTlaE0VfwGkXAwOfKPpH8Xpaec5uy+aguarf5n20AmIJiKaKOVfe58hz didTE5arAmkEvcZ5OEZOcG05GRI+XDD7E+gw40pAS/UfNIsu9I9Fjjb7tc12/lvopPG4 p/gl7ADjNdWnZfu3va+htlwYm98DhG1Vn9vH7UZL/rG3BqB5NV/g1yy6XF73c3z+i0Rf xlJQmwLlI4zhxk77VhqMNIQV1sTg6xyZUlTbzMPBRZquwOg6CcZYwbtIdIoshGjTHX4Q XGPPQjcNzgXGTpArnuyW0EU/KkHyMecfoQnQccVDOZlkyGDUi34Kia1IERbOK5YYPQoY ZC9g== X-Gm-Message-State: AOAM530+T80kRTv1u1O8VW/V+ZffEdOy69bVYmkwSdDiSBuRK0UszZbt K7H8yLqPAuFLJDSDm7oY9WuEng== X-Google-Smtp-Source: ABdhPJzsDk4ivo9nrvpze8Vvv9nUkgMjUT9d51xyrgT9JaiYw9juWcY+VNQCOaKAFaeLTojvx5w6Zw== X-Received: by 2002:ac8:7304:: with SMTP id x4mr2661805qto.4.1589931870282; Tue, 19 May 2020 16:44:30 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-156-34-48-30.dhcp-dynamic.fibreop.ns.bellaliant.net. [156.34.48.30]) by smtp.gmail.com with ESMTPSA id d140sm135131qkc.22.2020.05.19.16.44.29 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 19 May 2020 16:44:29 -0700 (PDT) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1jbBuP-0007yM-6O; Tue, 19 May 2020 20:44:29 -0300 Date: Tue, 19 May 2020 20:44:29 -0300 From: Jason Gunthorpe To: Wei Yongjun Cc: Danil Kipnis , Jack Wang , Doug Ledford , linux-rdma@vger.kernel.org, kernel-janitors@vger.kernel.org, Hulk Robot Subject: Re: [PATCH -next] RDMA/rtrs: server: fix some error return code Message-ID: <20200519234429.GA30609@ziepe.ca> References: <20200519091912.134358-1-weiyongjun1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200519091912.134358-1-weiyongjun1@huawei.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Tue, May 19, 2020 at 09:19:12AM +0000, Wei Yongjun wrote: > Fix to return negative error code -ENOMEM from the some error handling > cases instead of 0, as done elsewhere in this function. > > Fixes: 9cb837480424 ("RDMA/rtrs: server: main functionality") > Fixes: 91b11610af8d ("RDMA/rtrs: server: sysfs interface functions") > Reported-by: Hulk Robot > Signed-off-by: Wei Yongjun > Reviewed-by: Danil Kipnis > --- > drivers/infiniband/ulp/rtrs/rtrs-srv.c | 8 +++++--- > drivers/infiniband/ulp/rtrs/rtrs-srv-sysfs.c | 1 + > 2 file changed, 6 insertions(+), 3 deletions(-) Applied to for-next, thanks Jason From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Date: Tue, 19 May 2020 23:44:29 +0000 Subject: Re: [PATCH -next] RDMA/rtrs: server: fix some error return code Message-Id: <20200519234429.GA30609@ziepe.ca> List-Id: References: <20200519091912.134358-1-weiyongjun1@huawei.com> In-Reply-To: <20200519091912.134358-1-weiyongjun1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Wei Yongjun Cc: Danil Kipnis , Jack Wang , Doug Ledford , linux-rdma@vger.kernel.org, kernel-janitors@vger.kernel.org, Hulk Robot On Tue, May 19, 2020 at 09:19:12AM +0000, Wei Yongjun wrote: > Fix to return negative error code -ENOMEM from the some error handling > cases instead of 0, as done elsewhere in this function. > > Fixes: 9cb837480424 ("RDMA/rtrs: server: main functionality") > Fixes: 91b11610af8d ("RDMA/rtrs: server: sysfs interface functions") > Reported-by: Hulk Robot > Signed-off-by: Wei Yongjun > Reviewed-by: Danil Kipnis > --- > drivers/infiniband/ulp/rtrs/rtrs-srv.c | 8 +++++--- > drivers/infiniband/ulp/rtrs/rtrs-srv-sysfs.c | 1 + > 2 file changed, 6 insertions(+), 3 deletions(-) Applied to for-next, thanks Jason