[PATCH] MIPS: ingenic: Add missing include

[PATCH] MIPS: ingenic: Add missing include

[Paul Cercueil]

Add missing include which adds the prototype to plat_time_init().

Fixes: f932449c11da ("MIPS: ingenic: Drop obsolete code, merge the rest in setup.c")
Signed-off-by: Paul Cercueil <paul@crapouillou.net>
Reported-by: kbuild test robot <lkp@intel.com>
---
 arch/mips/jz4740/setup.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/mips/jz4740/setup.c b/arch/mips/jz4740/setup.c
index 81428ddcaa97..c627fbd90892 100644
--- a/arch/mips/jz4740/setup.c
+++ b/arch/mips/jz4740/setup.c
@@ -20,6 +20,7 @@
 #include <asm/fw/fw.h>
 #include <asm/prom.h>
 #include <asm/reboot.h>
+#include <asm/time.h>
 
 #define JZ4740_EMC_BASE_ADDR 0x13010000
 
-- 
2.26.2

Re: [PATCH] MIPS: ingenic: Add missing include

[Thomas Bogendoerfer]

On Tue, May 19, 2020 at 11:22:30PM +0200, Paul Cercueil wrote:
> Add missing include which adds the prototype to plat_time_init().
> 
> Fixes: f932449c11da ("MIPS: ingenic: Drop obsolete code, merge the rest in setup.c")
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> Reported-by: kbuild test robot <lkp@intel.com>
> ---
>  arch/mips/jz4740/setup.c | 1 +
>  1 file changed, 1 insertion(+)

applied to mips-next.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]

Re: [PATCH] MIPS: ingenic: Add missing include

[Philippe Mathieu-Daudé]

Hi Thomas,

On Wed, May 20, 2020 at 8:50 AM Thomas Bogendoerfer
<tsbogend@alpha.franken.de> wrote:
>
> On Tue, May 19, 2020 at 11:22:30PM +0200, Paul Cercueil wrote:
> > Add missing include which adds the prototype to plat_time_init().
> >
> > Fixes: f932449c11da ("MIPS: ingenic: Drop obsolete code, merge the rest in setup.c")
> > Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> > Reported-by: kbuild test robot <lkp@intel.com>
> > ---
> >  arch/mips/jz4740/setup.c | 1 +
> >  1 file changed, 1 insertion(+)
>
> applied to mips-next.

Since mips-next is not merged, can you simply squash the fix to the
incomplete f932449c11da please?

Thanks,

Phil.

>
> Thomas.
>
> --
> Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
> good idea.                                                [ RFC1925, 2.3 ]

Re: [PATCH] MIPS: ingenic: Add missing include

[Thomas Bogendoerfer]

On Wed, May 20, 2020 at 11:19:49AM +0200, Philippe Mathieu-Daudé wrote:
> Hi Thomas,
> 
> On Wed, May 20, 2020 at 8:50 AM Thomas Bogendoerfer
> <tsbogend@alpha.franken.de> wrote:
> >
> > On Tue, May 19, 2020 at 11:22:30PM +0200, Paul Cercueil wrote:
> > > Add missing include which adds the prototype to plat_time_init().
> > >
> > > Fixes: f932449c11da ("MIPS: ingenic: Drop obsolete code, merge the rest in setup.c")
> > > Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> > > Reported-by: kbuild test robot <lkp@intel.com>
> > > ---
> > >  arch/mips/jz4740/setup.c | 1 +
> > >  1 file changed, 1 insertion(+)
> >
> > applied to mips-next.
> 
> Since mips-next is not merged, can you simply squash the fix to the
> incomplete f932449c11da please?

no, I don't rebase mips-next.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]

Re: [PATCH] MIPS: ingenic: Add missing include

[Philippe Mathieu-Daudé]

On Wed, May 20, 2020 at 11:28 AM Thomas Bogendoerfer
<tsbogend@alpha.franken.de> wrote:
>
> On Wed, May 20, 2020 at 11:19:49AM +0200, Philippe Mathieu-Daudé wrote:
> > Hi Thomas,
> >
> > On Wed, May 20, 2020 at 8:50 AM Thomas Bogendoerfer
> > <tsbogend@alpha.franken.de> wrote:
> > >
> > > On Tue, May 19, 2020 at 11:22:30PM +0200, Paul Cercueil wrote:
> > > > Add missing include which adds the prototype to plat_time_init().
> > > >
> > > > Fixes: f932449c11da ("MIPS: ingenic: Drop obsolete code, merge the rest in setup.c")
> > > > Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> > > > Reported-by: kbuild test robot <lkp@intel.com>
> > > > ---
> > > >  arch/mips/jz4740/setup.c | 1 +
> > > >  1 file changed, 1 insertion(+)
> > >
> > > applied to mips-next.
> >
> > Since mips-next is not merged, can you simply squash the fix to the
> > incomplete f932449c11da please?
>
> no, I don't rebase mips-next.

OK. I had the understanding that mips-fixes was the stable branch not rebased,
and mips-next was not considered stable until merged in mainstream.
I took note of the changes, thanks.

>
> Thomas.
>
> --
> Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
> good idea.                                                [ RFC1925, 2.3 ]