All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v1] mux: adgs1408: Add mod_devicetable.h and remove of_match_ptr
@ 2020-05-20 12:01 Andy Shevchenko
  2020-05-22 12:52 ` Andy Shevchenko
  2020-05-25 10:51 ` Peter Rosin
  0 siblings, 2 replies; 5+ messages in thread
From: Andy Shevchenko @ 2020-05-20 12:01 UTC (permalink / raw)
  To: Mircea Caprioru, linux-kernel, Peter Rosin
  Cc: Andy Shevchenko, kbuild test robot

Enables probing via the ACPI PRP0001 route but more is mostly about
removing examples of this that might get copied into new drivers.

Also fixes
  drivers/mux/adgs1408.c:112:34: warning: unused variable 'adgs1408_of_match
as has been reported recently.

Fixes: e9e40543ad5b ("spi: Add generic SPI multiplexer")
Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/mux/adgs1408.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/mux/adgs1408.c b/drivers/mux/adgs1408.c
index 89096f10f4c4..12466b06692c 100644
--- a/drivers/mux/adgs1408.c
+++ b/drivers/mux/adgs1408.c
@@ -6,9 +6,9 @@
  */
 
 #include <linux/err.h>
+#include <linux/mod_devicetable.h>
 #include <linux/module.h>
 #include <linux/mux/driver.h>
-#include <linux/of_platform.h>
 #include <linux/property.h>
 #include <linux/spi/spi.h>
 
@@ -59,7 +59,7 @@ static int adgs1408_probe(struct spi_device *spi)
 	s32 idle_state;
 	int ret;
 
-	chip_id = (enum adgs1408_chip_id)of_device_get_match_data(dev);
+	chip_id = (enum adgs1408_chip_id)device_get_match_data(dev);
 	if (!chip_id)
 		chip_id = spi_get_device_id(spi)->driver_data;
 
@@ -119,7 +119,7 @@ MODULE_DEVICE_TABLE(of, adgs1408_of_match);
 static struct spi_driver adgs1408_driver = {
 	.driver = {
 		.name = "adgs1408",
-		.of_match_table = of_match_ptr(adgs1408_of_match),
+		.of_match_table = adgs1408_of_match,
 	},
 	.probe = adgs1408_probe,
 	.id_table = adgs1408_spi_id,
-- 
2.26.2


^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [PATCH v1] mux: adgs1408: Add mod_devicetable.h and remove of_match_ptr
  2020-05-20 12:01 [PATCH v1] mux: adgs1408: Add mod_devicetable.h and remove of_match_ptr Andy Shevchenko
@ 2020-05-22 12:52 ` Andy Shevchenko
  2020-05-22 13:09   ` Greg Kroah-Hartman
  2020-05-22 17:34   ` Peter Rosin
  2020-05-25 10:51 ` Peter Rosin
  1 sibling, 2 replies; 5+ messages in thread
From: Andy Shevchenko @ 2020-05-22 12:52 UTC (permalink / raw)
  To: Mircea Caprioru, linux-kernel, Peter Rosin
  Cc: kbuild test robot, Mark Brown, Greg Kroah-Hartman

On Wed, May 20, 2020 at 03:01:22PM +0300, Andy Shevchenko wrote:
> Enables probing via the ACPI PRP0001 route but more is mostly about
> removing examples of this that might get copied into new drivers.
> 
> Also fixes
>   drivers/mux/adgs1408.c:112:34: warning: unused variable 'adgs1408_of_match
> as has been reported recently.

Maybe Mark or Greg can take this?

I can resend Cc'ing you.

> 
> Fixes: e9e40543ad5b ("spi: Add generic SPI multiplexer")
> Reported-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  drivers/mux/adgs1408.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/mux/adgs1408.c b/drivers/mux/adgs1408.c
> index 89096f10f4c4..12466b06692c 100644
> --- a/drivers/mux/adgs1408.c
> +++ b/drivers/mux/adgs1408.c
> @@ -6,9 +6,9 @@
>   */
>  
>  #include <linux/err.h>
> +#include <linux/mod_devicetable.h>
>  #include <linux/module.h>
>  #include <linux/mux/driver.h>
> -#include <linux/of_platform.h>
>  #include <linux/property.h>
>  #include <linux/spi/spi.h>
>  
> @@ -59,7 +59,7 @@ static int adgs1408_probe(struct spi_device *spi)
>  	s32 idle_state;
>  	int ret;
>  
> -	chip_id = (enum adgs1408_chip_id)of_device_get_match_data(dev);
> +	chip_id = (enum adgs1408_chip_id)device_get_match_data(dev);
>  	if (!chip_id)
>  		chip_id = spi_get_device_id(spi)->driver_data;
>  
> @@ -119,7 +119,7 @@ MODULE_DEVICE_TABLE(of, adgs1408_of_match);
>  static struct spi_driver adgs1408_driver = {
>  	.driver = {
>  		.name = "adgs1408",
> -		.of_match_table = of_match_ptr(adgs1408_of_match),
> +		.of_match_table = adgs1408_of_match,
>  	},
>  	.probe = adgs1408_probe,
>  	.id_table = adgs1408_spi_id,
> -- 
> 2.26.2
> 

-- 
With Best Regards,
Andy Shevchenko



^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH v1] mux: adgs1408: Add mod_devicetable.h and remove of_match_ptr
  2020-05-22 12:52 ` Andy Shevchenko
@ 2020-05-22 13:09   ` Greg Kroah-Hartman
  2020-05-22 17:34   ` Peter Rosin
  1 sibling, 0 replies; 5+ messages in thread
From: Greg Kroah-Hartman @ 2020-05-22 13:09 UTC (permalink / raw)
  To: Andy Shevchenko
  Cc: Mircea Caprioru, linux-kernel, Peter Rosin, kbuild test robot,
	Mark Brown

On Fri, May 22, 2020 at 03:52:15PM +0300, Andy Shevchenko wrote:
> On Wed, May 20, 2020 at 03:01:22PM +0300, Andy Shevchenko wrote:
> > Enables probing via the ACPI PRP0001 route but more is mostly about
> > removing examples of this that might get copied into new drivers.
> > 
> > Also fixes
> >   drivers/mux/adgs1408.c:112:34: warning: unused variable 'adgs1408_of_match
> > as has been reported recently.
> 
> Maybe Mark or Greg can take this?

$ ./scripts/get_maintainer.pl --file drivers/mux/adgs1408.c
Mircea Caprioru <mircea.caprioru@analog.com> (supporter:ANALOG DEVICES INC ADGS1408 DRIVER)
Peter Rosin <peda@axentia.se> (maintainer:MULTIPLEXER SUBSYSTEM)
linux-kernel@vger.kernel.org (open list)

Not me!


^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH v1] mux: adgs1408: Add mod_devicetable.h and remove of_match_ptr
  2020-05-22 12:52 ` Andy Shevchenko
  2020-05-22 13:09   ` Greg Kroah-Hartman
@ 2020-05-22 17:34   ` Peter Rosin
  1 sibling, 0 replies; 5+ messages in thread
From: Peter Rosin @ 2020-05-22 17:34 UTC (permalink / raw)
  To: Andy Shevchenko, Mircea Caprioru, linux-kernel
  Cc: kbuild test robot, Mark Brown, Greg Kroah-Hartman

On 2020-05-22 14:52, Andy Shevchenko wrote:
> On Wed, May 20, 2020 at 03:01:22PM +0300, Andy Shevchenko wrote:
>> Enables probing via the ACPI PRP0001 route but more is mostly about
>> removing examples of this that might get copied into new drivers.
>>
>> Also fixes
>>   drivers/mux/adgs1408.c:112:34: warning: unused variable 'adgs1408_of_match
>> as has been reported recently.
> 
> Maybe Mark or Greg can take this?
> 
> I can resend Cc'ing you.

I'll have a look after the (long) weekend.

Cheers,
Peter

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH v1] mux: adgs1408: Add mod_devicetable.h and remove of_match_ptr
  2020-05-20 12:01 [PATCH v1] mux: adgs1408: Add mod_devicetable.h and remove of_match_ptr Andy Shevchenko
  2020-05-22 12:52 ` Andy Shevchenko
@ 2020-05-25 10:51 ` Peter Rosin
  1 sibling, 0 replies; 5+ messages in thread
From: Peter Rosin @ 2020-05-25 10:51 UTC (permalink / raw)
  To: Andy Shevchenko, Mircea Caprioru, linux-kernel; +Cc: kbuild test robot

On 2020-05-20 14:01, Andy Shevchenko wrote:
> Enables probing via the ACPI PRP0001 route but more is mostly about
> removing examples of this that might get copied into new drivers.
> 
> Also fixes
>   drivers/mux/adgs1408.c:112:34: warning: unused variable 'adgs1408_of_match
> as has been reported recently.
> 
> Fixes: e9e40543ad5b ("spi: Add generic SPI multiplexer")
> Reported-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Looks ok to me, so it is added to linux-next. I'll let it soak there for
a couple of days and then intend to pass it on to Greg.

Cheers,
Peter

> ---
>  drivers/mux/adgs1408.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/mux/adgs1408.c b/drivers/mux/adgs1408.c
> index 89096f10f4c4..12466b06692c 100644
> --- a/drivers/mux/adgs1408.c
> +++ b/drivers/mux/adgs1408.c
> @@ -6,9 +6,9 @@
>   */
>  
>  #include <linux/err.h>
> +#include <linux/mod_devicetable.h>
>  #include <linux/module.h>
>  #include <linux/mux/driver.h>
> -#include <linux/of_platform.h>
>  #include <linux/property.h>
>  #include <linux/spi/spi.h>
>  
> @@ -59,7 +59,7 @@ static int adgs1408_probe(struct spi_device *spi)
>  	s32 idle_state;
>  	int ret;
>  
> -	chip_id = (enum adgs1408_chip_id)of_device_get_match_data(dev);
> +	chip_id = (enum adgs1408_chip_id)device_get_match_data(dev);
>  	if (!chip_id)
>  		chip_id = spi_get_device_id(spi)->driver_data;
>  
> @@ -119,7 +119,7 @@ MODULE_DEVICE_TABLE(of, adgs1408_of_match);
>  static struct spi_driver adgs1408_driver = {
>  	.driver = {
>  		.name = "adgs1408",
> -		.of_match_table = of_match_ptr(adgs1408_of_match),
> +		.of_match_table = adgs1408_of_match,
>  	},
>  	.probe = adgs1408_probe,
>  	.id_table = adgs1408_spi_id,


^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-05-25 10:51 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-20 12:01 [PATCH v1] mux: adgs1408: Add mod_devicetable.h and remove of_match_ptr Andy Shevchenko
2020-05-22 12:52 ` Andy Shevchenko
2020-05-22 13:09   ` Greg Kroah-Hartman
2020-05-22 17:34   ` Peter Rosin
2020-05-25 10:51 ` Peter Rosin

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.