* [PATCH] wlcore: fix runtime pm imbalance in wl1271_tx_work
@ 2020-05-20 12:42 Dinghao Liu
2020-05-20 18:52 ` Tony Lindgren
2020-05-29 17:31 ` Kalle Valo
0 siblings, 2 replies; 3+ messages in thread
From: Dinghao Liu @ 2020-05-20 12:42 UTC (permalink / raw)
To: dinghao.liu, kjlu
Cc: Kalle Valo, David S. Miller, Jakub Kicinski, Thomas Gleixner,
Arnd Bergmann, Greg Kroah-Hartman, Allison Randal,
Alexios Zavras, Jason A. Donenfeld, linux-wireless, netdev,
linux-kernel
There are two error handling paths in this functon. When
wlcore_tx_work_locked() returns an error code, we should
decrease the runtime PM usage counter the same way as the
error handling path beginning from pm_runtime_get_sync().
Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
---
drivers/net/wireless/ti/wlcore/tx.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/wireless/ti/wlcore/tx.c b/drivers/net/wireless/ti/wlcore/tx.c
index 90e56d4c3df3..e20e18cd04ae 100644
--- a/drivers/net/wireless/ti/wlcore/tx.c
+++ b/drivers/net/wireless/ti/wlcore/tx.c
@@ -863,6 +863,7 @@ void wl1271_tx_work(struct work_struct *work)
ret = wlcore_tx_work_locked(wl);
if (ret < 0) {
+ pm_runtime_put_noidle(wl->dev);
wl12xx_queue_recovery_work(wl);
goto out;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] wlcore: fix runtime pm imbalance in wl1271_tx_work
2020-05-20 12:42 [PATCH] wlcore: fix runtime pm imbalance in wl1271_tx_work Dinghao Liu
@ 2020-05-20 18:52 ` Tony Lindgren
2020-05-29 17:31 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Tony Lindgren @ 2020-05-20 18:52 UTC (permalink / raw)
To: Dinghao Liu
Cc: kjlu, Kalle Valo, David S. Miller, Jakub Kicinski,
Thomas Gleixner, Arnd Bergmann, Greg Kroah-Hartman,
Allison Randal, Alexios Zavras, Jason A. Donenfeld,
linux-wireless, netdev, linux-kernel
* Dinghao Liu <dinghao.liu@zju.edu.cn> [691231 23:00]:
> There are two error handling paths in this functon. When
> wlcore_tx_work_locked() returns an error code, we should
> decrease the runtime PM usage counter the same way as the
> error handling path beginning from pm_runtime_get_sync().
Acked-by: Tony Lindgren <tony@atomide.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] wlcore: fix runtime pm imbalance in wl1271_tx_work
2020-05-20 12:42 [PATCH] wlcore: fix runtime pm imbalance in wl1271_tx_work Dinghao Liu
2020-05-20 18:52 ` Tony Lindgren
@ 2020-05-29 17:31 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2020-05-29 17:31 UTC (permalink / raw)
To: Dinghao Liu
Cc: dinghao.liu, kjlu, David S. Miller, Jakub Kicinski,
Thomas Gleixner, Arnd Bergmann, Greg Kroah-Hartman,
Allison Randal, Alexios Zavras, Jason A. Donenfeld,
linux-wireless, netdev, linux-kernel
Dinghao Liu <dinghao.liu@zju.edu.cn> wrote:
> There are two error handling paths in this functon. When
> wlcore_tx_work_locked() returns an error code, we should
> decrease the runtime PM usage counter the same way as the
> error handling path beginning from pm_runtime_get_sync().
>
> Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
> Acked-by: Tony Lindgren <tony@atomide.com>
Patch applied to wireless-drivers-next.git, thanks.
9604617e998b wlcore: fix runtime pm imbalance in wl1271_tx_work
--
https://patchwork.kernel.org/patch/11560387/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-05-29 17:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-20 12:42 [PATCH] wlcore: fix runtime pm imbalance in wl1271_tx_work Dinghao Liu
2020-05-20 18:52 ` Tony Lindgren
2020-05-29 17:31 ` Kalle Valo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.