From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A75F9C433E0 for ; Wed, 20 May 2020 12:56:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 84F9E2070A for ; Wed, 20 May 2020 12:56:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="mdHLn9n+" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726964AbgETM4P (ORCPT ); Wed, 20 May 2020 08:56:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41642 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726903AbgETM4O (ORCPT ); Wed, 20 May 2020 08:56:14 -0400 Received: from mail-qv1-xf2b.google.com (mail-qv1-xf2b.google.com [IPv6:2607:f8b0:4864:20::f2b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 65F45C061A0E for ; Wed, 20 May 2020 05:56:14 -0700 (PDT) Received: by mail-qv1-xf2b.google.com with SMTP id p4so1220120qvr.10 for ; Wed, 20 May 2020 05:56:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=IokNJFjTtmaZ7K4MBG6Rh51PQnmU94xpcqHKEHyK7kM=; b=mdHLn9n+V4RPq21TRcXf4ZofynyeTmnT/OpQcmKgeAZVz946tjFqzIpvVKQxVONELN yJPRGKT3YYrLMTsyGzplqFOzZ9CVuPNmcjVmcV+P17r1jbfZdCNnMN9pDAjp/g0ltBH3 yCBT+6Hu9dddScgJACDEk6PSvVovTpeH2KMg9suiDk6dpTLhkzFrPXgaDgA1MmvA+Wbg c+KL1WEjMPAazQ1B0Poj5pi6Q0w6JFVNU1bD0pnax2J+kqa3nPDrhXKD1pcPm943lFYQ A5xVWdlEvC/XgLE9wsnTu0xYt8GCxwP9uofHLERm/ay38pD2+HX5G/XEhv3xjhF702Wl cA7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=IokNJFjTtmaZ7K4MBG6Rh51PQnmU94xpcqHKEHyK7kM=; b=eMUqCxaCsKcmmZ3Pa+4fw/OQS6QQO10pUmGKGVXZpOnDR3Ho5TNFTfyTj/iVYV9LiQ StxNxdERdwiNidYAJloOSQdzMO0XdfREhXt2bqzCRkXBS8EhnIMbZ5pPwHrj9eYsR1fz cdzwMaLXHMbzL6fCCzwB+G2r3pskKmoUv8dt/OVWii37nQzZjsKXn3vPQBYdGZjoS3fL CzQkyQz2HW9SboxxrSJlLIHEWL2iseqUb8jSvQYWTy3GC51df+7fHyPo7YWNj2JauvjY ybbqUHR2IWnb4YUWjab9UEe72IPXQy6+B0zd+cahYHYvuJmEDpgpCAKSHfQfhqVz/9F6 9k3w== X-Gm-Message-State: AOAM531KhCqiFW/wPAVH9I9U6kDNNvenlclUIJ9rS26DS5pwgZgAH38Q nVIOy40cx12h/Om8mNSXxWZzTA== X-Google-Smtp-Source: ABdhPJw/TBxogwmsHQpfJybpr088jEbVeKMKR+iUAF9xj47O8wYEKonN8llw69IAIu85e00zIe+RZg== X-Received: by 2002:a0c:fd24:: with SMTP id i4mr4625190qvs.69.1589979372928; Wed, 20 May 2020 05:56:12 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-156-34-48-30.dhcp-dynamic.fibreop.ns.bellaliant.net. [156.34.48.30]) by smtp.gmail.com with ESMTPSA id g26sm2372719qtk.76.2020.05.20.05.56.12 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 20 May 2020 05:56:12 -0700 (PDT) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1jbOGZ-0006An-Q0; Wed, 20 May 2020 09:56:11 -0300 Date: Wed, 20 May 2020 09:56:11 -0300 From: Jason Gunthorpe To: Jeff Kirsher Cc: davem@davemloft.net, gregkh@linuxfoundation.org, Ranjani Sridharan , netdev@vger.kernel.org, linux-rdma@vger.kernel.org, nhorman@redhat.com, sassmann@redhat.com, pierre-louis.bossart@linux.intel.com, Fred Oh Subject: Re: [net-next v4 11/12] ASoC: SOF: Create client driver for IPC test Message-ID: <20200520125611.GI31189@ziepe.ca> References: <20200520070227.3392100-1-jeffrey.t.kirsher@intel.com> <20200520070227.3392100-12-jeffrey.t.kirsher@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200520070227.3392100-12-jeffrey.t.kirsher@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Wed, May 20, 2020 at 12:02:26AM -0700, Jeff Kirsher wrote: > +static const struct virtbus_dev_id sof_ipc_virtbus_id_table[] = { > + {"sof-ipc-test"}, > + {}, > +}; > + > +static struct sof_client_drv sof_ipc_test_client_drv = { > + .name = "sof-ipc-test-client-drv", > + .type = SOF_CLIENT_IPC, > + .virtbus_drv = { > + .driver = { > + .name = "sof-ipc-test-virtbus-drv", > + }, > + .id_table = sof_ipc_virtbus_id_table, > + .probe = sof_ipc_test_probe, > + .remove = sof_ipc_test_remove, > + .shutdown = sof_ipc_test_shutdown, > + }, > +}; > + > +module_sof_client_driver(sof_ipc_test_client_drv); > + > +MODULE_DESCRIPTION("SOF IPC Test Client Driver"); > +MODULE_LICENSE("GPL v2"); > +MODULE_IMPORT_NS(SND_SOC_SOF_CLIENT); > +MODULE_ALIAS("virtbus:sof-ipc-test"); Usually the MODULE_ALIAS happens automatically rhough the struct virtbus_dev_id - is something missing in the enabling patches? JAson