From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C6C7C433DF for ; Wed, 20 May 2020 14:18:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 75442207F9 for ; Wed, 20 May 2020 14:18:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726452AbgETOSf (ORCPT ); Wed, 20 May 2020 10:18:35 -0400 Received: from verein.lst.de ([213.95.11.211]:50062 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726436AbgETOSf (ORCPT ); Wed, 20 May 2020 10:18:35 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 9508368C4E; Wed, 20 May 2020 16:18:30 +0200 (CEST) Date: Wed, 20 May 2020 16:18:30 +0200 From: Christoph Hellwig To: Joe Perches Cc: Christoph Hellwig , "David S. Miller" , Jakub Kicinski , Eric Dumazet , Alexey Kuznetsov , Hideaki YOSHIFUJI , Vlad Yasevich , Neil Horman , Marcelo Ricardo Leitner , Jon Maloy , Ying Xue , drbd-dev@lists.linbit.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, linux-nvme@lists.infradead.org, target-devel@vger.kernel.org, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, cluster-devel@redhat.com, ocfs2-devel@oss.oracle.com, netdev@vger.kernel.org, linux-sctp@vger.kernel.org, ceph-devel@vger.kernel.org, rds-devel@oss.oracle.com, linux-nfs@vger.kernel.org Subject: Re: [PATCH 20/33] ipv4: add ip_sock_set_recverr Message-ID: <20200520141830.GA28867@lst.de> References: <20200513062649.2100053-1-hch@lst.de> <20200513062649.2100053-21-hch@lst.de> <0ee5acfaca4cf32d4efad162046b858981a4dae3.camel@perches.com> <20200514103025.GB12680@lst.de> <9992a1fe768a0b1e9bb9470d2728ba25dbe042db.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9992a1fe768a0b1e9bb9470d2728ba25dbe042db.camel@perches.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Thu, May 14, 2020 at 04:51:26AM -0700, Joe Perches wrote: > > Mostly to keep it symmetric with the sockopt. I could probably remove > > a few arguments in the series if we want to be strict. > > My preference would use strict and add > arguments only when necessary. In a few cases that would create confusion as the arguments are rather overloaded. But for a lot of the cases where it doesn't and there isn't really much use for other arguments I've done that now. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Date: Wed, 20 May 2020 14:18:30 +0000 Subject: Re: [PATCH 20/33] ipv4: add ip_sock_set_recverr Message-Id: <20200520141830.GA28867@lst.de> List-Id: References: <20200513062649.2100053-1-hch@lst.de> <20200513062649.2100053-21-hch@lst.de> <0ee5acfaca4cf32d4efad162046b858981a4dae3.camel@perches.com> <20200514103025.GB12680@lst.de> <9992a1fe768a0b1e9bb9470d2728ba25dbe042db.camel@perches.com> In-Reply-To: <9992a1fe768a0b1e9bb9470d2728ba25dbe042db.camel-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Joe Perches Cc: Marcelo Ricardo Leitner , linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Eric Dumazet , target-devel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-afs-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, drbd-dev-cunTk1MwBs8qoQakbn7OcQ@public.gmane.org, linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, rds-devel-N0ozoZBvEnrZJqsBc5GL+g@public.gmane.org, linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Christoph Hellwig , cluster-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, Alexey Kuznetsov , linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Jakub Kicinski , ceph-devel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Neil Horman , Hideaki YOSHIFUJI , netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Vlad Yasevich , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Jon Maloy , linux-sctp-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Ying Xue , "David S. Miller" , ocfs2-devel-N0ozoZBvEnrZJqsBc5GL+g@public.gmane.org On Thu, May 14, 2020 at 04:51:26AM -0700, Joe Perches wrote: > > Mostly to keep it symmetric with the sockopt. I could probably remove > > a few arguments in the series if we want to be strict. > > My preference would use strict and add > arguments only when necessary. In a few cases that would create confusion as the arguments are rather overloaded. But for a lot of the cases where it doesn't and there isn't really much use for other arguments I've done that now. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 20/33] ipv4: add ip_sock_set_recverr Date: Wed, 20 May 2020 16:18:30 +0200 Message-ID: <20200520141830.GA28867@lst.de> References: <20200513062649.2100053-1-hch@lst.de> <20200513062649.2100053-21-hch@lst.de> <0ee5acfaca4cf32d4efad162046b858981a4dae3.camel@perches.com> <20200514103025.GB12680@lst.de> <9992a1fe768a0b1e9bb9470d2728ba25dbe042db.camel@perches.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <9992a1fe768a0b1e9bb9470d2728ba25dbe042db.camel-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: drbd-dev-bounces-cunTk1MwBs8qoQakbn7OcQ@public.gmane.org Errors-To: drbd-dev-bounces-cunTk1MwBs8qoQakbn7OcQ@public.gmane.org To: Joe Perches Cc: Marcelo Ricardo Leitner , linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Eric Dumazet , target-devel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-afs-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, drbd-dev-cunTk1MwBs8qoQakbn7OcQ@public.gmane.org, linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, rds-devel-N0ozoZBvEnrZJqsBc5GL+g@public.gmane.org, linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Christoph Hellwig , cluster-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, Alexey Kuznetsov , linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Jakub Kicinski , ceph-devel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Neil Horman , Hideaki YOSHIFUJI , netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Vlad Yasevich , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Jon Maloy , linux-sctp-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Ying Xue , "David S. Miller" , ocfs2-devel-N0ozoZBvEnrZJqsBc5GL+g@public.gmane.org List-Id: ceph-devel.vger.kernel.org On Thu, May 14, 2020 at 04:51:26AM -0700, Joe Perches wrote: > > Mostly to keep it symmetric with the sockopt. I could probably remove > > a few arguments in the series if we want to be strict. > > My preference would use strict and add > arguments only when necessary. In a few cases that would create confusion as the arguments are rather overloaded. But for a lot of the cases where it doesn't and there isn't really much use for other arguments I've done that now. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A99BBC433E1 for ; Wed, 20 May 2020 14:18:42 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7C1C720756 for ; Wed, 20 May 2020 14:18:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="pCnlIbOa" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7C1C720756 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0pdMPwnDHIJAaI8tpaehVVzfrYiHGdyOCpW5X3nv420=; b=pCnlIbOaJM/2Rj acaESZHl4qMe3JkBXx9FljIz2SZXKZXvFZEZGB+azOaRfM/5LEb/EhHh/5EKoHP6UFDuCLooHaUH/ LJKu6WLFMFIZ4ptlwB7gfxTmBigjF/JQX8Jb0Mr/3FFx8RncVFf1FTq6T3dG/U1gDmarYo3U5Vo6p 26JkHYxC39ol6Zl/oceMrbyXgCCjOS3HhfeyYTyHsTsCsLoCGwYocnvEeuStJde2lHt/Lx1xs6zA9 HxqZnyvgpAPFsbcMccoMVzB+Igadq4mvuY86/g/wrbv3fmaXiQ+sYrmzWMI0Ay3B/ki1bdwggMjOY vTCUfh3wxxslYewMPiHQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jbPYL-0004NG-As; Wed, 20 May 2020 14:18:37 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jbPYI-0004Mo-3F; Wed, 20 May 2020 14:18:36 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 9508368C4E; Wed, 20 May 2020 16:18:30 +0200 (CEST) Date: Wed, 20 May 2020 16:18:30 +0200 From: Christoph Hellwig To: Joe Perches Subject: Re: [PATCH 20/33] ipv4: add ip_sock_set_recverr Message-ID: <20200520141830.GA28867@lst.de> References: <20200513062649.2100053-1-hch@lst.de> <20200513062649.2100053-21-hch@lst.de> <0ee5acfaca4cf32d4efad162046b858981a4dae3.camel@perches.com> <20200514103025.GB12680@lst.de> <9992a1fe768a0b1e9bb9470d2728ba25dbe042db.camel@perches.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <9992a1fe768a0b1e9bb9470d2728ba25dbe042db.camel@perches.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200520_071834_825703_1B33F7E3 X-CRM114-Status: UNSURE ( 8.74 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marcelo Ricardo Leitner , linux-nvme@lists.infradead.org, Eric Dumazet , target-devel@vger.kernel.org, linux-afs@lists.infradead.org, drbd-dev@lists.linbit.com, linux-cifs@vger.kernel.org, rds-devel@oss.oracle.com, linux-rdma@vger.kernel.org, Christoph Hellwig , cluster-devel@redhat.com, Alexey Kuznetsov , linux-block@vger.kernel.org, Jakub Kicinski , ceph-devel@vger.kernel.org, linux-nfs@vger.kernel.org, Neil Horman , Hideaki YOSHIFUJI , netdev@vger.kernel.org, Vlad Yasevich , linux-kernel@vger.kernel.org, Jon Maloy , linux-sctp@vger.kernel.org, Ying Xue , "David S. Miller" , ocfs2-devel@oss.oracle.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Thu, May 14, 2020 at 04:51:26AM -0700, Joe Perches wrote: > > Mostly to keep it symmetric with the sockopt. I could probably remove > > a few arguments in the series if we want to be strict. > > My preference would use strict and add > arguments only when necessary. In a few cases that would create confusion as the arguments are rather overloaded. But for a lot of the cases where it doesn't and there isn't really much use for other arguments I've done that now. _______________________________________________ linux-nvme mailing list linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Date: Wed, 20 May 2020 16:18:30 +0200 Subject: [Ocfs2-devel] [PATCH 20/33] ipv4: add ip_sock_set_recverr In-Reply-To: <9992a1fe768a0b1e9bb9470d2728ba25dbe042db.camel@perches.com> References: <20200513062649.2100053-1-hch@lst.de> <20200513062649.2100053-21-hch@lst.de> <0ee5acfaca4cf32d4efad162046b858981a4dae3.camel@perches.com> <20200514103025.GB12680@lst.de> <9992a1fe768a0b1e9bb9470d2728ba25dbe042db.camel@perches.com> Message-ID: <20200520141830.GA28867@lst.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Joe Perches Cc: Marcelo Ricardo Leitner , linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Eric Dumazet , target-devel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-afs-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, drbd-dev-cunTk1MwBs8qoQakbn7OcQ@public.gmane.org, linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, rds-devel-N0ozoZBvEnrZJqsBc5GL+g@public.gmane.org, linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Christoph Hellwig , cluster-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, Alexey Kuznetsov , linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Jakub Kicinski , ceph-devel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Neil Horman , Hideaki YOSHIFUJI , netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Vlad Yasevich , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Jon Maloy , linux-sctp-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Ying Xue , "David S. Miller" , ocfs2-devel-N0ozoZBvEnrZJqsBc5GL+g@public.gmane.org On Thu, May 14, 2020 at 04:51:26AM -0700, Joe Perches wrote: > > Mostly to keep it symmetric with the sockopt. I could probably remove > > a few arguments in the series if we want to be strict. > > My preference would use strict and add > arguments only when necessary. In a few cases that would create confusion as the arguments are rather overloaded. But for a lot of the cases where it doesn't and there isn't really much use for other arguments I've done that now. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Date: Wed, 20 May 2020 16:18:30 +0200 Subject: [Cluster-devel] [PATCH 20/33] ipv4: add ip_sock_set_recverr In-Reply-To: <9992a1fe768a0b1e9bb9470d2728ba25dbe042db.camel@perches.com> References: <20200513062649.2100053-1-hch@lst.de> <20200513062649.2100053-21-hch@lst.de> <0ee5acfaca4cf32d4efad162046b858981a4dae3.camel@perches.com> <20200514103025.GB12680@lst.de> <9992a1fe768a0b1e9bb9470d2728ba25dbe042db.camel@perches.com> Message-ID: <20200520141830.GA28867@lst.de> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Thu, May 14, 2020 at 04:51:26AM -0700, Joe Perches wrote: > > Mostly to keep it symmetric with the sockopt. I could probably remove > > a few arguments in the series if we want to be strict. > > My preference would use strict and add > arguments only when necessary. In a few cases that would create confusion as the arguments are rather overloaded. But for a lot of the cases where it doesn't and there isn't really much use for other arguments I've done that now.