From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE9EAC433DF for ; Wed, 20 May 2020 19:55:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9C71C207D8 for ; Wed, 20 May 2020 19:55:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="cbkIc8th" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727832AbgETTzG (ORCPT ); Wed, 20 May 2020 15:55:06 -0400 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:46748 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727777AbgETTy7 (ORCPT ); Wed, 20 May 2020 15:54:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1590004498; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YlmaPorpUfk0LyHLjpz8ECWgtfRwz0meVMatr+tCCfg=; b=cbkIc8th65IDmrQY6oDUGDYnISgwQR2F+fYn1tsvOV9RFFLoQ8nQv8wijGCWtwIHp1V1h9 Hyd29vzAo5nazUVkNA5dQhFfTcbH/XOrBNjJBWxjwpZO2JPV+6IvInH9AdCEVnhCI5Zg9g V6iP8r3yX3W+vvBSh3vHDR/N0Ic4a3s= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-324-lyoAV6g-Pc2OokrTDYLvyA-1; Wed, 20 May 2020 15:54:53 -0400 X-MC-Unique: lyoAV6g-Pc2OokrTDYLvyA-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DBBCF80183C; Wed, 20 May 2020 19:54:52 +0000 (UTC) Received: from x1.localdomain.com (ovpn-112-91.ams2.redhat.com [10.36.112.91]) by smtp.corp.redhat.com (Postfix) with ESMTP id EE17D6E9E7; Wed, 20 May 2020 19:54:51 +0000 (UTC) From: Hans de Goede To: Arnd Bergmann , Greg Kroah-Hartman Cc: Hans de Goede , linux-kernel@vger.kernel.org Subject: [PATCH 7/8] virt: vbox: Log unknown ioctl requests as error Date: Wed, 20 May 2020 21:54:39 +0200 Message-Id: <20200520195440.38759-7-hdegoede@redhat.com> In-Reply-To: <20200520195440.38759-1-hdegoede@redhat.com> References: <20200520195440.38759-1-hdegoede@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Every now and then upstream adds new ioctls without notifying us, log unknown ioctl requests as an error to catch these. Signed-off-by: Hans de Goede --- drivers/virt/vboxguest/vboxguest_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/virt/vboxguest/vboxguest_core.c b/drivers/virt/vboxguest/vboxguest_core.c index ffd76b949276..e0e343d0ba93 100644 --- a/drivers/virt/vboxguest/vboxguest_core.c +++ b/drivers/virt/vboxguest/vboxguest_core.c @@ -1739,7 +1739,7 @@ int vbg_core_ioctl(struct vbg_session *session, unsigned int req, void *data) return vbg_ioctl_log(data); } - vbg_debug("VGDrvCommonIoCtl: Unknown req %#08x\n", req); + vbg_err("Userspace made an unknown ioctl req %#08x\n", req); return -ENOTTY; } -- 2.26.2