From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C2AAC433E0 for ; Wed, 20 May 2020 20:34:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2B9E020829 for ; Wed, 20 May 2020 20:34:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590006853; bh=nrhqiPlqg0n1hAE/O/a+UV4rvWhhKR/jrI3wT+HPdB4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=jjF+Z61CjyF77ct8sPtpW1BFLk2ekcNUwxbS5hyfs3YV1Cr6TnR10J5/GeTpGlJoD ZR5DtIORna9VzNLtukCtUctS3mgp4IYShEDaQXd1wVh5BKyjX4stSwmAjsc2keIP2s DZplSoI3FjS1VA0Ph20xVhRDVGrqfkuBESXYIkso= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728007AbgETUeM (ORCPT ); Wed, 20 May 2020 16:34:12 -0400 Received: from mail.kernel.org ([198.145.29.99]:38022 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726860AbgETUeM (ORCPT ); Wed, 20 May 2020 16:34:12 -0400 Received: from quaco.ghostprotocols.net (unknown [179.97.37.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 766D3207E8; Wed, 20 May 2020 20:34:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590006851; bh=nrhqiPlqg0n1hAE/O/a+UV4rvWhhKR/jrI3wT+HPdB4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fnETanLGKttjkEDsIOkbvEpJYimeA18NjKziM8drdxMbWqnxJRwv2z9bJPmHYy4OX Qymq55cxN+8xS9TpqOtAcsZqHbC9oKnawEEkLKBjb/yGVzqJj8DHvUu7N1CNgXjWcC FPJnGkx5GKum6HTnpGaHQ3qI28qCOx5Zb6erqtF4= Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 7029A40AFD; Wed, 20 May 2020 17:34:09 -0300 (-03) Date: Wed, 20 May 2020 17:34:09 -0300 From: Arnaldo Carvalho de Melo To: Ian Rogers Cc: Jiri Olsa , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Namhyung Kim , Song Liu , Andrii Nakryiko , Kajol Jain , Andi Kleen , John Garry , Jin Yao , Kan Liang , Cong Wang , Kim Phillips , Paul Clarke , Srikar Dronamraju , LKML , Networking , bpf , linux-perf-users , Vince Weaver , Stephane Eranian Subject: Re: [PATCH 3/7] perf metricgroup: Delay events string creation Message-ID: <20200520203409.GA26877@kernel.org> References: <20200520072814.128267-1-irogers@google.com> <20200520072814.128267-4-irogers@google.com> <20200520131412.GK157452@krava> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Url: http://acmel.wordpress.com Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Wed, May 20, 2020 at 11:22:22AM -0700, Ian Rogers escreveu: > On Wed, May 20, 2020 at 6:14 AM Jiri Olsa wrote: > > > break; > > > } > > > } > > > + if (!ret) { > > > > could you please do instead: > > > > if (ret) > > return ret; > > > > so the code below cuts down one indent level and you > > don't need to split up the lines > > Done, broken out as a separate patch in v2: > https://lore.kernel.org/lkml/20200520182011.32236-3-irogers@google.com/ Jiri, was this the only issue with this patchkit? I've merged already the first one, that you acked. - Arnaldo From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnaldo Carvalho de Melo Subject: Re: [PATCH 3/7] perf metricgroup: Delay events string creation Date: Wed, 20 May 2020 17:34:09 -0300 Message-ID: <20200520203409.GA26877@kernel.org> References: <20200520072814.128267-1-irogers@google.com> <20200520072814.128267-4-irogers@google.com> <20200520131412.GK157452@krava> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Ian Rogers Cc: Jiri Olsa , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Namhyung Kim , Song Liu , Andrii Nakryiko , Kajol Jain , Andi Kleen , John Garry , Jin Yao , Kan Liang , Cong Wang , Kim Phillips , Paul Clarke , Srikar Dronamraju , LKML , Networking , bpf , linux-perf-users List-Id: linux-perf-users.vger.kernel.org Em Wed, May 20, 2020 at 11:22:22AM -0700, Ian Rogers escreveu: > On Wed, May 20, 2020 at 6:14 AM Jiri Olsa wrote: > > > break; > > > } > > > } > > > + if (!ret) { > > > > could you please do instead: > > > > if (ret) > > return ret; > > > > so the code below cuts down one indent level and you > > don't need to split up the lines > > Done, broken out as a separate patch in v2: > https://lore.kernel.org/lkml/20200520182011.32236-3-irogers@google.com/ Jiri, was this the only issue with this patchkit? I've merged already the first one, that you acked. - Arnaldo