From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D261C433E1 for ; Wed, 20 May 2020 21:36:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 39C3320823 for ; Wed, 20 May 2020 21:36:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590010589; bh=B8AOE3JtwFqfI8heLJhAGRimdEMlgMFaNzfEWB7Gsgw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=ukJVR29vhX5CN2I8sXhYI7+0CoTqtO+7nzzzt5Eqjb+EAyW0bMWW9skUd6Tzprae3 ZElFiBwvgZ0Qj16oBysqve6/zGSFMmZ1XUfWePGnxxPxGS6+2Jol01c5tM8WMRQcBW OdH9lymcVdNAZKXTbCI2euMdEIMCPZdyWLcnST8U= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728408AbgETVg2 (ORCPT ); Wed, 20 May 2020 17:36:28 -0400 Received: from mail-il1-f196.google.com ([209.85.166.196]:46712 "EHLO mail-il1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726892AbgETVg2 (ORCPT ); Wed, 20 May 2020 17:36:28 -0400 Received: by mail-il1-f196.google.com with SMTP id w18so4818142ilm.13; Wed, 20 May 2020 14:36:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=8T4g3GB0lWcH8xbCNMCDr7nb5rGktxITHYP2LXpYD7U=; b=fHp3Rm78Y4sM2pPVFXIH36Be3VSR1LsRH1Qf0LvJU0M6GsnBCFqUvGIa0bSXsYETd9 P1yKWp3oTrsqQI8XIrVP8UTh5lfSdR5Sk/3hqZW3dLXMf/frOIubyCHwCTrOqS8c4yci +i+JCc+p1q1z+nf+UquYCbVu+mDxTiCtzrTijv787iavYe2SzvOPx1uNeK2wABRC2Kh4 w+Zfohx4I60F3J+3jNPikK7Xek4SE27cXgIT0bSLi6RhTACJrAcOhvuP86XuMjwgjkTn 42Q0C83Sl/lSoHfkphLWvEufOIViJLRPF6xCqcOxmfmfN2yuA4ajxQRZFr+je9xo1cJg ofLQ== X-Gm-Message-State: AOAM531H88jzM5glLABPHBDAWfeDRfzQxGJFKixfpIVfH8GxFNcRAUJP HV0qi9Qq94Lo1K+r8wO6Mg== X-Google-Smtp-Source: ABdhPJzV5M0ADtcekTIkjw5B3x+zFszJSje5GETuQ1ENBcHHP7QvRIraFBSdGvUoBihkMjoJKyqrIw== X-Received: by 2002:a92:8989:: with SMTP id w9mr5962127ilk.70.1590010587012; Wed, 20 May 2020 14:36:27 -0700 (PDT) Received: from xps15 ([64.188.179.252]) by smtp.gmail.com with ESMTPSA id c7sm1977822ilf.36.2020.05.20.14.36.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 May 2020 14:36:26 -0700 (PDT) Received: (nullmailer pid 636061 invoked by uid 1000); Wed, 20 May 2020 21:36:25 -0000 Date: Wed, 20 May 2020 15:36:25 -0600 From: Rob Herring To: Kishon Vijay Abraham I Cc: Bjorn Helgaas , Lorenzo Pieralisi , Arnd Bergmann , Tom Joseph , Greg Kroah-Hartman , linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v4 08/14] PCI: cadence: Fix updating Vendor ID and Subsystem Vendor ID register Message-ID: <20200520213625.GA633506@bogus> References: <20200506151429.12255-1-kishon@ti.com> <20200506151429.12255-9-kishon@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200506151429.12255-9-kishon@ti.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 06, 2020 at 08:44:23PM +0530, Kishon Vijay Abraham I wrote: > Commit 1b79c5284439 ("PCI: cadence: Add host driver for Cadence PCIe > controller") in order to update Vendor ID, directly wrote to > PCI_VENDOR_ID register. However PCI_VENDOR_ID in root port configuration > space is read-only register and writing to it will have no effect. > Use local management register to configure Vendor ID and Subsystem Vendor > ID. > > Fixes: 1b79c5284439 ("PCI: cadence: Add host driver for Cadence PCIe controller") Fixes should come first. > Signed-off-by: Kishon Vijay Abraham I > --- > drivers/pci/controller/cadence/pcie-cadence-host.c | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) Reviewed-by: Rob Herring From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C9AFC433E0 for ; Wed, 20 May 2020 21:36:31 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2FD362065F for ; Wed, 20 May 2020 21:36:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="BZR1JNIJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2FD362065F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DUFhIk26zfdM/r7ewxYioHAtMwgZYX2CIT8anwlrdVY=; b=BZR1JNIJqQYgtG fNth8q2nYX6M3h72KLpW/Yl2pciStLZsi63IgKkN8pPQJwH2iKmHZc8o96nVRNw4EYBROqRLrHMkD muh8cB2zHWT8S/OGrPscjik2FdN5UcwxqyFGiEiBaDYuQCW4viFGW/J5nSt/kT3s4BOWqqKQpK4ZH 5vXPw8FUyE0p99NRCu4EY1a7IHiImvsfPzKVSXxKZ/7Pr5LDY6gY7TX/Auo7FAgLulrBtQGM+Zi6P idlfMX36BrWyCO8x/ZXRR+RSZhxnpV4zbPj7ZQ7QooNy1Qv1SMhC4YoCmNoXFjnZHlMCAQWhsCvSj ma/Xb/J2He4eU/lz4fZA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jbWO5-0007On-Ur; Wed, 20 May 2020 21:36:29 +0000 Received: from mail-il1-f193.google.com ([209.85.166.193]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jbWO3-0007OE-Ko for linux-arm-kernel@lists.infradead.org; Wed, 20 May 2020 21:36:28 +0000 Received: by mail-il1-f193.google.com with SMTP id b15so4834699ilq.12 for ; Wed, 20 May 2020 14:36:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=8T4g3GB0lWcH8xbCNMCDr7nb5rGktxITHYP2LXpYD7U=; b=A+uyu48mHbPfKDFFwCbsoU5QCUS7djcARtjOVPyVq4hksVb2nO6otFMag3C/5tdG/Z Owd0tBtwE11224cfRNCYYXV0mDmcQS+uaKSSxJGnE89o8qySv+E4tS9JU5Hlk3cczzAv ZGHNSUL3GQsbSpSw4Cd0AgATVM0FIftUxgH020Y11+AOk/sAO4hLto3kcGNA/BfICCiC uS2GIgH00trtuP6Ikc5ikReEngxPBUQuOEgQls9mtrTIFNIoofZhZ/B5vnat5wQD37bc HF1ll3wjFtSctW2dSaxtIM+Trg77y+n/qEmbpCcp1Spn89rTFfdw/3eNYoTiyPYKuXzj bALg== X-Gm-Message-State: AOAM532vSj4MY0N63VV3CZUoTj4oGiQ/uOw0HQJ4OFjhGhnlI1DwYT2m 9IztxtZX2DOCq7NSu2p2pw== X-Google-Smtp-Source: ABdhPJzV5M0ADtcekTIkjw5B3x+zFszJSje5GETuQ1ENBcHHP7QvRIraFBSdGvUoBihkMjoJKyqrIw== X-Received: by 2002:a92:8989:: with SMTP id w9mr5962127ilk.70.1590010587012; Wed, 20 May 2020 14:36:27 -0700 (PDT) Received: from xps15 ([64.188.179.252]) by smtp.gmail.com with ESMTPSA id c7sm1977822ilf.36.2020.05.20.14.36.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 May 2020 14:36:26 -0700 (PDT) Received: (nullmailer pid 636061 invoked by uid 1000); Wed, 20 May 2020 21:36:25 -0000 Date: Wed, 20 May 2020 15:36:25 -0600 From: Rob Herring To: Kishon Vijay Abraham I Subject: Re: [PATCH v4 08/14] PCI: cadence: Fix updating Vendor ID and Subsystem Vendor ID register Message-ID: <20200520213625.GA633506@bogus> References: <20200506151429.12255-1-kishon@ti.com> <20200506151429.12255-9-kishon@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200506151429.12255-9-kishon@ti.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200520_143627_679800_B53BD2FE X-CRM114-Status: GOOD ( 11.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Lorenzo Pieralisi , Arnd Bergmann , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Tom Joseph , linux-pci@vger.kernel.org, Bjorn Helgaas , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, May 06, 2020 at 08:44:23PM +0530, Kishon Vijay Abraham I wrote: > Commit 1b79c5284439 ("PCI: cadence: Add host driver for Cadence PCIe > controller") in order to update Vendor ID, directly wrote to > PCI_VENDOR_ID register. However PCI_VENDOR_ID in root port configuration > space is read-only register and writing to it will have no effect. > Use local management register to configure Vendor ID and Subsystem Vendor > ID. > > Fixes: 1b79c5284439 ("PCI: cadence: Add host driver for Cadence PCIe controller") Fixes should come first. > Signed-off-by: Kishon Vijay Abraham I > --- > drivers/pci/controller/cadence/pcie-cadence-host.c | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) Reviewed-by: Rob Herring _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel