From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: + mm-add-comments-on-pglist_data-zones.patch added to -mm tree Date: Wed, 20 May 2020 15:55:50 -0700 Message-ID: <20200520225550.yShTRzMWZ%akpm@linux-foundation.org> References: <20200513175005.1f4839360c18c0238df292d1@linux-foundation.org> Reply-To: linux-kernel@vger.kernel.org Return-path: Received: from mail.kernel.org ([198.145.29.99]:33038 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728019AbgETWzw (ORCPT ); Wed, 20 May 2020 18:55:52 -0400 In-Reply-To: <20200513175005.1f4839360c18c0238df292d1@linux-foundation.org> Sender: mm-commits-owner@vger.kernel.org List-Id: mm-commits@vger.kernel.org To: akpm@linux-foundation.org, ben.widawsky@intel.com, mm-commits@vger.kernel.org The patch titled Subject: mm: add comments on pglist_data zones has been added to the -mm tree. Its filename is mm-add-comments-on-pglist_data-zones.patch This patch should soon appear at http://ozlabs.org/~akpm/mmots/broken-out/mm-add-comments-on-pglist_data-zones.patch and later at http://ozlabs.org/~akpm/mmotm/broken-out/mm-add-comments-on-pglist_data-zones.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/process/submit-checklist.rst when testing your code *** The -mm tree is included into linux-next and is updated there every 3-4 working days ------------------------------------------------------ From: Ben Widawsky Subject: mm: add comments on pglist_data zones While making other modifications it was easy to confuse the two struct members node_zones and node_zonelists. For those already familiar with the code, this might seem to be a silly patch, but it's quite helpful to disambiguate the similar-sounding fields While here, add a small comment on why nr_zones isn't simply MAX_NR_ZONES Link: http://lkml.kernel.org/r/20200520205443.2757414-1-ben.widawsky@intel.com Signed-off-by: Ben Widawsky Reviewed-by: Andrew Morton Signed-off-by: Andrew Morton --- include/linux/mmzone.h | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) --- a/include/linux/mmzone.h~mm-add-comments-on-pglist_data-zones +++ a/include/linux/mmzone.h @@ -665,9 +665,21 @@ struct deferred_split { * per-zone basis. */ typedef struct pglist_data { + /* + * node_zones contains just the zones for THIS node. Not all of the + * zones may be populated, but it is the full list. It is referenced by + * this node's node_zonelists as well as other node's node_zonelists. + */ struct zone node_zones[MAX_NR_ZONES]; + + /* + * node_zonelists contains references to all zones in all nodes. + * Generally the first zones will be references to this node's + * node_zones. + */ struct zonelist node_zonelists[MAX_ZONELISTS]; - int nr_zones; + + int nr_zones; /* number of populated zones in this node */ #ifdef CONFIG_FLAT_NODE_MEM_MAP /* means !SPARSEMEM */ struct page *node_mem_map; #ifdef CONFIG_PAGE_EXTENSION _ Patches currently in -mm which might be from ben.widawsky@intel.com are mm-add-comments-on-pglist_data-zones.patch