Hi Matt, Thank you for the patch! Yet something to improve: [auto build test ERROR on usb/usb-testing] [also build test ERROR on tty/tty-testing v5.7-rc6 next-20200519] [cannot apply to usb-serial/usb-next] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Matt-Jolly/USB-serial-qcserial-Add-DW5816e-QDL-support/20200521-020738 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing config: x86_64-allyesconfig (attached as .config) compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project e6658079aca6d971b4e9d7137a3a2ecbc9c34aec) reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install x86_64 cross compiling tool for clang build # apt-get install binutils-x86-64-linux-gnu # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kbuild test robot All errors (new ones prefixed by >>, old ones prefixed by <<): >> drivers/usb/serial/qcserial.c:176:29: error: expected '}' {DEVICE_SWI(0x413c, 0x81cb)), /* Dell Wireless 5816e QDL */ ^ drivers/usb/serial/qcserial.c:176:2: note: to match this '{' {DEVICE_SWI(0x413c, 0x81cb)), /* Dell Wireless 5816e QDL */ ^ 1 error generated. vim +176 drivers/usb/serial/qcserial.c 30 31 #define DEVICE_G1K(v, p) \ 32 USB_DEVICE(v, p), .driver_info = QCSERIAL_G1K 33 #define DEVICE_SWI(v, p) \ 34 USB_DEVICE(v, p), .driver_info = QCSERIAL_SWI 35 #define DEVICE_HWI(v, p) \ 36 USB_DEVICE(v, p), .driver_info = QCSERIAL_HWI 37 38 static const struct usb_device_id id_table[] = { 39 /* Gobi 1000 devices */ 40 {DEVICE_G1K(0x05c6, 0x9211)}, /* Acer Gobi QDL device */ 41 {DEVICE_G1K(0x05c6, 0x9212)}, /* Acer Gobi Modem Device */ 42 {DEVICE_G1K(0x03f0, 0x1f1d)}, /* HP un2400 Gobi Modem Device */ 43 {DEVICE_G1K(0x03f0, 0x201d)}, /* HP un2400 Gobi QDL Device */ 44 {DEVICE_G1K(0x04da, 0x250d)}, /* Panasonic Gobi Modem device */ 45 {DEVICE_G1K(0x04da, 0x250c)}, /* Panasonic Gobi QDL device */ 46 {DEVICE_G1K(0x413c, 0x8172)}, /* Dell Gobi Modem device */ 47 {DEVICE_G1K(0x413c, 0x8171)}, /* Dell Gobi QDL device */ 48 {DEVICE_G1K(0x1410, 0xa001)}, /* Novatel/Verizon USB-1000 */ 49 {DEVICE_G1K(0x1410, 0xa002)}, /* Novatel Gobi Modem device */ 50 {DEVICE_G1K(0x1410, 0xa003)}, /* Novatel Gobi Modem device */ 51 {DEVICE_G1K(0x1410, 0xa004)}, /* Novatel Gobi Modem device */ 52 {DEVICE_G1K(0x1410, 0xa005)}, /* Novatel Gobi Modem device */ 53 {DEVICE_G1K(0x1410, 0xa006)}, /* Novatel Gobi Modem device */ 54 {DEVICE_G1K(0x1410, 0xa007)}, /* Novatel Gobi Modem device */ 55 {DEVICE_G1K(0x1410, 0xa008)}, /* Novatel Gobi QDL device */ 56 {DEVICE_G1K(0x0b05, 0x1776)}, /* Asus Gobi Modem device */ 57 {DEVICE_G1K(0x0b05, 0x1774)}, /* Asus Gobi QDL device */ 58 {DEVICE_G1K(0x19d2, 0xfff3)}, /* ONDA Gobi Modem device */ 59 {DEVICE_G1K(0x19d2, 0xfff2)}, /* ONDA Gobi QDL device */ 60 {DEVICE_G1K(0x1557, 0x0a80)}, /* OQO Gobi QDL device */ 61 {DEVICE_G1K(0x05c6, 0x9001)}, /* Generic Gobi Modem device */ 62 {DEVICE_G1K(0x05c6, 0x9002)}, /* Generic Gobi Modem device */ 63 {DEVICE_G1K(0x05c6, 0x9202)}, /* Generic Gobi Modem device */ 64 {DEVICE_G1K(0x05c6, 0x9203)}, /* Generic Gobi Modem device */ 65 {DEVICE_G1K(0x05c6, 0x9222)}, /* Generic Gobi Modem device */ 66 {DEVICE_G1K(0x05c6, 0x9008)}, /* Generic Gobi QDL device */ 67 {DEVICE_G1K(0x05c6, 0x9009)}, /* Generic Gobi Modem device */ 68 {DEVICE_G1K(0x05c6, 0x9201)}, /* Generic Gobi QDL device */ 69 {DEVICE_G1K(0x05c6, 0x9221)}, /* Generic Gobi QDL device */ 70 {DEVICE_G1K(0x05c6, 0x9231)}, /* Generic Gobi QDL device */ 71 {DEVICE_G1K(0x1f45, 0x0001)}, /* Unknown Gobi QDL device */ 72 {DEVICE_G1K(0x1bc7, 0x900e)}, /* Telit Gobi QDL device */ 73 74 /* Gobi 2000 devices */ 75 {USB_DEVICE(0x1410, 0xa010)}, /* Novatel Gobi 2000 QDL device */ 76 {USB_DEVICE(0x1410, 0xa011)}, /* Novatel Gobi 2000 QDL device */ 77 {USB_DEVICE(0x1410, 0xa012)}, /* Novatel Gobi 2000 QDL device */ 78 {USB_DEVICE(0x1410, 0xa013)}, /* Novatel Gobi 2000 QDL device */ 79 {USB_DEVICE(0x1410, 0xa014)}, /* Novatel Gobi 2000 QDL device */ 80 {USB_DEVICE(0x413c, 0x8185)}, /* Dell Gobi 2000 QDL device (N0218, VU936) */ 81 {USB_DEVICE(0x413c, 0x8186)}, /* Dell Gobi 2000 Modem device (N0218, VU936) */ 82 {USB_DEVICE(0x05c6, 0x9208)}, /* Generic Gobi 2000 QDL device */ 83 {USB_DEVICE(0x05c6, 0x920b)}, /* Generic Gobi 2000 Modem device */ 84 {USB_DEVICE(0x05c6, 0x9224)}, /* Sony Gobi 2000 QDL device (N0279, VU730) */ 85 {USB_DEVICE(0x05c6, 0x9225)}, /* Sony Gobi 2000 Modem device (N0279, VU730) */ 86 {USB_DEVICE(0x05c6, 0x9244)}, /* Samsung Gobi 2000 QDL device (VL176) */ 87 {USB_DEVICE(0x05c6, 0x9245)}, /* Samsung Gobi 2000 Modem device (VL176) */ 88 {USB_DEVICE(0x03f0, 0x241d)}, /* HP Gobi 2000 QDL device (VP412) */ 89 {USB_DEVICE(0x03f0, 0x251d)}, /* HP Gobi 2000 Modem device (VP412) */ 90 {USB_DEVICE(0x05c6, 0x9214)}, /* Acer Gobi 2000 QDL device (VP413) */ 91 {USB_DEVICE(0x05c6, 0x9215)}, /* Acer Gobi 2000 Modem device (VP413) */ 92 {USB_DEVICE(0x05c6, 0x9264)}, /* Asus Gobi 2000 QDL device (VR305) */ 93 {USB_DEVICE(0x05c6, 0x9265)}, /* Asus Gobi 2000 Modem device (VR305) */ 94 {USB_DEVICE(0x05c6, 0x9234)}, /* Top Global Gobi 2000 QDL device (VR306) */ 95 {USB_DEVICE(0x05c6, 0x9235)}, /* Top Global Gobi 2000 Modem device (VR306) */ 96 {USB_DEVICE(0x05c6, 0x9274)}, /* iRex Technologies Gobi 2000 QDL device (VR307) */ 97 {USB_DEVICE(0x05c6, 0x9275)}, /* iRex Technologies Gobi 2000 Modem device (VR307) */ 98 {USB_DEVICE(0x1199, 0x9000)}, /* Sierra Wireless Gobi 2000 QDL device (VT773) */ 99 {USB_DEVICE(0x1199, 0x9001)}, /* Sierra Wireless Gobi 2000 Modem device (VT773) */ 100 {USB_DEVICE(0x1199, 0x9002)}, /* Sierra Wireless Gobi 2000 Modem device (VT773) */ 101 {USB_DEVICE(0x1199, 0x9003)}, /* Sierra Wireless Gobi 2000 Modem device (VT773) */ 102 {USB_DEVICE(0x1199, 0x9004)}, /* Sierra Wireless Gobi 2000 Modem device (VT773) */ 103 {USB_DEVICE(0x1199, 0x9005)}, /* Sierra Wireless Gobi 2000 Modem device (VT773) */ 104 {USB_DEVICE(0x1199, 0x9006)}, /* Sierra Wireless Gobi 2000 Modem device (VT773) */ 105 {USB_DEVICE(0x1199, 0x9007)}, /* Sierra Wireless Gobi 2000 Modem device (VT773) */ 106 {USB_DEVICE(0x1199, 0x9008)}, /* Sierra Wireless Gobi 2000 Modem device (VT773) */ 107 {USB_DEVICE(0x1199, 0x9009)}, /* Sierra Wireless Gobi 2000 Modem device (VT773) */ 108 {USB_DEVICE(0x1199, 0x900a)}, /* Sierra Wireless Gobi 2000 Modem device (VT773) */ 109 {USB_DEVICE(0x1199, 0x9011)}, /* Sierra Wireless Gobi 2000 Modem device (MC8305) */ 110 {USB_DEVICE(0x16d8, 0x8001)}, /* CMDTech Gobi 2000 QDL device (VU922) */ 111 {USB_DEVICE(0x16d8, 0x8002)}, /* CMDTech Gobi 2000 Modem device (VU922) */ 112 {USB_DEVICE(0x05c6, 0x9204)}, /* Gobi 2000 QDL device */ 113 {USB_DEVICE(0x05c6, 0x9205)}, /* Gobi 2000 Modem device */ 114 115 /* Gobi 3000 devices */ 116 {USB_DEVICE(0x03f0, 0x371d)}, /* HP un2430 Gobi 3000 QDL */ 117 {USB_DEVICE(0x05c6, 0x920c)}, /* Gobi 3000 QDL */ 118 {USB_DEVICE(0x05c6, 0x920d)}, /* Gobi 3000 Composite */ 119 {USB_DEVICE(0x1410, 0xa020)}, /* Novatel Gobi 3000 QDL */ 120 {USB_DEVICE(0x1410, 0xa021)}, /* Novatel Gobi 3000 Composite */ 121 {USB_DEVICE(0x413c, 0x8193)}, /* Dell Gobi 3000 QDL */ 122 {USB_DEVICE(0x413c, 0x8194)}, /* Dell Gobi 3000 Composite */ 123 {USB_DEVICE(0x413c, 0x81a6)}, /* Dell DW5570 QDL (MC8805) */ 124 {USB_DEVICE(0x1199, 0x68a4)}, /* Sierra Wireless QDL */ 125 {USB_DEVICE(0x1199, 0x68a5)}, /* Sierra Wireless Modem */ 126 {USB_DEVICE(0x1199, 0x68a8)}, /* Sierra Wireless QDL */ 127 {USB_DEVICE(0x1199, 0x68a9)}, /* Sierra Wireless Modem */ 128 {USB_DEVICE(0x1199, 0x9010)}, /* Sierra Wireless Gobi 3000 QDL */ 129 {USB_DEVICE(0x1199, 0x9012)}, /* Sierra Wireless Gobi 3000 QDL */ 130 {USB_DEVICE(0x1199, 0x9013)}, /* Sierra Wireless Gobi 3000 Modem device (MC8355) */ 131 {USB_DEVICE(0x1199, 0x9014)}, /* Sierra Wireless Gobi 3000 QDL */ 132 {USB_DEVICE(0x1199, 0x9015)}, /* Sierra Wireless Gobi 3000 Modem device */ 133 {USB_DEVICE(0x1199, 0x9018)}, /* Sierra Wireless Gobi 3000 QDL */ 134 {USB_DEVICE(0x1199, 0x9019)}, /* Sierra Wireless Gobi 3000 Modem device */ 135 {USB_DEVICE(0x1199, 0x901b)}, /* Sierra Wireless MC7770 */ 136 {USB_DEVICE(0x12D1, 0x14F0)}, /* Sony Gobi 3000 QDL */ 137 {USB_DEVICE(0x12D1, 0x14F1)}, /* Sony Gobi 3000 Composite */ 138 {USB_DEVICE(0x0AF0, 0x8120)}, /* Option GTM681W */ 139 140 /* non-Gobi Sierra Wireless devices */ 141 {DEVICE_SWI(0x03f0, 0x4e1d)}, /* HP lt4111 LTE/EV-DO/HSPA+ Gobi 4G Module */ 142 {DEVICE_SWI(0x0f3d, 0x68a2)}, /* Sierra Wireless MC7700 */ 143 {DEVICE_SWI(0x114f, 0x68a2)}, /* Sierra Wireless MC7750 */ 144 {DEVICE_SWI(0x1199, 0x68a2)}, /* Sierra Wireless MC7710 */ 145 {DEVICE_SWI(0x1199, 0x68c0)}, /* Sierra Wireless MC7304/MC7354 */ 146 {DEVICE_SWI(0x1199, 0x901c)}, /* Sierra Wireless EM7700 */ 147 {DEVICE_SWI(0x1199, 0x901e)}, /* Sierra Wireless EM7355 QDL */ 148 {DEVICE_SWI(0x1199, 0x901f)}, /* Sierra Wireless EM7355 */ 149 {DEVICE_SWI(0x1199, 0x9040)}, /* Sierra Wireless Modem */ 150 {DEVICE_SWI(0x1199, 0x9041)}, /* Sierra Wireless MC7305/MC7355 */ 151 {DEVICE_SWI(0x1199, 0x9051)}, /* Netgear AirCard 340U */ 152 {DEVICE_SWI(0x1199, 0x9053)}, /* Sierra Wireless Modem */ 153 {DEVICE_SWI(0x1199, 0x9054)}, /* Sierra Wireless Modem */ 154 {DEVICE_SWI(0x1199, 0x9055)}, /* Netgear AirCard 341U */ 155 {DEVICE_SWI(0x1199, 0x9056)}, /* Sierra Wireless Modem */ 156 {DEVICE_SWI(0x1199, 0x9060)}, /* Sierra Wireless Modem */ 157 {DEVICE_SWI(0x1199, 0x9061)}, /* Sierra Wireless Modem */ 158 {DEVICE_SWI(0x1199, 0x9063)}, /* Sierra Wireless EM7305 */ 159 {DEVICE_SWI(0x1199, 0x9070)}, /* Sierra Wireless MC74xx */ 160 {DEVICE_SWI(0x1199, 0x9071)}, /* Sierra Wireless MC74xx */ 161 {DEVICE_SWI(0x1199, 0x9078)}, /* Sierra Wireless EM74xx */ 162 {DEVICE_SWI(0x1199, 0x9079)}, /* Sierra Wireless EM74xx */ 163 {DEVICE_SWI(0x1199, 0x907a)}, /* Sierra Wireless EM74xx QDL */ 164 {DEVICE_SWI(0x1199, 0x907b)}, /* Sierra Wireless EM74xx */ 165 {DEVICE_SWI(0x1199, 0x9090)}, /* Sierra Wireless EM7565 QDL */ 166 {DEVICE_SWI(0x1199, 0x9091)}, /* Sierra Wireless EM7565 */ 167 {DEVICE_SWI(0x413c, 0x81a2)}, /* Dell Wireless 5806 Gobi(TM) 4G LTE Mobile Broadband Card */ 168 {DEVICE_SWI(0x413c, 0x81a3)}, /* Dell Wireless 5570 HSPA+ (42Mbps) Mobile Broadband Card */ 169 {DEVICE_SWI(0x413c, 0x81a4)}, /* Dell Wireless 5570e HSPA+ (42Mbps) Mobile Broadband Card */ 170 {DEVICE_SWI(0x413c, 0x81a8)}, /* Dell Wireless 5808 Gobi(TM) 4G LTE Mobile Broadband Card */ 171 {DEVICE_SWI(0x413c, 0x81a9)}, /* Dell Wireless 5808e Gobi(TM) 4G LTE Mobile Broadband Card */ 172 {DEVICE_SWI(0x413c, 0x81b1)}, /* Dell Wireless 5809e Gobi(TM) 4G LTE Mobile Broadband Card */ 173 {DEVICE_SWI(0x413c, 0x81b3)}, /* Dell Wireless 5809e Gobi(TM) 4G LTE Mobile Broadband Card (rev3) */ 174 {DEVICE_SWI(0x413c, 0x81b5)}, /* Dell Wireless 5811e QDL */ 175 {DEVICE_SWI(0x413c, 0x81b6)}, /* Dell Wireless 5811e QDL */ > 176 {DEVICE_SWI(0x413c, 0x81cb)), /* Dell Wireless 5816e QDL */ 177 {DEVICE_SWI(0x413c, 0x81cc)}, /* Dell Wireless 5816e */ 178 {DEVICE_SWI(0x413c, 0x81cf)}, /* Dell Wireless 5819 */ 179 {DEVICE_SWI(0x413c, 0x81d0)}, /* Dell Wireless 5819 */ 180 {DEVICE_SWI(0x413c, 0x81d1)}, /* Dell Wireless 5818 */ 181 {DEVICE_SWI(0x413c, 0x81d2)}, /* Dell Wireless 5818 */ 182 183 /* Huawei devices */ 184 {DEVICE_HWI(0x03f0, 0x581d)}, /* HP lt4112 LTE/HSPA+ Gobi 4G Modem (Huawei me906e) */ 185 186 { } /* Terminating entry */ 187 }; 188 MODULE_DEVICE_TABLE(usb, id_table); 189 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org