From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79CCBC433E0 for ; Thu, 21 May 2020 07:33:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4CC6520829 for ; Thu, 21 May 2020 07:33:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kroah.com header.i=@kroah.com header.b="mx+chKqv"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="ih1LyWBV" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728423AbgEUHd2 (ORCPT ); Thu, 21 May 2020 03:33:28 -0400 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]:57299 "EHLO wout2-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728408AbgEUHd2 (ORCPT ); Thu, 21 May 2020 03:33:28 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 763EBA0B; Thu, 21 May 2020 03:33:27 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 21 May 2020 03:33:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=tq2q+Ln4vL3TniRit7XmR2oQOVq CmRlGQR0GStHzfRE=; b=mx+chKqvn+Ua96JaDp770wsfjRCbhuBFbMA6n7tWya0 PUm0cZvClZfj300YGy52B48UeWJOWrx7s35EYvN8qgBpXcSXr05eIKL6GIhfsIEj gc1OBDJGmyh3KuRNekmP2R1DuVMQt1MAxTpdHTCdOn0eRBWEt/fJIEYq3JyGTCeF UII864FJrecBq9VBoDjgHyY6/gEatcMIhiAxOy5vD+J47LWwb7hFcp1uavBA/h6x DiR+EmMEZgAC5t5h+bqZkrG3W/Jr3uXcEO7iPx6Y3Q0Axq9zG01yfHlKNSa6OEiU Csy272dS+En/s6pUMKPp5qzgP++PX9YB+yDLmKo+lYw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=tq2q+L n4vL3TniRit7XmR2oQOVqCmRlGQR0GStHzfRE=; b=ih1LyWBVvphyJXi4YiW38i JxGv22D6MmO5nNV634TSZ6HX7R+RYbvbD6gjr7yHPzBbpGtauonuESnwBIQ3oJ+x 0tzGCu00Oi4hN1ZDDUyRhWTCIXhcR/RkqPVeArMc3Ske85Y40RDvQdlEdrM26HzI amAe0Mg1V+8snjy0afsbyBF3asKxvQr2VV2i8Y7MP9iOG3O/TLQMwOmpKKA93Doj YMCU9m1zysS7Et/bdZKB9MhnjAKA6NfCsaklKpN9Yu7YR1D6DvRGOLfSHPO0ObMG 3VWPynmfqG2FisngoaLL+LcyEd4tTHqwYBOFfMCKB4g074IDf4A+x6tMgxsi6YEA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedruddutddguddukecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepifhrvghg ucfmjfcuoehgrhgvgheskhhrohgrhhdrtghomheqnecuggftrfgrthhtvghrnhepveeuhe ejgfffgfeivddukedvkedtleelleeghfeljeeiueeggeevueduudekvdetnecukfhppeek fedrkeeirdekledruddtjeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmh grihhlfhhrohhmpehgrhgvgheskhhrohgrhhdrtghomh X-ME-Proxy: Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) by mail.messagingengine.com (Postfix) with ESMTPA id 399553066479; Thu, 21 May 2020 03:33:26 -0400 (EDT) Date: Thu, 21 May 2020 09:33:23 +0200 From: Greg KH To: Tetsuo Handa Cc: Colin Ian King , Oliver Neukum , Arnd Bergmann , linux-usb@vger.kernel.org Subject: Re: [PATCH] USB: cdc-wdm: Call wake_up_all() when clearing WDM_IN_USE bit. Message-ID: <20200521073323.GA2579717@kroah.com> References: <20200520233129.3704-1-penguin-kernel@I-love.SAKURA.ne.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200520233129.3704-1-penguin-kernel@I-love.SAKURA.ne.jp> Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Thu, May 21, 2020 at 08:31:29AM +0900, Tetsuo Handa wrote: > Since e.g. wdm_flush() calls wait_event() on WDM_IN_USE bit, > make sure to call wake_up_all() when clearing WDM_IN_USE bit. I'm sorry, but I don't understand what this changelog text is trying to say. Can you reword this differently? > > Signed-off-by: Tetsuo Handa And is this a bugfix? For what? Does it need to go to stable kernels? > --- > drivers/usb/class/cdc-wdm.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/class/cdc-wdm.c b/drivers/usb/class/cdc-wdm.c > index e3db6fbeadef..bf2a6deb7b08 100644 > --- a/drivers/usb/class/cdc-wdm.c > +++ b/drivers/usb/class/cdc-wdm.c > @@ -151,7 +151,7 @@ static void wdm_out_callback(struct urb *urb) > kfree(desc->outbuf); > desc->outbuf = NULL; > clear_bit(WDM_IN_USE, &desc->flags); > - wake_up(&desc->wait); > + wake_up_all(&desc->wait); > } > > static void wdm_in_callback(struct urb *urb) > @@ -426,6 +426,7 @@ static ssize_t wdm_write > clear_bit(WDM_IN_USE, &desc->flags); > dev_err(&desc->intf->dev, "Tx URB error: %d\n", rv); > rv = usb_translate_errors(rv); > + wake_up_all(&desc->wait); Is this a fix for two different issues? confused, greg k-h