From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Ben Hutchings <ben@decadent.org.uk>
Cc: Daniel Jordan <daniel.m.jordan@oracle.com>,
Sasha Levin <sashal@kernel.org>,
Herbert Xu <herbert@gondor.apana.org.au>,
Steffen Klassert <steffen.klassert@secunet.com>,
linux-crypto@vger.kernel.org, stable <stable@vger.kernel.org>
Subject: Re: Backporting "padata: Remove broken queue flushing"
Date: Thu, 21 May 2020 10:00:46 +0200 [thread overview]
Message-ID: <20200521080046.GA2615557@kroah.com> (raw)
In-Reply-To: <87267d7217e4a3d58440079c16d313e411eab004.camel@decadent.org.uk>
On Wed, May 20, 2020 at 03:33:44PM +0100, Ben Hutchings wrote:
> On Tue, 2020-05-19 at 16:00 -0400, Daniel Jordan wrote:
> > Hello Ben,
> >
> > On Tue, May 19, 2020 at 02:53:05PM +0100, Ben Hutchings wrote:
> > > I noticed that commit 07928d9bfc81 "padata: Remove broken queue
> > > flushing" has been backported to most stable branches, but commit
> > > 6fc4dbcf0276 "padata: Replace delayed timer with immediate workqueue in
> > > padata_reorder" has not.
> > >
> > > Is this correct? What prevents the parallel_data ref-count from
> > > dropping to 0 while the timer is scheduled?
> >
> > Doesn't seem like anything does, looking at 4.19.
>
> OK, so it looks like the following commits should be backported:
>
> [3.16-4.9] 119a0798dc42 padata: Remove unused but set variables
> [3.16] de5540d088fe padata: avoid race in reordering
> [3.16-4.9] 69b348449bda padata: get_next is never NULL
> [3.16-4.14] cf5868c8a22d padata: ensure the reorder timer callback runs on the correct CPU
> [3.16-4.14] 350ef88e7e92 padata: ensure padata_do_serial() runs on the correct CPU
These all applied cleanly to the needed trees, but these:
> [3.16-4.19] 6fc4dbcf0276 padata: Replace delayed timer with immediate workqueue in padata_reorder
> [3.16-4.19] ec9c7d19336e padata: initialize pd->cpu with effective cpumask
> [3.16-4.19] 065cf577135a padata: purge get_cpu and reorder_via_wq from padata_do_serial
Need some non-trivial backporting. Can you, or someone else do it so I
can queue them up? I don't have the free time at the moment, sorry.
thanks,
greg k-h
next prev parent reply other threads:[~2020-05-21 8:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-19 13:53 Backporting "padata: Remove broken queue flushing" Ben Hutchings
2020-05-19 20:00 ` Daniel Jordan
2020-05-20 14:33 ` Ben Hutchings
2020-05-21 8:00 ` Greg Kroah-Hartman [this message]
2020-05-21 13:32 ` Daniel Jordan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200521080046.GA2615557@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=ben@decadent.org.uk \
--cc=daniel.m.jordan@oracle.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.