Hi Maarten,

I love your patch! Yet something to improve:

[auto build test ERROR on drm-tip/drm-tip]
[cannot apply to drm-intel/for-linux-next v5.7-rc6 next-20200519]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Maarten-Lankhorst/Revert-drm-i915-gem-Drop-relocation-slowpath/20200521-030534
base:   git://anongit.freedesktop.org/drm/drm-tip drm-tip
config: x86_64-defconfig (attached as .config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>

All error/warnings (new ones prefixed by >>, old ones prefixed by <<):

In file included from arch/x86/include/asm/bug.h:83:0,
from include/linux/bug.h:5,
from include/linux/thread_info.h:12,
from arch/x86/include/asm/preempt.h:7,
from include/linux/preempt.h:78,
from include/linux/rcupdate.h:27,
from include/linux/rculist.h:11,
from include/linux/pid.h:5,
from include/linux/sched.h:14,
from include/linux/ratelimit.h:6,
from include/linux/dev_printk.h:16,
from include/linux/device.h:15,
from include/linux/pm_runtime.h:11,
from drivers/gpu/drm/i915/gt/intel_rc6.c:7:
drivers/gpu/drm/i915/i915_vma.h: In function 'i915_vma_pin':
>> include/linux/dma-resv.h:80:28: error: implicit declaration of function 'lockdep_is_held'; did you mean 'lockdep_assert_held'? [-Werror=implicit-function-declaration]
#define dma_resv_held(obj) lockdep_is_held(&(obj)->lock.base)
^
include/asm-generic/bug.h:151:27: note: in definition of macro 'WARN_ONCE'
int __ret_warn_once = !!(condition);                                 ^~~~~~~~~
>> drivers/gpu/drm/i915/i915_vma.h:245:2: note: in expansion of macro 'WARN_ON_ONCE'
WARN_ON_ONCE(vma->resv && dma_resv_held(vma->resv));
^~~~~~~~~~~~
>> drivers/gpu/drm/i915/i915_vma.h:245:28: note: in expansion of macro 'dma_resv_held'
WARN_ON_ONCE(vma->resv && dma_resv_held(vma->resv));
^~~~~~~~~~~~~
cc1: some warnings being treated as errors
--
In file included from arch/x86/include/asm/bug.h:83:0,
from include/linux/bug.h:5,
from include/linux/thread_info.h:12,
from arch/x86/include/asm/preempt.h:7,
from include/linux/preempt.h:78,
from include/linux/rcupdate.h:27,
from include/linux/rculist.h:11,
from include/linux/pid.h:5,
from include/linux/sched.h:14,
from include/linux/sched/mm.h:7,
from drivers/gpu/drm/i915/gem/i915_gem_object.c:25:
drivers/gpu/drm/i915/i915_vma.h: In function 'i915_vma_pin':
include/linux/dma-resv.h:80:28: error: implicit declaration of function 'lockdep_is_held'; did you mean 'lockdep_is_held_type'? [-Werror=implicit-function-declaration]
#define dma_resv_held(obj) lockdep_is_held(&(obj)->lock.base)
^
include/asm-generic/bug.h:151:27: note: in definition of macro 'WARN_ONCE'
int __ret_warn_once = !!(condition);                                 ^~~~~~~~~
>> drivers/gpu/drm/i915/i915_vma.h:245:2: note: in expansion of macro 'WARN_ON_ONCE'
WARN_ON_ONCE(vma->resv && dma_resv_held(vma->resv));
^~~~~~~~~~~~
>> drivers/gpu/drm/i915/i915_vma.h:245:28: note: in expansion of macro 'dma_resv_held'
WARN_ON_ONCE(vma->resv && dma_resv_held(vma->resv));
^~~~~~~~~~~~~
cc1: some warnings being treated as errors

vim +80 include/linux/dma-resv.h

786d7257e537da include/linux/reservation.h Maarten Lankhorst 2013-06-27  79  
52791eeec1d9f4 include/linux/dma-resv.h    Christian König   2019-08-11 @80  #define dma_resv_held(obj) lockdep_is_held(&(obj)->lock.base)
52791eeec1d9f4 include/linux/dma-resv.h    Christian König   2019-08-11  81  #define dma_resv_assert_held(obj) lockdep_assert_held(&(obj)->lock.base)
04a5faa8cbe5a8 include/linux/reservation.h Maarten Lankhorst 2014-07-01  82  

:::::: The code at line 80 was first introduced by commit
:::::: 52791eeec1d9f4a7e7fe08aaba0b1553149d93bc dma-buf: rename reservation_object to dma_resv

:::::: TO: Christian König <christian.koenig@amd.com>
:::::: CC: Christian König <christian.koenig@amd.com>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org