Hi Maarten,

I love your patch! Yet something to improve:

[auto build test ERROR on drm-tip/drm-tip]
[cannot apply to drm-intel/for-linux-next v5.7-rc6 next-20200519]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Maarten-Lankhorst/Revert-drm-i915-gem-Drop-relocation-slowpath/20200521-030534
base:   git://anongit.freedesktop.org/drm/drm-tip drm-tip
config: x86_64-defconfig (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project e6658079aca6d971b4e9d7137a3a2ecbc9c34aec)
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>, old ones prefixed by <<):

In file included from drivers/gpu/drm/i915/gt/intel_mocs.c:23:
In file included from drivers/gpu/drm/i915/i915_drv.h:82:
In file included from drivers/gpu/drm/i915/gt/intel_gt_types.h:16:
In file included from drivers/gpu/drm/i915/gt/uc/intel_uc.h:9:
In file included from drivers/gpu/drm/i915/gt/uc/intel_guc.h:17:
>> drivers/gpu/drm/i915/i915_vma.h:245:28: error: implicit declaration of function 'lockdep_is_held' [-Werror,-Wimplicit-function-declaration]
WARN_ON_ONCE(vma->resv && dma_resv_held(vma->resv));
^
include/linux/dma-resv.h:80:28: note: expanded from macro 'dma_resv_held'
#define dma_resv_held(obj) lockdep_is_held(&(obj)->lock.base)
^
1 error generated.
--
In file included from drivers/gpu/drm/i915/i915_vma.c:32:
In file included from drivers/gpu/drm/i915/gt/intel_gt.h:10:
In file included from drivers/gpu/drm/i915/gt/intel_gt_types.h:16:
In file included from drivers/gpu/drm/i915/gt/uc/intel_uc.h:9:
In file included from drivers/gpu/drm/i915/gt/uc/intel_guc.h:17:
>> drivers/gpu/drm/i915/i915_vma.h:245:28: error: implicit declaration of function 'lockdep_is_held' [-Werror,-Wimplicit-function-declaration]
WARN_ON_ONCE(vma->resv && dma_resv_held(vma->resv));
^
include/linux/dma-resv.h:80:28: note: expanded from macro 'dma_resv_held'
#define dma_resv_held(obj) lockdep_is_held(&(obj)->lock.base)
^
>> drivers/gpu/drm/i915/i915_vma.c:1014:30: error: implicit declaration of function 'lockdep_is_held' [-Werror,-Wimplicit-function-declaration]
WARN_ON(!ww && vma->resv && dma_resv_held(vma->resv));
^
include/linux/dma-resv.h:80:28: note: expanded from macro 'dma_resv_held'
#define dma_resv_held(obj) lockdep_is_held(&(obj)->lock.base)
^
2 errors generated.

vim +/lockdep_is_held +245 drivers/gpu/drm/i915/i915_vma.h

   237	
   238	int __must_check
   239	i915_vma_pin_ww(struct i915_vma *vma, struct i915_gem_ww_ctx *ww,
   240			u64 size, u64 alignment, u64 flags);
   241	
   242	static inline int __must_check
   243	i915_vma_pin(struct i915_vma *vma, u64 size, u64 alignment, u64 flags)
   244	{
 > 245		WARN_ON_ONCE(vma->resv && dma_resv_held(vma->resv));
   246		return i915_vma_pin_ww(vma, NULL, size, alignment, flags);
   247	}
   248	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org