From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4B34C433E2 for ; Thu, 21 May 2020 10:15:25 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9543F2072C for ; Thu, 21 May 2020 10:15:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="JpC9oiuA" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9543F2072C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:49080 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jbiEW-0007Sv-O9 for qemu-devel@archiver.kernel.org; Thu, 21 May 2020 06:15:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34316) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jbiDI-0005K9-R7 for qemu-devel@nongnu.org; Thu, 21 May 2020 06:14:08 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:36045 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jbiDI-0000U8-2a for qemu-devel@nongnu.org; Thu, 21 May 2020 06:14:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1590056047; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1QY+aiT5rT0UBmZ14JhETlIRue5uShjq6ECHNLxm3yM=; b=JpC9oiuAC3wVmNFFzhRqu8lsmIdGwwZPxtYIdNxzaupifjaV2UuL5QzhoLfkftowF+yE71 0fli9iOSlRv5DODwYmAH2QAz7Ibdf0SBHz9/c2BNEHcpMS5Orx76fyzYOk+Xi4M+EVtQrq VNczg+SYe/oajxBOkkJ9kxK3B3Gxj94= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-130-fqwwW_M9PfaRN_z5QddDgQ-1; Thu, 21 May 2020 06:14:04 -0400 X-MC-Unique: fqwwW_M9PfaRN_z5QddDgQ-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id BAEED460; Thu, 21 May 2020 10:14:02 +0000 (UTC) Received: from localhost (unknown [10.40.208.12]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5C60D5D9C9; Thu, 21 May 2020 10:13:51 +0000 (UTC) Date: Thu, 21 May 2020 12:13:47 +0200 From: Igor Mammedov To: Gerd Hoffmann Subject: Re: [PATCH v3 18/22] microvm/acpi: use GSI 16-23 for virtio Message-ID: <20200521121347.00ec6a26@redhat.com> In-Reply-To: <20200520132003.9492-19-kraxel@redhat.com> References: <20200520132003.9492-1-kraxel@redhat.com> <20200520132003.9492-19-kraxel@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=205.139.110.120; envelope-from=imammedo@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/21 06:06:22 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Eduardo Habkost , Sergio Lopez , "Michael S. Tsirkin" , qemu-devel@nongnu.org, Shannon Zhao , qemu-arm@nongnu.org, Paolo Bonzini , Richard Henderson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, 20 May 2020 15:19:59 +0200 Gerd Hoffmann wrote: > With ACPI enabled and IO-APIC being properly declared in the ACPI tables > we can use interrupt lines 16-23 for virtio and avoid shared interrupts. > > With acpi disabled we continue to use lines 8-15. > > Signed-off-by: Gerd Hoffmann > Reviewed-by: Sergio Lopez Reviewed-by: Igor Mammedov > --- > hw/i386/microvm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/i386/microvm.c b/hw/i386/microvm.c > index b38321112baa..7d8174809ae1 100644 > --- a/hw/i386/microvm.c > +++ b/hw/i386/microvm.c > @@ -125,7 +125,7 @@ static void microvm_devices_init(MicrovmMachineState *mms) > > kvmclock_create(); > > - mms->virtio_irq_base = 8; > + mms->virtio_irq_base = x86_machine_is_acpi_enabled(x86ms) ? 16 : 8; > for (i = 0; i < VIRTIO_NUM_TRANSPORTS; i++) { > sysbus_create_simple("virtio-mmio", > VIRTIO_MMIO_BASE + i * 512,