From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11A5DC433DF for ; Thu, 21 May 2020 10:37:55 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D3269204EC for ; Thu, 21 May 2020 10:37:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="EE29kYTi" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D3269204EC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:37702 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jbiaI-0006YG-1t for qemu-devel@archiver.kernel.org; Thu, 21 May 2020 06:37:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36930) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jbiZD-0005GV-R4 for qemu-devel@nongnu.org; Thu, 21 May 2020 06:36:47 -0400 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:48976 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jbiZC-0004uu-KB for qemu-devel@nongnu.org; Thu, 21 May 2020 06:36:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1590057405; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+2fs3cG+8vtlMMq9nJxJkMA+F7IRdFgVKcZa1gOqxJo=; b=EE29kYTi5YOnFjl1c/f8UqM/B2aPo25J+WFvE6JIPAHiuUAOj62XPCTSATbyDXwyTwNUWV HBFnPm8qMnj3dFNOhJlTz+62aV9/lyciby6+D4fn5lCXHrglF6xOXXk0WTrw31rpF33dZE pKkvbStw/VQreJf29qP66SnhK1OpHWs= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-70-pK472VI4NHOmn_r8zP5zbw-1; Thu, 21 May 2020 06:36:44 -0400 X-MC-Unique: pK472VI4NHOmn_r8zP5zbw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B8E41872FE1; Thu, 21 May 2020 10:36:42 +0000 (UTC) Received: from localhost (unknown [10.40.208.12]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3B44A79592; Thu, 21 May 2020 10:36:29 +0000 (UTC) Date: Thu, 21 May 2020 12:36:24 +0200 From: Igor Mammedov To: Gerd Hoffmann Subject: Re: [PATCH v3 22/22] [RfC] acpi: flip default to off for microvm Message-ID: <20200521123624.4f50fcf7@redhat.com> In-Reply-To: <20200520132003.9492-23-kraxel@redhat.com> References: <20200520132003.9492-1-kraxel@redhat.com> <20200520132003.9492-23-kraxel@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=205.139.110.61; envelope-from=imammedo@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/21 01:47:40 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Eduardo Habkost , Sergio Lopez , "Michael S. Tsirkin" , qemu-devel@nongnu.org, Shannon Zhao , qemu-arm@nongnu.org, Paolo Bonzini , Richard Henderson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, 20 May 2020 15:20:03 +0200 Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann > --- > hw/i386/microvm.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/hw/i386/microvm.c b/hw/i386/microvm.c > index 602c6a8f75f3..b5c445b5403b 100644 > --- a/hw/i386/microvm.c > +++ b/hw/i386/microvm.c > @@ -517,6 +517,7 @@ static void microvm_machine_initfn(Object *obj) > static void microvm_class_init(ObjectClass *oc, void *data) > { > MachineClass *mc = MACHINE_CLASS(oc); > + X86MachineClass *x86mc = X86_MACHINE_CLASS(oc); > > mc->init = microvm_machine_state_init; > > @@ -537,6 +538,9 @@ static void microvm_class_init(ObjectClass *oc, void *data) > /* Machine class handlers */ > mc->reset = microvm_machine_reset; > > + /* acpi is off by default */ > + x86mc->acpi_default = false; Since we don't care about compat stuff for microvm yet, I'd preffer default 'on', as in long run it allows to boot larger range of guests without need for tuning QEMU and guest configuration (i.e. it's the least troublesome case for ordinary user) > + > object_class_property_add(oc, MICROVM_MACHINE_PIC, "OnOffAuto", > microvm_machine_get_pic, > microvm_machine_set_pic,