From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 171D0C433DF for ; Thu, 21 May 2020 15:33:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E0E8E204EA for ; Thu, 21 May 2020 15:33:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="C6Qnseph" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728295AbgEUPdC (ORCPT ); Thu, 21 May 2020 11:33:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36662 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726938AbgEUPdB (ORCPT ); Thu, 21 May 2020 11:33:01 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 48F22C061A0F for ; Thu, 21 May 2020 08:33:01 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id n5so6801927wmd.0 for ; Thu, 21 May 2020 08:33:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=a+XGEo7RdRLWXaBT5I1D5SW4Aa/jygWE9YUzvCS9gvI=; b=C6QnsephZ4AXYbZbM1y/Cghfe4u+luUWsgG6OhW+RMXWdsfoZHD3nxlNwa1hYOht3T WTfDVrMB9YUP/UOKUCF8OVzgeCtW2v5g8iWYm18a9M2nlHg/NnB8Ir6MPtJ5w+UhTuNZ xvN1sB6mgklbOCg7LJog22flxrih0eY9gDBhU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=a+XGEo7RdRLWXaBT5I1D5SW4Aa/jygWE9YUzvCS9gvI=; b=chTxzlrUXiL1H6C3IJaXmkdEt4Dfqyez2pzrKGyh25eRa9qF2V65drbAaXMnkx8izo JOQ80DN7osV7jWggWcOS8iu1wN26LmEYggXsSHJ+Tuw0/3GrOaoZIWtMgMelaEAelaxH NpxsLPk2z8INQR3BaUW5TMwbRlCeOD00+4uDz1WO8e7SvSIcDhcVvXGZUz8ITiUP9xz/ cIxfC9VrGHYclrLfzSuVDU/sXjUHvhI9eQoBzZR/I88KyO0V7aHX6neUpc0AHhmx8Vp7 aRLOf0+IUtcZFWu3E9Oc118gI2qrHRz5xNpv7xq6xvMqPSimnKF+jbd83BQQA9MKCtwX gzxw== X-Gm-Message-State: AOAM532qQirveFEt6/kATez8kRn1MkXoWzQFvXrMI31+Gb04H9o+OxsN F+Jjjn4jTDae8dW19fo2G1nlKA== X-Google-Smtp-Source: ABdhPJx2S+yj9zmPBMi83WiNn64bblaOIC/n37oVO4cTDq4iHNfMT2oRcmN73GTSL9Yc4JsMWCaKAA== X-Received: by 2002:a7b:c4cc:: with SMTP id g12mr9202139wmk.168.1590075179928; Thu, 21 May 2020 08:32:59 -0700 (PDT) Received: from chromium.org (205.215.190.35.bc.googleusercontent.com. [35.190.215.205]) by smtp.gmail.com with ESMTPSA id i11sm7245926wrc.35.2020.05.21.08.32.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 May 2020 08:32:59 -0700 (PDT) Date: Thu, 21 May 2020 15:32:57 +0000 From: Tomasz Figa To: Xia Jiang Cc: Hans Verkuil , Mauro Carvalho Chehab , Rob Herring , Matthias Brugger , Rick Chang , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Marek Szyprowski , srv_heupstream@mediatek.com, senozhatsky@chromium.org, mojahsu@chromium.org, drinkcat@chromium.org, maoguang.meng@mediatek.com, sj.huang@mediatek.com Subject: Re: [PATCH v8 06/14] media: platform: Improve the implementation of the system PM ops Message-ID: <20200521153257.GF209565@chromium.org> References: <20200403094033.8288-1-xia.jiang@mediatek.com> <20200403094033.8288-7-xia.jiang@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200403094033.8288-7-xia.jiang@mediatek.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Xia, On Fri, Apr 03, 2020 at 05:40:25PM +0800, Xia Jiang wrote: > Cancel reset hw operation in suspend and resume function because this > will be done in device_run(). This and... > Add spin_lock and unlock operation in irq and resume function to make > sure that the current frame is processed completely before suspend. ...this are two separate changes. Please split. > > Signed-off-by: Xia Jiang > --- > drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c > index dd5cadd101ef..2fa3711fdc9b 100644 > --- a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c > +++ b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c > @@ -911,6 +911,8 @@ static irqreturn_t mtk_jpeg_dec_irq(int irq, void *priv) > u32 dec_ret; > int i; > > + spin_lock(&jpeg->hw_lock); > + nit: For consistency, it is recommended to always use the same, i.e. the strongest, spin_(un)lock_ primitives when operating on the same spinlock. In this case it would be the irqsave(restore) variants. > dec_ret = mtk_jpeg_dec_get_int_status(jpeg->dec_reg_base); > dec_irq_ret = mtk_jpeg_dec_enum_result(dec_ret); > ctx = v4l2_m2m_get_curr_priv(jpeg->m2m_dev); > @@ -941,6 +943,7 @@ static irqreturn_t mtk_jpeg_dec_irq(int irq, void *priv) > v4l2_m2m_buf_done(src_buf, buf_state); > v4l2_m2m_buf_done(dst_buf, buf_state); > v4l2_m2m_job_finish(jpeg->m2m_dev, ctx->fh.m2m_ctx); > + spin_unlock(&jpeg->hw_lock); > pm_runtime_put_sync(ctx->jpeg->dev); > return IRQ_HANDLED; > } > @@ -1191,7 +1194,6 @@ static __maybe_unused int mtk_jpeg_pm_suspend(struct device *dev) > { > struct mtk_jpeg_dev *jpeg = dev_get_drvdata(dev); > > - mtk_jpeg_dec_reset(jpeg->dec_reg_base); > mtk_jpeg_clk_off(jpeg); > > return 0; > @@ -1202,19 +1204,24 @@ static __maybe_unused int mtk_jpeg_pm_resume(struct device *dev) > struct mtk_jpeg_dev *jpeg = dev_get_drvdata(dev); > > mtk_jpeg_clk_on(jpeg); > - mtk_jpeg_dec_reset(jpeg->dec_reg_base); > > return 0; > } > > static __maybe_unused int mtk_jpeg_suspend(struct device *dev) > { > + struct mtk_jpeg_dev *jpeg = dev_get_drvdata(dev); > + unsigned long flags; > int ret; > > if (pm_runtime_suspended(dev)) > return 0; > > + spin_lock_irqsave(&jpeg->hw_lock, flags); What does this spinlock protect us from? I can see that it would prevent the interrupt handler from being called, but is it okay to suspend the system without handling the interrupt? > + > ret = mtk_jpeg_pm_suspend(dev); > + Looking at the implementation of mtk_jpeg_pm_suspend(), all it does is disabling the clock. How do we make sure that there is no frame currently being processed by the hardware? Best regards, Tomasz From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53DE7C433DF for ; Thu, 21 May 2020 15:33:14 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1F4AF20721 for ; Thu, 21 May 2020 15:33:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="H3L/hhz/"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="C6Qnseph" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1F4AF20721 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bN3KpoQy4sUgydDuQ/Yq+Y5XfFd6+BC8aoS9wYE0cQw=; b=H3L/hhz/ojd3J8 HzHhpGtgkmFoEqusCOj4/eEJFD5ffXhZHWDy1w73a81XUPG71peNESAxl6AiYBIDMs3MBRIT2LdL4 HhS37UGu7ZpHfv3Js3pPmS0xrJ/emWAnh44kxYrHyFMX3kuOGLxsqleSqFdaRCwKNdJGn+lu4qtyE vQmhgDXSbeJnp7j93/ULK/oM0MIfAbi24Qh7T0nWqfD3ZP0Jw5sF7HyX45/x2e0vJj91cg5cq8S/y Xf5JPS5B2P8TAoyzsnetMgrC/spcI4agMpr4yAyjEUCimin9FD3TLMjqVFxrq35EKrS9ZX439vO2j yQnSUL/fvTOh8aub6BdQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jbnBx-0002pe-6T; Thu, 21 May 2020 15:33:05 +0000 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jbnBu-0002oe-7r for linux-mediatek@lists.infradead.org; Thu, 21 May 2020 15:33:04 +0000 Received: by mail-wm1-x343.google.com with SMTP id w64so6767025wmg.4 for ; Thu, 21 May 2020 08:33:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=a+XGEo7RdRLWXaBT5I1D5SW4Aa/jygWE9YUzvCS9gvI=; b=C6QnsephZ4AXYbZbM1y/Cghfe4u+luUWsgG6OhW+RMXWdsfoZHD3nxlNwa1hYOht3T WTfDVrMB9YUP/UOKUCF8OVzgeCtW2v5g8iWYm18a9M2nlHg/NnB8Ir6MPtJ5w+UhTuNZ xvN1sB6mgklbOCg7LJog22flxrih0eY9gDBhU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=a+XGEo7RdRLWXaBT5I1D5SW4Aa/jygWE9YUzvCS9gvI=; b=FvJBidhdCcqVog68HfGPqOcs1d0Z2nVZZudCmJjefirV15uOza0mdtHDotLwk+Apem cCMR9o970eo/M9KeycUoVevbTLcjCVPIN5Ke+XSxkH3C41cDK9Z+u/YSoPwSKMWYkfQ2 bvMkBK22Q2zEj6nmGM0EBqDL7sQMT7Cpm+dLuRkPH5e5n1a+7og3SCOY5yT2uNNEezsF Kzu3FoHtwLarz9nCn4bF5xmpY7Se9K1feCiHQ5npQp6s7KUze+LD2PUJOEdr3D+9yT1L /vByLgq6TUz7o+BCGGPtSSDGHROon377SUvllGAsVuOVwF3ZRG+Z/VQJOa+nRpRK1V4v pAEQ== X-Gm-Message-State: AOAM532SSTBrSBrAF0J266dFMVhgz4PZNTOsVjqKUjDT7jPTkZvJJdxI 5n+a6/KiYi3UyO6k6+BH+gKdgw== X-Google-Smtp-Source: ABdhPJx2S+yj9zmPBMi83WiNn64bblaOIC/n37oVO4cTDq4iHNfMT2oRcmN73GTSL9Yc4JsMWCaKAA== X-Received: by 2002:a7b:c4cc:: with SMTP id g12mr9202139wmk.168.1590075179928; Thu, 21 May 2020 08:32:59 -0700 (PDT) Received: from chromium.org (205.215.190.35.bc.googleusercontent.com. [35.190.215.205]) by smtp.gmail.com with ESMTPSA id i11sm7245926wrc.35.2020.05.21.08.32.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 May 2020 08:32:59 -0700 (PDT) Date: Thu, 21 May 2020 15:32:57 +0000 From: Tomasz Figa To: Xia Jiang Subject: Re: [PATCH v8 06/14] media: platform: Improve the implementation of the system PM ops Message-ID: <20200521153257.GF209565@chromium.org> References: <20200403094033.8288-1-xia.jiang@mediatek.com> <20200403094033.8288-7-xia.jiang@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200403094033.8288-7-xia.jiang@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200521_083302_300136_B6F583C4 X-CRM114-Status: GOOD ( 18.00 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: drinkcat@chromium.org, devicetree@vger.kernel.org, mojahsu@chromium.org, srv_heupstream@mediatek.com, Rick Chang , senozhatsky@chromium.org, linux-kernel@vger.kernel.org, maoguang.meng@mediatek.com, Mauro Carvalho Chehab , sj.huang@mediatek.com, Rob Herring , Matthias Brugger , Hans Verkuil , linux-mediatek@lists.infradead.org, Marek Szyprowski , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hi Xia, On Fri, Apr 03, 2020 at 05:40:25PM +0800, Xia Jiang wrote: > Cancel reset hw operation in suspend and resume function because this > will be done in device_run(). This and... > Add spin_lock and unlock operation in irq and resume function to make > sure that the current frame is processed completely before suspend. ...this are two separate changes. Please split. > > Signed-off-by: Xia Jiang > --- > drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c > index dd5cadd101ef..2fa3711fdc9b 100644 > --- a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c > +++ b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c > @@ -911,6 +911,8 @@ static irqreturn_t mtk_jpeg_dec_irq(int irq, void *priv) > u32 dec_ret; > int i; > > + spin_lock(&jpeg->hw_lock); > + nit: For consistency, it is recommended to always use the same, i.e. the strongest, spin_(un)lock_ primitives when operating on the same spinlock. In this case it would be the irqsave(restore) variants. > dec_ret = mtk_jpeg_dec_get_int_status(jpeg->dec_reg_base); > dec_irq_ret = mtk_jpeg_dec_enum_result(dec_ret); > ctx = v4l2_m2m_get_curr_priv(jpeg->m2m_dev); > @@ -941,6 +943,7 @@ static irqreturn_t mtk_jpeg_dec_irq(int irq, void *priv) > v4l2_m2m_buf_done(src_buf, buf_state); > v4l2_m2m_buf_done(dst_buf, buf_state); > v4l2_m2m_job_finish(jpeg->m2m_dev, ctx->fh.m2m_ctx); > + spin_unlock(&jpeg->hw_lock); > pm_runtime_put_sync(ctx->jpeg->dev); > return IRQ_HANDLED; > } > @@ -1191,7 +1194,6 @@ static __maybe_unused int mtk_jpeg_pm_suspend(struct device *dev) > { > struct mtk_jpeg_dev *jpeg = dev_get_drvdata(dev); > > - mtk_jpeg_dec_reset(jpeg->dec_reg_base); > mtk_jpeg_clk_off(jpeg); > > return 0; > @@ -1202,19 +1204,24 @@ static __maybe_unused int mtk_jpeg_pm_resume(struct device *dev) > struct mtk_jpeg_dev *jpeg = dev_get_drvdata(dev); > > mtk_jpeg_clk_on(jpeg); > - mtk_jpeg_dec_reset(jpeg->dec_reg_base); > > return 0; > } > > static __maybe_unused int mtk_jpeg_suspend(struct device *dev) > { > + struct mtk_jpeg_dev *jpeg = dev_get_drvdata(dev); > + unsigned long flags; > int ret; > > if (pm_runtime_suspended(dev)) > return 0; > > + spin_lock_irqsave(&jpeg->hw_lock, flags); What does this spinlock protect us from? I can see that it would prevent the interrupt handler from being called, but is it okay to suspend the system without handling the interrupt? > + > ret = mtk_jpeg_pm_suspend(dev); > + Looking at the implementation of mtk_jpeg_pm_suspend(), all it does is disabling the clock. How do we make sure that there is no frame currently being processed by the hardware? Best regards, Tomasz _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC316C433E0 for ; Thu, 21 May 2020 15:33:21 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8A3F9204EC for ; Thu, 21 May 2020 15:33:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="NWZPmCDG"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="C6Qnseph" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8A3F9204EC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GA+9bguRsWUUR21VrDr7SohX6wSIZRT3jjwghjAQGCU=; b=NWZPmCDGYEyXgz +t1Ny59FF6gKLppO7gRQr4RBSOukIDRKYAexd2awRQ+B76iuz9BT2fFrC/8/LDFxOT3kLbS8V5S1b x48pVTbeQcXv++iLt+U0l3ojcjBCfSos2bC+SEEIKJ61KAvgBlIKzzZe6s1VQceWyFLkXWUXzW+Mm JowSUqqUCINIy/utKX2bhyC82dP3IkJcMF4yWsCi9Ba8NnMgkJNUKeG1e4xNOmMOXRj3ipLIfb7vf KvbRHh+ZWZ1YLoqeTJ6NwXWW2le/e6d1cUy8p9wGhSqf3yyuhu7mnhSemSqpULVDZUV9h+bWPXB+Z WBiBHmygRxEt2LIwvNnQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jbnC0-0002rD-8p; Thu, 21 May 2020 15:33:08 +0000 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jbnBu-0002of-Cp for linux-arm-kernel@lists.infradead.org; Thu, 21 May 2020 15:33:05 +0000 Received: by mail-wm1-x344.google.com with SMTP id u12so1994825wmd.3 for ; Thu, 21 May 2020 08:33:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=a+XGEo7RdRLWXaBT5I1D5SW4Aa/jygWE9YUzvCS9gvI=; b=C6QnsephZ4AXYbZbM1y/Cghfe4u+luUWsgG6OhW+RMXWdsfoZHD3nxlNwa1hYOht3T WTfDVrMB9YUP/UOKUCF8OVzgeCtW2v5g8iWYm18a9M2nlHg/NnB8Ir6MPtJ5w+UhTuNZ xvN1sB6mgklbOCg7LJog22flxrih0eY9gDBhU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=a+XGEo7RdRLWXaBT5I1D5SW4Aa/jygWE9YUzvCS9gvI=; b=hZlg1HpP3awB5sQCH6Iha2cXFJVMBPqZjnQQoOLFOkz4AlHVx1N7vNIF8m/ibRlP6Z eRuePI6QxN5lLbykltHUDv0nzgln5244Rv6SphFQUCA90gpga/UE9lEvagU+P6NefhMP Y3MU4UwIqLuSvlfBA9gYVzKnoc6vy4wtmuwMdGLkJLHmvTGY7rK2X/45nZafY3kIdRcO ulp9BO+wDbEJPWLxSHQLOmCbBB6DAAu9tBH96feeYtr0Ei7QjwkExuMSV68zkfHd25ip Qi1PsVQ5Jha2nJ9JzAoDUyKXXLbmGRF93dQ97hy3dEXiyhskrTY47AEBCY2YYbXKBngi ybtg== X-Gm-Message-State: AOAM533kn1pPHXJqpziYwdIXfjFGo518R5QxaAoexcB7X8mWRHpb93iX nsksvwURO/Vl2tBlt/gDltiPpA== X-Google-Smtp-Source: ABdhPJx2S+yj9zmPBMi83WiNn64bblaOIC/n37oVO4cTDq4iHNfMT2oRcmN73GTSL9Yc4JsMWCaKAA== X-Received: by 2002:a7b:c4cc:: with SMTP id g12mr9202139wmk.168.1590075179928; Thu, 21 May 2020 08:32:59 -0700 (PDT) Received: from chromium.org (205.215.190.35.bc.googleusercontent.com. [35.190.215.205]) by smtp.gmail.com with ESMTPSA id i11sm7245926wrc.35.2020.05.21.08.32.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 May 2020 08:32:59 -0700 (PDT) Date: Thu, 21 May 2020 15:32:57 +0000 From: Tomasz Figa To: Xia Jiang Subject: Re: [PATCH v8 06/14] media: platform: Improve the implementation of the system PM ops Message-ID: <20200521153257.GF209565@chromium.org> References: <20200403094033.8288-1-xia.jiang@mediatek.com> <20200403094033.8288-7-xia.jiang@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200403094033.8288-7-xia.jiang@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200521_083302_429807_6986C2EC X-CRM114-Status: GOOD ( 19.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: drinkcat@chromium.org, devicetree@vger.kernel.org, mojahsu@chromium.org, srv_heupstream@mediatek.com, Rick Chang , senozhatsky@chromium.org, linux-kernel@vger.kernel.org, maoguang.meng@mediatek.com, Mauro Carvalho Chehab , sj.huang@mediatek.com, Rob Herring , Matthias Brugger , Hans Verkuil , linux-mediatek@lists.infradead.org, Marek Szyprowski , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Xia, On Fri, Apr 03, 2020 at 05:40:25PM +0800, Xia Jiang wrote: > Cancel reset hw operation in suspend and resume function because this > will be done in device_run(). This and... > Add spin_lock and unlock operation in irq and resume function to make > sure that the current frame is processed completely before suspend. ...this are two separate changes. Please split. > > Signed-off-by: Xia Jiang > --- > drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c > index dd5cadd101ef..2fa3711fdc9b 100644 > --- a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c > +++ b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c > @@ -911,6 +911,8 @@ static irqreturn_t mtk_jpeg_dec_irq(int irq, void *priv) > u32 dec_ret; > int i; > > + spin_lock(&jpeg->hw_lock); > + nit: For consistency, it is recommended to always use the same, i.e. the strongest, spin_(un)lock_ primitives when operating on the same spinlock. In this case it would be the irqsave(restore) variants. > dec_ret = mtk_jpeg_dec_get_int_status(jpeg->dec_reg_base); > dec_irq_ret = mtk_jpeg_dec_enum_result(dec_ret); > ctx = v4l2_m2m_get_curr_priv(jpeg->m2m_dev); > @@ -941,6 +943,7 @@ static irqreturn_t mtk_jpeg_dec_irq(int irq, void *priv) > v4l2_m2m_buf_done(src_buf, buf_state); > v4l2_m2m_buf_done(dst_buf, buf_state); > v4l2_m2m_job_finish(jpeg->m2m_dev, ctx->fh.m2m_ctx); > + spin_unlock(&jpeg->hw_lock); > pm_runtime_put_sync(ctx->jpeg->dev); > return IRQ_HANDLED; > } > @@ -1191,7 +1194,6 @@ static __maybe_unused int mtk_jpeg_pm_suspend(struct device *dev) > { > struct mtk_jpeg_dev *jpeg = dev_get_drvdata(dev); > > - mtk_jpeg_dec_reset(jpeg->dec_reg_base); > mtk_jpeg_clk_off(jpeg); > > return 0; > @@ -1202,19 +1204,24 @@ static __maybe_unused int mtk_jpeg_pm_resume(struct device *dev) > struct mtk_jpeg_dev *jpeg = dev_get_drvdata(dev); > > mtk_jpeg_clk_on(jpeg); > - mtk_jpeg_dec_reset(jpeg->dec_reg_base); > > return 0; > } > > static __maybe_unused int mtk_jpeg_suspend(struct device *dev) > { > + struct mtk_jpeg_dev *jpeg = dev_get_drvdata(dev); > + unsigned long flags; > int ret; > > if (pm_runtime_suspended(dev)) > return 0; > > + spin_lock_irqsave(&jpeg->hw_lock, flags); What does this spinlock protect us from? I can see that it would prevent the interrupt handler from being called, but is it okay to suspend the system without handling the interrupt? > + > ret = mtk_jpeg_pm_suspend(dev); > + Looking at the implementation of mtk_jpeg_pm_suspend(), all it does is disabling the clock. How do we make sure that there is no frame currently being processed by the hardware? Best regards, Tomasz _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel