From mboxrd@z Thu Jan 1 00:00:00 1970 From: Viresh Kumar Date: Fri, 22 May 2020 12:42:58 +0530 Subject: [LTP] [PATCH 3/5] syscalls: semctl: Add new test to verify the _time_high fields In-Reply-To: <20200521142621.GE7833@yuki.lan> References: <5d502fbc7070644ed83c423713941b457c3a7aff.1590057824.git.viresh.kumar@linaro.org> <20200521142621.GE7833@yuki.lan> Message-ID: <20200522071258.bgajo3a7mngmhr6y@vireshk-i7> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ltp@lists.linux.it On 21-05-20, 16:26, Cyril Hrubis wrote: > Hi! > > > The _time_high fields must be reset by the kernel, add a test to verify > > > that. > > > > > > Suggested-by: Arnd Bergmann > > > Signed-off-by: Viresh Kumar > > > > Right, here you do need to copy the struct definitions since I forgot > > to add a way to detect the presence in the kernel header files, > > sorry about that. > > > > Possibly you could just have a check in the Makefile that lets > > skips the test if it fails to build because of old kernel headers? > > Or maybe check LINUX_VERSION_CODE to see if the headers > > are at least from linux-4.19? > > We usually include autotools checks and fallback definitions in > include/lapi.h in this case. And that's what my patches are doing. They check for #ifndef HAVE_MSQID64_DS and then only go define them. We can't work with kernel versions due to possible backporting of the patches to older kernels. -- viresh