From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AAC7DC433DF for ; Fri, 22 May 2020 17:25:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 84E6C206C3 for ; Fri, 22 May 2020 17:25:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730701AbgEVRZf (ORCPT ); Fri, 22 May 2020 13:25:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53188 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730554AbgEVRZf (ORCPT ); Fri, 22 May 2020 13:25:35 -0400 Received: from hera.aquilenet.fr (hera.aquilenet.fr [IPv6:2a0c:e300::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4F3D6C061A0E for ; Fri, 22 May 2020 10:25:35 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 9D2733BA9; Fri, 22 May 2020 19:25:33 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id f7N5Eo55GPMW; Fri, 22 May 2020 19:25:32 +0200 (CEST) Received: from function (lfbn-bor-1-797-11.w86-234.abo.wanadoo.fr [86.234.239.11]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 6214F3B89; Fri, 22 May 2020 19:25:32 +0200 (CEST) Received: from samy by function with local (Exim 4.93) (envelope-from ) id 1jcBQJ-00HAVN-9Y; Fri, 22 May 2020 19:25:31 +0200 Date: Fri, 22 May 2020 19:25:31 +0200 From: Samuel Thibault To: Joe Perches Cc: Dan Carpenter , MugilRaj , devel@driverdev.osuosl.org, Kirk Reiser , Greg Kroah-Hartman , speakup@linux-speakup.org, linux-kernel@vger.kernel.org, Chris Brannon Subject: Re: [PATCH] taging: speakup: remove volatile Message-ID: <20200522172531.va2hi6jqog3a6473@function> Mail-Followup-To: Samuel Thibault , Joe Perches , Dan Carpenter , MugilRaj , devel@driverdev.osuosl.org, Kirk Reiser , Greg Kroah-Hartman , speakup@linux-speakup.org, linux-kernel@vger.kernel.org, Chris Brannon References: <1590138989-6091-1-git-send-email-dmugil2000@gmail.com> <20200522103406.GK30374@kadam> <6ab4139ec78928961a19e5fdbda139bb8cff9cb5.camel@perches.com> <20200522171312.s2ciifuxozwav2ym@function> <162676bb69044efadd31daa9ea49fc6fb9664297.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <162676bb69044efadd31daa9ea49fc6fb9664297.camel@perches.com> Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Joe Perches, le ven. 22 mai 2020 10:22:03 -0700, a ecrit: > > Put another way: I don't think putting any hint here would help, on the > > contrary, somebody has to really look at what protection is needed, > > without getting influenced by rules-of-thumb. > > checkpatch newbies/robots will submit this change again otherwise. Ah, ok, right. I don't think removing volatiles is a thing for newbies, > Comment wording can always be improved. I'd then suggest /* TODO: determine what proper synchronization "volatile" should be * replaced with. */ Samuel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37586C433E0 for ; Fri, 22 May 2020 17:25:39 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 12372206C3 for ; Fri, 22 May 2020 17:25:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 12372206C3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ens-lyon.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id D9A3187927; Fri, 22 May 2020 17:25:38 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 23t7OvMXuVDG; Fri, 22 May 2020 17:25:38 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by whitealder.osuosl.org (Postfix) with ESMTP id 303188789B; Fri, 22 May 2020 17:25:38 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 596451BF3BC for ; Fri, 22 May 2020 17:25:37 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 55C8D88C7E for ; Fri, 22 May 2020 17:25:37 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rW6140AduX8Z for ; Fri, 22 May 2020 17:25:35 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from hera.aquilenet.fr (hera.aquilenet.fr [185.233.100.1]) by hemlock.osuosl.org (Postfix) with ESMTPS id 8BBFC88C45 for ; Fri, 22 May 2020 17:25:35 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 9D2733BA9; Fri, 22 May 2020 19:25:33 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id f7N5Eo55GPMW; Fri, 22 May 2020 19:25:32 +0200 (CEST) Received: from function (lfbn-bor-1-797-11.w86-234.abo.wanadoo.fr [86.234.239.11]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 6214F3B89; Fri, 22 May 2020 19:25:32 +0200 (CEST) Received: from samy by function with local (Exim 4.93) (envelope-from ) id 1jcBQJ-00HAVN-9Y; Fri, 22 May 2020 19:25:31 +0200 Date: Fri, 22 May 2020 19:25:31 +0200 From: Samuel Thibault To: Joe Perches Subject: Re: [PATCH] taging: speakup: remove volatile Message-ID: <20200522172531.va2hi6jqog3a6473@function> Mail-Followup-To: Samuel Thibault , Joe Perches , Dan Carpenter , MugilRaj , devel@driverdev.osuosl.org, Kirk Reiser , Greg Kroah-Hartman , speakup@linux-speakup.org, linux-kernel@vger.kernel.org, Chris Brannon References: <1590138989-6091-1-git-send-email-dmugil2000@gmail.com> <20200522103406.GK30374@kadam> <6ab4139ec78928961a19e5fdbda139bb8cff9cb5.camel@perches.com> <20200522171312.s2ciifuxozwav2ym@function> <162676bb69044efadd31daa9ea49fc6fb9664297.camel@perches.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <162676bb69044efadd31daa9ea49fc6fb9664297.camel@perches.com> Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, Kirk Reiser , Greg Kroah-Hartman , speakup@linux-speakup.org, linux-kernel@vger.kernel.org, MugilRaj , Dan Carpenter , Chris Brannon Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" Joe Perches, le ven. 22 mai 2020 10:22:03 -0700, a ecrit: > > Put another way: I don't think putting any hint here would help, on the > > contrary, somebody has to really look at what protection is needed, > > without getting influenced by rules-of-thumb. > > checkpatch newbies/robots will submit this change again otherwise. Ah, ok, right. I don't think removing volatiles is a thing for newbies, > Comment wording can always be improved. I'd then suggest /* TODO: determine what proper synchronization "volatile" should be * replaced with. */ Samuel _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel