From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B520C433DF for ; Fri, 22 May 2020 21:51:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7A21B2065C for ; Fri, 22 May 2020 21:51:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590184314; bh=WK1HQJOS67m492IGKNEduQ99qia3r68mU/VbS11VuRo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=0IM7vpVoYOPktXkdZn2Hof0Cs/1BKpntwcRU6JRixba7uGoRpc4/wSrLe5dy9q7G2 F2opgjdRR+zrRuw9i51JCevisf7AbipJ5HG038zXxpK7zC2uj6woraWF8RB4NlZCHt Jnh4a2YEeNdF4+QItei/dsQ0G1XcvaHu3X7LwQ9U= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731132AbgEVVvt (ORCPT ); Fri, 22 May 2020 17:51:49 -0400 Received: from mail-pf1-f193.google.com ([209.85.210.193]:36248 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731098AbgEVVvt (ORCPT ); Fri, 22 May 2020 17:51:49 -0400 Received: by mail-pf1-f193.google.com with SMTP id e11so4846370pfn.3; Fri, 22 May 2020 14:51:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Z9B4bZk+E5XNnSc8/L/uVYEy0FFzcjh8GSMiMFaQ5cU=; b=EC1Xbc9L/RMNKGdiQumAl346JCUKdf/G8NM7A0UWdBgT51zmwa5qg4ZjzgbP04ijZ4 g6R2MF0jTGQ6mb1JjVWJhlazLapT+wzMFuViprghR3+h42RcvxK9+0tkrOwOsZGE3K26 NmYwLRpmIVskWYpRq3LxOy8Ca5dfrLHKcYl0xM/+REhkX+CGf6MtZdxls7DG0HdV3AIW Ltqcax26CLL6F1Su/mfouhoz1nSCnOrLTbtUXxzOcpF7C9PhDa4OZZxoImcpBIwgMcWb cZxKWC2XglyXK+XGo4jtGACJDVL/lQ2uuYGgZqT5eSx9FHWKOFZ9G1B1hMDPcDVeHo3M At5g== X-Gm-Message-State: AOAM5321n3R+TZT2sM8IJnUyG82tp0FUiKk0cdd7NL0ZZrnhS47/ffAv h54wDh31Okb/bKS9iCL4nlo= X-Google-Smtp-Source: ABdhPJzcUJoVZSYg2I5qX4WrfgIvy28/Y0K9mfCZGDbP1o1kz3N2Ybs2nMxPYUjAV7xiLzsbiPVsyA== X-Received: by 2002:a05:6a00:843:: with SMTP id q3mr5601514pfk.107.1590184307967; Fri, 22 May 2020 14:51:47 -0700 (PDT) Received: from 42.do-not-panic.com (42.do-not-panic.com. [157.230.128.187]) by smtp.gmail.com with ESMTPSA id a142sm7175101pfa.6.2020.05.22.14.51.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 May 2020 14:51:46 -0700 (PDT) Received: by 42.do-not-panic.com (Postfix, from userid 1000) id CEDDD40321; Fri, 22 May 2020 21:51:45 +0000 (UTC) Date: Fri, 22 May 2020 21:51:45 +0000 From: Luis Chamberlain To: Johannes Berg Cc: Jakub Kicinski , derosier@gmail.com, greearb@candelatech.com, jeyu@kernel.org, akpm@linux-foundation.org, arnd@arndb.de, rostedt@goodmis.org, mingo@redhat.com, aquini@redhat.com, cai@lca.pw, dyoung@redhat.com, bhe@redhat.com, peterz@infradead.org, tglx@linutronix.de, gpiccoli@canonical.com, pmladek@suse.com, tiwai@suse.de, schlad@suse.de, andriy.shevchenko@linux.intel.com, keescook@chromium.org, daniel.vetter@ffwll.ch, will@kernel.org, mchehab+samsung@kernel.org, kvalo@codeaurora.org, davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, ath10k@lists.infradead.org, jiri@resnulli.us, briannorris@chromium.org Subject: Re: [RFC 1/2] devlink: add simple fw crash helpers Message-ID: <20200522215145.GC11244@42.do-not-panic.com> References: <20200519010530.GS11244@42.do-not-panic.com> <20200519211531.3702593-1-kuba@kernel.org> <20200522052046.GY11244@42.do-not-panic.com> <20200522101738.1495f4cc@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <2e5199edb433c217c7974ef7408ff8c7253145b6.camel@sipsolutions.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2e5199edb433c217c7974ef7408ff8c7253145b6.camel@sipsolutions.net> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Fri, May 22, 2020 at 10:46:07PM +0200, Johannes Berg wrote: > FWIW, I still completely disagree on that taint. You (Luis) obviously > have been running into a bug in that driver, I doubt the firmware > actually managed to wedge the hardware. This hasn't happened just once, its happed many times sporadically now, once a week or two weeks I'd say. And the system isn't being moved around. > But even if it did, that's still not really a kernel taint. The kernel > itself isn't in any way affected by this. Of course it is, a full reboot is required. > Yes, the system is in a weird state now. But that's *not* equivalent to > "kernel tainted". Requiring a full reboot is a dire situation to be in, and loosing connectivity to the point this is not recoverable likewise. You guys are making out a taint to be the end of the world. We have a taint even for a kernel warning, and as others have mentioned mac80211 already produces these. What exactly is the opposition to a taint to clarify that a device firmware has crashed and your system requires a full reboot? Luis From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-pg1-f195.google.com ([209.85.215.195]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jcFa3-0006N4-2f for ath10k@lists.infradead.org; Fri, 22 May 2020 21:51:52 +0000 Received: by mail-pg1-f195.google.com with SMTP id p21so5605059pgm.13 for ; Fri, 22 May 2020 14:51:48 -0700 (PDT) Date: Fri, 22 May 2020 21:51:45 +0000 From: Luis Chamberlain Subject: Re: [RFC 1/2] devlink: add simple fw crash helpers Message-ID: <20200522215145.GC11244@42.do-not-panic.com> References: <20200519010530.GS11244@42.do-not-panic.com> <20200519211531.3702593-1-kuba@kernel.org> <20200522052046.GY11244@42.do-not-panic.com> <20200522101738.1495f4cc@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <2e5199edb433c217c7974ef7408ff8c7253145b6.camel@sipsolutions.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <2e5199edb433c217c7974ef7408ff8c7253145b6.camel@sipsolutions.net> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Johannes Berg Cc: linux-wireless@vger.kernel.org, aquini@redhat.com, peterz@infradead.org, daniel.vetter@ffwll.ch, mchehab+samsung@kernel.org, will@kernel.org, greearb@candelatech.com, bhe@redhat.com, briannorris@chromium.org, ath10k@lists.infradead.org, derosier@gmail.com, tiwai@suse.de, mingo@redhat.com, Jakub Kicinski , dyoung@redhat.com, pmladek@suse.com, jiri@resnulli.us, keescook@chromium.org, arnd@arndb.de, gpiccoli@canonical.com, rostedt@goodmis.org, cai@lca.pw, tglx@linutronix.de, andriy.shevchenko@linux.intel.com, kvalo@codeaurora.org, netdev@vger.kernel.org, schlad@suse.de, linux-kernel@vger.kernel.org, jeyu@kernel.org, akpm@linux-foundation.org, davem@davemloft.net On Fri, May 22, 2020 at 10:46:07PM +0200, Johannes Berg wrote: > FWIW, I still completely disagree on that taint. You (Luis) obviously > have been running into a bug in that driver, I doubt the firmware > actually managed to wedge the hardware. This hasn't happened just once, its happed many times sporadically now, once a week or two weeks I'd say. And the system isn't being moved around. > But even if it did, that's still not really a kernel taint. The kernel > itself isn't in any way affected by this. Of course it is, a full reboot is required. > Yes, the system is in a weird state now. But that's *not* equivalent to > "kernel tainted". Requiring a full reboot is a dire situation to be in, and loosing connectivity to the point this is not recoverable likewise. You guys are making out a taint to be the end of the world. We have a taint even for a kernel warning, and as others have mentioned mac80211 already produces these. What exactly is the opposition to a taint to clarify that a device firmware has crashed and your system requires a full reboot? Luis _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k