From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8FA9C433E1 for ; Sat, 23 May 2020 18:11:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A4A1020787 for ; Sat, 23 May 2020 18:11:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387860AbgEWSLm (ORCPT ); Sat, 23 May 2020 14:11:42 -0400 Received: from muru.com ([72.249.23.125]:55632 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726865AbgEWSLl (ORCPT ); Sat, 23 May 2020 14:11:41 -0400 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 87AB980F3; Sat, 23 May 2020 18:12:31 +0000 (UTC) Date: Sat, 23 May 2020 11:11:38 -0700 From: Tony Lindgren To: "H. Nikolaus Schaller" Cc: Evgeniy Polyakov , Greg Kroah-Hartman , YueHaibing , linux-kernel@vger.kernel.org, kernel@pyra-handheld.com, letux-kernel@openphoenux.org, linux-omap@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH 2/4] w1: omap-hdq: fix return value to be -1 if there is a timeout Message-ID: <20200523181138.GF37466@atomide.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * H. Nikolaus Schaller [200523 17:34]: > The code accidentially overwrites the variable ret and not val, > which is returned. So it will return the initial value 0 instead > of -1. Oops, sorry about causing this. And thanks for catching it: Acked-by: Tony Lindgren